-
Notifications
You must be signed in to change notification settings - Fork 61
DPR: Quality Presets and Recommended Preset #1228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
Why don't the settings with sliders appear when you use the fast graphics preset? Is this intentional? Also, could we conform this PR's description to the project's standard? |
It's because fancy shadows is disabled on fast. The bubble is still filled because of an existing bug with bubbles and being unable to update them, which I will patch as soon as UI Refactor drops (UI Refactor before GTA 6?)
...fine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I enable fancy shadows on "fast" it switches to custom mode, but then if I switch back to "fast" it still shows fancy shadows enabled.
Screen.Recording.2025-07-22.at.10.14.38.AM.mov
Please see this comment, this comment, and this comment. |
My bad, I didn't notice that. I think pr #1229 should solve your issue. On another note, would it be possible for you to add a button that the user can press that reruns the optimization? Not really required but I do think that it would add some nice polish. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is fine for setting graphics quality but it isn't very accurate. Currently we just get the memory and cores which doesn't give an accurate estimate of device performance as cpu core performance can vary wildly. In my opinion it would be best to run a simple performance test, but I am fine approving this if we don't want to bother with that.
In my experience with web game development with doing performance tests, they aren't too reliable. There are too many factors that could sway the results of the test (surviv.io did an auto graphics adjustment, and the performance test was 4000 lines of mess). Of course it's still totally an option, but would probably be a whole other 8 point ticket, and grabbing the specs/ram is usually enough to make a guess (and yes, 4gb and 2c are tested values) |
…presets' into aries/1781/quality-presets
@ariesninjadev now that pr #1229 was merged into dev, are you able to make it so that the checkboxes work properly? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting an issue where if I:
- Graphics Settings -> Fast -> Accept
- Graphics Settings -> Fast -> Cancel
Then some lighting setting updates and everything goes dark.
I'm also getting toasts about settings being updated and saved everytime I open the panel. Not sure if this is also the behaviour on dev
but it feels not quite right.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(New PR for #1158 due to it being on my personal fork)
Task
Allow users to have access to graphics presets that will speed up their ability to tune their visuals to match their desired output/device's computing demands
AARD-1781 and AARD-1919
Symptom
"What!? There isn't a 'Fancy' graphics setting? I'm quitting this game 😡"
Solution
This PR adds quality presets to the graphics settings modal, and allows Synthesis to automatically select the low (or "fast") graphics preset based on certain parameters including whether the device is a mobile device, or the specs are low. Check the Recommended Settings section for help on testing the recommended settings functionality.
Presets
Fast Graphics (Low)

Balanced Graphics (Medium)

Fancy Graphics (High)

If any options are changed, the preset is automatically set to "Custom":

Recommended Settings
The recommended settings are only applied to a device once. We then save whether or not this optimization has been applied in localstorage. To tell the browser that we haven't run the optimization yet, run the following in dev tools:
Then, you can emulate mobile device headers by using device mode in dev tools:

Finally, reload the page.
Verification
Before merging, ensure the following criteria are met: