Skip to content

Tiled Gallery Block: Images don't follow the "jetpack_photon_skip_image" filter #42961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ninodevo opened this issue Apr 8, 2025 · 2 comments
Labels
[Experiment] AI labels added [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] Auto-allocated Triaged [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it

Comments

@Ninodevo
Copy link
Contributor

Ninodevo commented Apr 8, 2025

Impacted plugin

Jetpack

Quick summary

The Tiled Gallery Block always uses Proton CDN images, and there is no way to disable this. While the jetpack_photon_skip_image filter can be used to disable Photon for individual images, it is not applied in the Tiled Gallery Block.

This causes issues for individual images that need to be served directly from the site, for example, protected images.

Steps to reproduce

  1. Add the filter to skip all photon images add_filter( 'jetpack_photon_skip_image', '__return_true' ); (easier for testing, in a real case scenario we won't skip all images).
  2. Add the Tiled Gallery Block.
  3. Images are served through Photon.

Site owner impact

Fewer than 20% of the total website/platform users

Severity

Minor

What other impact(s) does this issue have?

No response

If a workaround is available, please outline it here.

No response

Platform (Simple and/or Atomic)

No response

@Ninodevo Ninodevo added [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Apr 8, 2025
@github-actions github-actions bot added [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Jetpack [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins labels Apr 8, 2025
Copy link
Contributor

github-actions bot commented Apr 8, 2025

OpenAI suggested the following labels for this issue:

  • [Feature Group] Content Management: The issue relates to managing content displayed through the Tiled Gallery Block and how images are processed.
  • [Feature] Jetpack: The issue is specifically related to the Jetpack plugin and its functionalities, particularly concerning image handling.
  • [Feature] Photon: The problem arises from the use of the Photon feature for image delivery, which is not respecting the provided filter.

@valterlorran
Copy link
Contributor

valterlorran commented Apr 8, 2025

I was able to reproduce this. I believe @Automattic/jetpack-vulcan could help us with that.

I believe this is happening when we add the block and "photonize" the images:
https://github.com/Automattic/jetpack/blob/trunk/projects/plugins/jetpack/extensions/blocks/tiled-gallery/layout/index.js#L41

@valterlorran valterlorran moved this from Needs Triage to In Triage in Automattic Prioritization: The One Board ™ Apr 8, 2025
@jeherve jeherve moved this from In Triage to Triaged in Automattic Prioritization: The One Board ™ Apr 8, 2025
@jeherve jeherve added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. Triaged and removed [Feature Group] Content Management Features related to the tools and screens that admins use to manage their sites core content. [Feature] Jetpack [Type] Bug When a feature is broken and / or not performing as intended Needs triage Ticket needs to be triaged labels Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Experiment] AI labels added [Feature] Photon aka "Image CDN". Feature developed in the Image CDN package and shipped in multiple plugins [Feature] Tiled Gallery A different way to display image galleries on your site, in different organizations and shapes. [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Pri] Low [Status] Auto-allocated Triaged [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
Development

No branches or pull requests

4 participants