-
Notifications
You must be signed in to change notification settings - Fork 842
Likes: fix disabled bug #45951
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: trunk
Are you sure you want to change the base?
Likes: fix disabled bug #45951
Conversation
|
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 Follow this PR Review Process:
If you have questions about anything, reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 1 file.
|
jeherve
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
make sure the Like option is also disabled in the post settings.
I struggled with that part of the test as I was testing on self-hosted, where that option is no longer available.
On WordPress.com simple, I am able to toggle this option on and off, but I think my testing environment was different from yours. I added a Like block to my theme's single posts template. When doing so, the Like button appears under all posts on the site, regardless of that "WordPress.com Likes are Turned on per post" option. However, I am not able to Like posts. I get a JavaScript error (Uncaught TypeError: can't access property "parentNode", wplbuttonlink is null) which I think is caused by a different issue (the Like block markup is a bit different from the legacy Like markup).
Did you test this differently?
Closes https://linear.app/a8c/issue/CML-1013/likes-notification-and-email-delivery-issue-for-renwulfcreationscom-no
Proposed changes:
Other information:
Currently the Likes block enables the ability to like a post, but without the
wpl_is_enabled_sitewidesetting enabled we do not have notifications being handled. Forcing this to be true should solve the issue.I chose to use the sitewide setting rather than the post since this block could and likely exists in a template or reusable block.
Jetpack product discussion
n/a
Does this pull request change what data or activity we track or use?
No
Testing instructions: