Skip to content

Blocks: remove green icon color and use default color instead #45992

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 20, 2025
Merged

Blocks: remove green icon color and use default color instead #45992

merged 2 commits into from
Nov 20, 2025
+84 −202

Conversation

@enejb
Copy link
Member

@enejb enejb commented Nov 19, 2025 •
edited by simison
Loading

Alternative to #45987

Part of FORMS-265 (CIAB sites)

Product convo for WP.com and Jetpack p1763050188308419-slack-C029GN3KD

Before

Screenshot 2025-11-20 at 12 13 31 Screenshot 2025-11-20 at 12 13 36 Screenshot 2025-11-20 at 12 11 28

After

Screenshot 2025-11-20 at 11 47 15 Screenshot 2025-11-20 at 11 47 03 Screenshot 2025-11-20 at 11 46 06

On WP.com, no change since the color was never applied there.

Remove all the references to getIconColor from the codebase.
We want to remove any way to get the icon color for block icons.

This PR removed any referenced to setting the block icons to green instead of the default black.

Proposed changes:

  • Remove any reference to getIconColor from the code base.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

TBD

Does this pull request change what data or activity we track or use?

No

Testing instructions:

Load up the editor. Scroll though the block editor notice that the getIconColor for all the jetpack icons is set to the default black one.

Eveything builds as expected.

@enejb enejb requested a review from a team November 19, 2025 06:35
@enejb enejb added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review This PR is ready for review. labels Nov 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025 •
edited
Loading

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the update/remove-getIconColor branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack update/remove-getIconColor

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/remove-getIconColor

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions github-actions bot added [Block] Blogroll [Block] Contact Form Form block (also see Contact Form label) [Block] Send a message [Feature] Contact Form [JS Package] Shared Extension Utils [Package] Forms [Package] Paypal Payments [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Paypal Payment Buttons [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Plugin] Wpcomsh [Tests] Includes Tests Docs RNA labels Nov 19, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Nov 19, 2025 •
edited
Loading

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen as soon as you deploy your changes after merging this PR (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly:
    • Scheduled release: December 2, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Backup plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Boost plugin:

  • Next scheduled release: November 26, 2025

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Search plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Social plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Starter Plugin plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Protect plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Videopress plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Classic Theme helper plugin plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Paypal Payment buttons plugin:

No scheduled milestone found for this plugin.

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@jp-launch-control
Copy link

jp-launch-control bot commented Nov 19, 2025

Code Coverage Summary

Coverage changed in 3 files.

File Coverage Δ% Δ Uncovered
projects/js-packages/shared-extension-utils/src/get-icon-color.js 0/1 (0.00%) 0.00% -3 💚
projects/js-packages/shared-extension-utils/src/block-icons.js 0/1 (0.00%) 0.00% -4 💚
projects/packages/forms/src/blocks/shared/util/block-icons.js 0/1 (0.00%) 0.00% -4 💚

Full summary · PHP report · JS report

@simison simison mentioned this pull request Nov 19, 2025
Closed
3 tasks
@simison simison requested review from ilonagl and keoshi November 19, 2025 08:26
simison
simison approved these changes Nov 20, 2025
View reviewed changes
Copy link
Member

@simison simison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests well, especially around areas that looked problematic earlier.

Image Image Image

@simison simison changed the title Update/remove get icon color Blocks: remove green icon color and use default color instead Nov 20, 2025
@simison simison merged commit 901e20b into trunk Nov 20, 2025
92 of 95 checks passed
@simison simison deleted the update/remove-getIconColor branch November 20, 2025 10:14
@github-actions github-actions bot removed the [Status] Needs Review This PR is ready for review. label Nov 20, 2025
simison
simison reviewed Nov 20, 2025
View reviewed changes
projects/js-packages/shared-extension-utils/src/block-icons.js
@@ -1,25 +1,10 @@
import colorStudio from '@automattic/color-studio';
Copy link
Member

@simison simison Nov 20, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also checked that @automattic/color-studio is still used by other features in this package so we can keep it in package.json.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@simison simison simison approved these changes

@keoshi keoshi Awaiting requested review from keoshi

@ilonagl ilonagl Awaiting requested review from ilonagl

Assignees

No one assigned

Labels

[Block] Blogroll [Block] Contact Form Form block (also see Contact Form label) [Block] Send a message Docs [Feature] Contact Form [JS Package] Shared Extension Utils [Package] Forms [Package] Paypal Payments [Plugin] Backup A plugin that allows users to save every change and get back online quickly with one-click restores. [Plugin] Boost A feature to speed up the site and improve performance. [Plugin] Classic Theme Helper Plugin [Plugin] CRM Issues about the Jetpack CRM plugin [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Paypal Payment Buttons [Plugin] Protect A plugin with features to protect a site: brute force protection, security scanning, and a WAF. [Plugin] Search A plugin to add an instant search modal to your site to help visitors find content faster. [Plugin] Social Issues about the Jetpack Social plugin [Plugin] Starter Plugin [Plugin] VideoPress A standalone plugin to add high-quality VideoPress videos to your site. [Plugin] Wpcomsh RNA [Tests] Includes Tests [Type] Bug When a feature is broken and / or not performing as intended

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@enejb @simison