Phan: Address issues discovered while testing against old WooCommerce stubs #46003

tbradsha · 2025-11-19T18:46:44Z

Closes MONOREP-234

In preparation to running static analysis against old Woo 7.0 stubs, this PR addresses some existing issues. In most cases we just add Phan suppressions (see phan/phan#1204). However, Sync had two real compatibility fixes:

9339cac: we referenced some class constant that might not be present; I've changed those instances to use the relevant strings
4bcb8d6: we called a method that may not always exist; I've added a check

Proposed changes:

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

CI should be happy here, but also Phan should run against old Woo stubs with no errors:

composer require --dev "php-stubs/woocommerce-stubs:7.0"
pnpm jetpack phan --all

github-actions · 2025-11-19T18:47:49Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (Jetpack or WordPress.com Site Helper), and enable the fix/phan/issues_in_old_woo branch.
To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack fix/phan/issues_in_old_woo

bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/phan/issues_in_old_woo

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-11-19T18:47:58Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
You can use GitHub's Reviewers functionality to request a review.
When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

Wpcomsh plugin:

Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2)

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

jp-launch-control · 2025-11-19T19:01:07Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/woocommerce-analytics/src/class-woo-analytics-trait.php	0/268 (0.00%)	0.00%	1 ❤️‍🩹

Full summary · PHP report · JS report

coder-karen

I would say the Sync package changes look fine, however it'd be good for Ventures to confirm that too as the relevant code adder (I see they're included as reviewers).

anomiex

Looks reasonable from a monorepo perspective. Up to Ventures or whoever about the constant thing.

louwie17 · 2025-11-20T08:20:19Z

projects/packages/sync/src/modules/class-woocommerce-products.php

 	private function get_product_cogs_data( $ids, $order = '' ) {
-		$is_cogs_enabled = class_exists( '\Automattic\WooCommerce\Utilities\FeaturesUtil' ) && \Automattic\WooCommerce\Utilities\FeaturesUtil::feature_is_enabled( 'cost_of_goods_sold' );
+		// @phan-suppress-current-line UnusedPluginSuppression @phan-suppress-next-line PhanUndeclaredClassReference, PhanUndeclaredClassMethod -- we're checking for the class and method before using them. See also: https://github.com/phan/phan/issues/1204
+		$is_cogs_enabled = class_exists( '\Automattic\WooCommerce\Utilities\FeaturesUtil' ) && method_exists( '\Automattic\WooCommerce\Utilities\FeaturesUtil', 'feature_is_enabled' ) && \Automattic\WooCommerce\Utilities\FeaturesUtil::feature_is_enabled( 'cost_of_goods_sold' );


The extra method_exists check seems unnecessary here as the feature_is_enabled was added since the creation of the FeaturesUtil class: https://github.com/woocommerce/woocommerce/pull/34727/files#diff-f5ea913d075d5ad173fcb2099d072ce0bf286922e41a3131442ab99c6ae58263

louwie17 · 2025-11-20T08:21:11Z

projects/packages/sync/src/modules/class-woocommerce-products.php

+				$product_type = 'variation';
 			} elseif ( 'product' === $post_type ) {
-				$product_type = $product_types[ $post->ID ] ?? ProductType::SIMPLE;
+				$product_type = $product_types[ $post->ID ] ?? 'simple';


This seems fine! I guess we haven't run into any issues here yet, because sync runs on newer stores? or maybe sync has a different plugin requirement?

tbradsha added 6 commits November 19, 2025 10:02

Use strings instead of class properties

9339cac

Add check for method and suppress Phan

4bcb8d6

Suppress Phan

7524f8b

Add changelogs

87f8280

Suppress Phan

f2d4f78

Suppress suppression errors

998eb13

tbradsha requested review from a team November 19, 2025 18:46

tbradsha self-assigned this Nov 19, 2025

tbradsha added [Status] Needs Review This PR is ready for review. [Type] Janitorial labels Nov 19, 2025

github-actions bot added [Feature] WooCommerce Analytics [Package] Sync [Package] WooCommerce Analytics Enhanced analytics for WooCommerce users [Plugin] Wpcomsh labels Nov 19, 2025

Move Phan suppression to correct place

de11cf8

coder-karen reviewed Nov 19, 2025

View reviewed changes

anomiex reviewed Nov 19, 2025

View reviewed changes

louwie17 reviewed Nov 20, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Phan: Address issues discovered while testing against old WooCommerce stubs #46003

Phan: Address issues discovered while testing against old WooCommerce stubs #46003

tbradsha commented Nov 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 19, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 19, 2025 •

edited

Loading

Uh oh!

jp-launch-control bot commented Nov 19, 2025 •

edited

Loading

Uh oh!

coder-karen left a comment

Uh oh!

anomiex left a comment

Uh oh!

louwie17 Nov 20, 2025

Uh oh!

louwie17 Nov 20, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Phan: Address issues discovered while testing against old WooCommerce stubs #46003

Are you sure you want to change the base?

Phan: Address issues discovered while testing against old WooCommerce stubs #46003

Conversation

tbradsha commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Uh oh!

github-actions bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jp-launch-control bot commented Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Code Coverage Summary

Uh oh!

coder-karen left a comment

Choose a reason for hiding this comment

Uh oh!

anomiex left a comment

Choose a reason for hiding this comment

Uh oh!

louwie17 Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

louwie17 Nov 20, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

tbradsha commented Nov 19, 2025 •

edited

Loading

github-actions bot commented Nov 19, 2025 •

edited

Loading

github-actions bot commented Nov 19, 2025 •

edited

Loading

jp-launch-control bot commented Nov 19, 2025 •

edited

Loading