Skip to content

I18n: images with English content #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
pocketcasts opened this issue Jul 11, 2022 · 4 comments · May be fixed by #2967
Open

I18n: images with English content #7

pocketcasts opened this issue Jul 11, 2022 · 4 comments · May be fixed by #2967
Assignees
@teaseaque
Labels
good first issue Good for newcomers i18n Issues related to Internationalization

Comments

@pocketcasts
Copy link
Contributor

We have images with hardcoded text on it.

How To Upload View

Found in: /podcasts/Files.xcassets

These images are separated out by theme. A couple of possible options are:

  1. Opt to not translate
  2. Recreate UI approximations in code
  3. Translate a single theme and opt to only use that theme
  4. Translate all themes for all languages

The preferable approach is (2).
@pocketcasts pocketcasts added good first issue Good for newcomers i18n Issues related to Internationalization labels Jul 11, 2022
@teaseaque
Copy link

Hey, could you please assign this issue to me? I've forked the repo and worked on a fix in branch replaced-how-to-upload-images-with-swiftui-views

@teaseaque
Copy link

@leandroalonso @SergioEstevao @bjtitus can you please help confirm if I can submit a PR to fix this issue as an external contributor? My changes account for included languages and themes, do you recommend any other edits?

Image

@bjtitus
Copy link
Contributor

bjtitus commented Apr 11, 2025 •
edited
Loading

@teaseaque Absolutely! I'll assign the issue to you. Feel free to submit a PR whenever you have changes. I think we need to create our own copy of your PR to get CI running but we should be able to keep the commits with you as author.

@teaseaque teaseaque linked a pull request Apr 12, 2025 that will close this issue
Open
3 tasks
@teaseaque
Copy link

@bjtitus That is great, thank you! Just submitted PR #2967 and signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@teaseaque teaseaque

Labels
good first issue Good for newcomers i18n Issues related to Internationalization
Projects
None yet
Milestone
No milestone
3 participants
@bjtitus @teaseaque @pocketcasts