-
Notifications
You must be signed in to change notification settings - Fork 143
GRDB: add write
and read
methods
#3040
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This way we can retrieve that differently on GRDB avoiding the crash that was happening
var startingSchemaVersion: Int32 = 0 | ||
|
||
queue.inDatabase { db in | ||
queue.write { db in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This call was split in two in one of the GRDB PRs as explained here.
This method is back to being a single block, which is what it should be. I had to add a method so that the crash that was happening before doesn't happen anymore.
With this change we're back at how it was before + working correctly with GRDB.
Non related to the changes above but noticed this quotes issues when testing this PR on the
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working correctly.
Installed from scratch, smoke test it and them changed the FF back and ran again.
All good!
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
About the Sentry error, this code hasn't even make to TestFlight yet. |
To unlock the power of concurrent reads, we need to use GRDB
write
andread
methods. This is a first step in this direction.Since there are many places that this needs to be changed, I'll raise one PR per data manager — this makes it easier to be reviewed.
To test
grdb
inFeatureFlag.swift
tofalse
Checklist
CHANGELOG.md
if necessary.