-
Notifications
You must be signed in to change notification settings - Fork 72
Add Filter to Disable WooPay for Improved Compatibility #10468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
@leonardola I'm not sure if I implemented the filter correctly. When I use the filter in the Storefront theme, I still see 'Payments' in the main admin navigation menu. Before spending more time on testing, I wanted to check in with you first to see if you have any insights or suggestions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this issue @BurakParsAydin I left a comment about WooPay getting disabled even when nothing is hooking to the disable_woopay
filter
@leonardola Thank you for your review. I’ve updated it according to your request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing the flagged issues. The changes look good to me now.
@leonardola Just checking if there’s any further action required on my end for this PR to be merged. |
@BurakParsAydin there isn't anything left. Just the E2E tests are failing but it seems unrelated to your changes. So let's merge it |
Fixes #9938
Changes proposed in this Pull Request
Added New Filter: Introduced the
disable_woopay
filter, allowing developers to conditionally disable WooPay, enhancing compatibility with custom themes and plugins.Testing instructions
npm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.