Cover letter for fraudulent reason #10823
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…he-evidence-form
rtio
changed the base branch from
develop
to
woopmnt-5025-add-logic-to-save-for-later
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: +1.79 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
rtio
changed the title
dmvrtx
reviewed
Jun 5, 2025
Comment on lines
+281
to
+284
| ) } #${ caseNumber } ${ __( | ||
| 'for transaction', | ||
| 'woocommerce-payments' | ||
| ) } #${ transactionId } ${ __( |
There was a problem hiding this comment.
It might not be an issue, but case number and transaction ID are both strings for Stripe, and adding a # in front of those creates a strange-looking text:
There was a problem hiding this comment.
@dmvrtx this comes from the template in Figma. You might want to comment there?
There was a problem hiding this comment.
Thanks, I left the comment there.
dmvrtx
reviewed
Jun 5, 2025
dmvrtx
reviewed
Jun 5, 2025
There was a problem hiding this comment.
I don't have enough experience to talk about the JS code. I ran through the flow though and noticed, that if I upload a piece of evidence, it will be included in the cover letter.
However, if I go back and remove the uploaded evidence, it remains listed in the cover letter. I didn't modify the cover letter in any sense, so I expected the content to be regenerated.
Update: I noticed that if I reload the page, the attachment comes back, so I guess it has to do something with an incomplete flow when removing it.
it should be, I tried debugging this, but could not find yet the solution. I'm thinking about opening a ticket to investigate further
I've fixed this issue and another one I've found b13e99d |
…rm' into woopmnt-5025-add-logic-to-save-for-later
…5028-cover-letter-fraudulent
Base automatically changed from
woopmnt-5025-add-logic-to-save-for-later
to
develop
June 6, 2025 15:28
…omattic/woocommerce-payments into woopmnt-5028-cover-letter-fraudulent
|
@dmvrtx just created an issue for the cover letter state - https://linear.app/a8c/issue/WOOPMNT-5039/cover-letter-state-is-not-being-updated-after-a-file-is-addedchanged |
dmvrtx
approved these changes
Jun 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See WOOPMNT-5028
Changes proposed in this Pull Request
waiting for: #10821
Add the logic for the cover letter
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge