-
Notifications
You must be signed in to change notification settings - Fork 72
update: deactivation survey to use unbundled WP components #10902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
Size Change: +17 B (0%) Total Size: 1.23 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code looks good but I could not make the survey screen to appear. approving it since I could not make the screen to appear in develop
as well. I sent a DM with the details.
Fixes WOOPMNT-5125
Changes proposed in this Pull Request
Ensuring that the "deactivation survey" component uses the components from the WP installation, rather than the
@wordpress/components
bundled with the plugin's codebaseTesting instructions
wp-admin
> Plugins > Installed Pluginsnpm run changelog
to add a changelog file, choosepatch
to leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge