Newsletter launchpad - fix bug with subscribers task not being checked off when it should.

[Addison-Stavlo]

Related to # https://github.com/Automattic/loop/issues/652

Proposed Changes

• Marks the submit function as async and calls await on the completion dispatch prior to navigating back to launchpad to avoid the race condition.

Why are these changes being made?

• poor user experience, task isn't looking like its checked off when it should be.

Testing Instructions

• go through /setup/newsletter/newsletterSetup
• Select to import a newsletter (as opposed to create free or paid)
• It can sometimes be difficult to repro the bug, turning off autoproxy helped me for whatever reason.
• add a subscriber and submit the task
• the launchpad should load with the task checked off.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-141532

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-141532&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-141532&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~7 bytes added 📈 [gzipped])

name             parsed_size           gzip_size
newsletter-flow        +15 B  (+0.1%)       +7 B  (+0.2%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• help-center

To test WordPress.com changes, run install-plugin.sh $pluginSlug fix/newsletter-subscribers-launchpad-task-incomplete on your sandbox.

[allilevine]

I was able to repro the issue (thanks for the proxy tip!).

Without these changes, after adding a subscriber:

With these changes, after adding a subscriber: