Pricing Grid: Split SFTP/SSH and Git into separate features

[sdnunca]

Related to 3688-gh-Automattic/martech

Proposed Changes

Splits the FEATURE_DEV_TOOLS feature into 2 lines/2 separate features: FEATURE_DEV_TOOLS_SSH, FEATURE_DEV_TOOLS_GIT

Why are these changes being made?

Part of an effort to address bugs and inconsistencies in the pricing grids.

Testing Instructions

• Go to /setup/onboarding/plans
• Confirm that the 2 features are shown separately in the pricing grid:

• Open the Comparison table

• Confirm the 2 features are shown separately.

Note: I've kept the same description for both features as it still matches them both.

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-141701

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-141701&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-141701&env=a8c-for-agencies

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~132 bytes added 📈 [gzipped])

name                   parsed_size           gzip_size
entry-reauth-required       +455 B  (+0.0%)     +132 B  (+0.0%)
entry-main                  +455 B  (+0.0%)     +132 B  (+0.0%)
entry-login                 +455 B  (+0.0%)     +132 B  (+0.0%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~132 bytes added 📈 [gzipped])

name                        parsed_size           gzip_size
site-setup-flow                  +455 B  (+0.2%)     +132 B  (+0.2%)
onboarding-flow                  +455 B  (+0.2%)     +132 B  (+0.2%)
new-hosted-site-flow             +455 B  (+0.3%)     +132 B  (+0.3%)
hundred-year-plan                +455 B  (+0.2%)     +132 B  (+0.3%)
hundred-year-domain              +455 B  (+0.2%)     +132 B  (+0.2%)
connect-domain                   +455 B  (+0.2%)     +132 B  (+0.3%)
async-step-use-my-domain         +455 B  (+0.1%)     +132 B  (+0.1%)
async-step-unified-plans         +455 B  (+0.0%)     +132 B  (+0.1%)
async-step-unified-domains       +455 B  (+0.0%)     +132 B  (+0.0%)
copy-site-flow                    +60 B  (+0.1%)      +26 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~132 bytes added 📈 [gzipped])

name                                       parsed_size           gzip_size
async-load-automattic-help-center-stepper       +455 B  (+0.0%)     +132 B  (+0.0%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[Copilot]

Pull Request Overview

This PR splits the unified dev-tools feature into two distinct features—one for SSH (SFTP/SSH) and one for Git. The changes update tests, component feature mappings, and constant definitions to reflect the two new features.

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
packages/calypso-products/test/get-feature-difference.ts	Updates test imports and expected diff to use FEATURE_DEV_TOOLS_SSH and FEATURE_DEV_TOOLS_GIT.
packages/calypso-products/src/plans-list.tsx	Replaces instances of FEATURE_DEV_TOOLS with the two separate features in plan arrays.
packages/calypso-products/src/features-list.tsx	Splits the feature mapping into two entries for SSH and Git and updates the import list.
packages/calypso-products/src/feature-group-plan-map.ts	Updates the list of developer tools to the new separate features.
packages/calypso-products/src/constants/features.ts	Replaces FEATURE_DEV_TOOLS with FEATURE_DEV_TOOLS_SSH and FEATURE_DEV_TOOLS_GIT.

Comments suppressed due to low confidence (1)

packages/calypso-products/src/features-list.tsx:194

• [nitpick] The ordering of the new feature imports in this file differs from the order used elsewhere (SSH then GIT). Consider reordering them to list FEATURE_DEV_TOOLS_SSH before FEATURE_DEV_TOOLS_GIT for clarity and consistency.

FEATURE_DEV_TOOLS_GIT,

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• happy-blocks
• help-center
• notifications
• odyssey-stats
• wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/pricing-grid-developer-features on your sandbox.

[a8ci18n]

This Pull Request is now available for translation here: https://translate.wordpress.com/deliverables/17420822

Some locales (Hebrew, Japanese) have been temporarily machine-translated due to translator availability. All other translations are usually ready within a few days. Untranslated and machine-translated strings will be sent for translation next Monday and are expected to be completed by the following Friday.

Thank you @sdnunca for including a screenshot in the description! This is really helpful for our translators.

[claudiucelfilip]

Thanks for picking this up!
Works well but I have a couple notes:

• there's some tooltip copy for the separated items in this speadsheet: 379ef-pb

• I'm not sure we want to separate the item in the top plan grid as well (source request p5uIfZ-gt2-p2): @peterschimke can you confirm?

[peterschimke]

I'm not sure we want to separate the item in the top plan grid as well

@claudiucelfilip thanks for checking. In the main pricing grid, the developer tools should be listed together as one item. But in the longer 'Compare plans' grid 'SFTP/SSH, WP-CLI' and 'Git commands, and GitHub Deployments' are separate items.