Skip to content

New hosted site: Add selected add-ons to the cart#102859

Merged
zaguiini merged 1 commit intotrunkfrom
dotcom-10648-new-hosted-site-flow-doesnt-add-storage-add-ons-to-the-cart
Apr 25, 2025
Merged

New hosted site: Add selected add-ons to the cart#102859
zaguiini merged 1 commit intotrunkfrom
dotcom-10648-new-hosted-site-flow-doesnt-add-storage-add-ons-to-the-cart

Conversation

@zaguiini
Copy link
Copy Markdown
Contributor

Fixes DOTCOM-10648.

Proposed Changes

Fixes a bug where the add-on wasn't being added to the cart within /setup/new-hosted-site.

Testing Instructions

Enter /setup/new-hosted-site and verify that picking a plan with a storage add-on lists reflects at checkout.

@zaguiini zaguiini requested a review from a team April 24, 2025 18:57
@zaguiini zaguiini self-assigned this Apr 24, 2025
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 24, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 24, 2025

@matticbot
Copy link
Copy Markdown
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~31 bytes added 📈 [gzipped])

Details
name                  parsed_size           gzip_size
new-hosted-site-flow        +48 B  (+0.0%)      +31 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@matticbot
Copy link
Copy Markdown
Contributor

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

  • blaze-dashboard
  • notifications
  • wpcom-block-editor

To test WordPress.com changes, run install-plugin.sh $pluginSlug dotcom-10648-new-hosted-site-flow-doesnt-add-storage-add-ons-to-the-cart on your sandbox.

Copy link
Copy Markdown
Contributor

@paulopmt1 paulopmt1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working as expected, thanks for fixing it!
Can we also add a test to ensure this won't happen again?

image

@zaguiini
Copy link
Copy Markdown
Contributor Author

Of course, @paulopmt1. I'll add it as a follow-up.

@zaguiini zaguiini merged commit 1e88d7a into trunk Apr 25, 2025
17 checks passed
@zaguiini zaguiini deleted the dotcom-10648-new-hosted-site-flow-doesnt-add-storage-add-ons-to-the-cart branch April 25, 2025 16:03
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants