Skip to content

A4A: Display the nested sidebar preview on narrow screens #102867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

yashwin
Copy link
Contributor

@yashwin yashwin commented Apr 25, 2025

Resolves https://github.com/Automattic/automattic-for-agencies-dev/issues/1605

Proposed Changes

This PR updates the A4ASidebar component to set the layout focus to "preview" when a nested menu is opened on narrow devices. The sidebar is hidden on narrow devices(<660px). This is because, on a narrow view, we want to display the sidebar to navigate to all available pages rather than showing the default page of the nested sidebar directly.

Why are these changes being made?

  • On a narrow view, we want to display the sidebar to navigate to all available pages rather than showing the default page of the nested sidebar directly.

Testing Instructions

  • Open the A4A live link
  • Visit all the pages: Overview, Sites, Marketplace and the rest > Verify everything works as expected including the nested menu items
  • Switch to any view < 660px using the dev tool > Verify the non-nested menu is loading the page directly(Overview, Team etc) and nested menu displays the sidebar
Screenshot 2025-04-25 at 12 17 31 PM

Pre-merge Checklist

  • Has the general commit checklist been followed? (PCYsg-hS-p2)
  • Have you written new tests for your changes?
  • Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
  • Have you checked for TypeScript, React or other console errors?
  • Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
  • Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
    • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
  • For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

@yashwin yashwin requested review from jeffgolenski and a team April 25, 2025 06:47
@yashwin yashwin self-assigned this Apr 25, 2025
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Apr 25, 2025
@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~52 bytes added 📈 [gzipped])

name                                parsed_size           gzip_size
a8c-for-agencies-woopayments             +169 B  (+0.0%)      +52 B  (+0.0%)
a8c-for-agencies-team                    +169 B  (+0.0%)      +52 B  (+0.0%)
a8c-for-agencies-sites                   +169 B  (+0.0%)      +52 B  (+0.0%)
a8c-for-agencies-settings                +169 B  (+0.1%)      +52 B  (+0.1%)
a8c-for-agencies-referrals               +169 B  (+0.0%)      +52 B  (+0.0%)
a8c-for-agencies-purchases               +169 B  (+0.0%)      +52 B  (+0.0%)
a8c-for-agencies-plugins                 +169 B  (+0.0%)      +52 B  (+0.0%)
a8c-for-agencies-partner-directory       +169 B  (+0.0%)      +52 B  (+0.0%)
a8c-for-agencies-overview                +169 B  (+0.0%)      +52 B  (+0.0%)
a8c-for-agencies-migrations              +169 B  (+0.0%)      +52 B  (+0.0%)
a8c-for-agencies-marketplace             +169 B  (+0.0%)      +52 B  (+0.0%)
a8c-for-agencies-feedback                +169 B  (+0.1%)      +52 B  (+0.1%)
a8c-for-agencies-client                  +169 B  (+0.0%)      +52 B  (+0.0%)
a8c-for-agencies-agency-tier             +169 B  (+0.1%)      +52 B  (+0.1%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

@yashwin yashwin changed the title A4A: Open the nested sidebar preview on narrow screens A4A: Display the nested sidebar preview on narrow screens Apr 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A8c Agencies [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants