Warning: unstable_flushDiscreteUpdates

[iongion]

For react deps:

    "react": "^16.9.0",
    "react-block-ui": "^1.3.1",
    "react-color": "^2.17.3",
    "react-dom": "^16.9.0",

There is now this warning showing up

Warning: unstable_flushDiscreteUpdates: Cannot flush updates when React is already rendering.
    in BlockUi

[TheSharpieOne]

Looks like it has something to do with the focus calls based on this code comment: https://github.com/facebook/react/blob/c80678c7606b1895573c23182bfb9a418e2ad31e/packages/react-reconciler/src/ReactFiberWorkLoop.js#L605-L607

I'm not sure how to address this.

[goxr3plus]

What is happening with this issue guys ?

[GoPro16]

What is happening with this issue guys ?

No one has picked up this issue if you want to take it. Just a warning so not a top concern.

[goxr3plus]

We are full of warnings bro

[vitaly-redkin]

Looks like it has something to do with the focus calls based on this code comment: https://github.com/facebook/react/blob/c80678c7606b1895573c23182bfb9a418e2ad31e/packages/react-reconciler/src/ReactFiberWorkLoop.js#L605-L607

I'm not sure how to address this.

In my private fork I have replaced
if (typeof this.focused.focus === 'function') { this.focused.focus(); }
with
if (typeof this.focused.focus === 'function') { const focusedControl = this.focused; window.setInterval(() => { focusedControl.focus(); }, 100); }

A hack, no doubt, but seems to be working so far,,,

[goxr3plus]

@vitaly-redkin Can you please make a pull request for that ? :) Thank you

[vitaly-redkin]

@vitaly-redkin Can you please make a pull request for that ? :) Thank you

I probably can but what is the point? The PR to use UNSAFE_ methods for componentWillXXX (#46) is not merged - and probably will not.

My local version has both UNSAFE_ and "wrap this.focusedControl.focus() into setTimeout()" changes so it will break the same tests as the previous PR did. So it will not be merged, etc.

Personally I made my change to serve as a temporary solution and waiting for the hooks rewrite...

[goxr3plus]

Yes i understand . How about you pull reuqest only the wrap this.focusedControl.focus() into setTimeout() , i am having that annoying errors in production code .

[vitaly-redkin]

Will do but a bit later - really tied up right now...

[goxr3plus]

@vitaly-redkin No prob fill free to drop a pull request when you have time :)

[Adam-Asatryan]

any updates here ?

[goxr3plus]

@Adam-Asatryan Vitaly got married i think.

[mehmetkasalak]

Will there be any progress?