Preserve groups collapsed state #122
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
|
I was testing this with more clips and it's not performing great. Especially, it does a lot of work for every collection Reset which is relatively common and cheap in general. I will try to see if there is a better solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the same PR as AvaloniaUI/Avalonia#18331
What does the pull request do?
DataGrid has a Grouping behavior. It has a major flaw: when the collection is Reset or just when the DataGrid control is removed and re-attached to the visual tree, it forgets the collapsed state of groups.
What is the current behavior?
Open the Control catalog DataGrid page.
On the Grouping tab collapse some groups.
Switch tabs back and forth.
Groups are expanded again.
What is the updated/expected behavior with this PR?
The state is saved and restored
How was the solution implemented (if it's not obvious)?
I tried to mimick the selection state cache on the same spot.
Breaking changes
none