Skip to content

stop assigning roles to non-user principal #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2024
Merged

stop assigning roles to non-user principal #18

merged 1 commit into from
Aug 5, 2024

Conversation

hund030
Copy link
Contributor

@hund030 hund030 commented Jul 23, 2024

Purpose

Fix the azd up error in #17

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
  • Login azd with service principal
  • Run azd up

What to Check

Running azd up command should succeed.

Other Information

anfibiacreativa
anfibiacreativa approved these changes Aug 5, 2024
View reviewed changes
Copy link
Member

@anfibiacreativa anfibiacreativa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anfibiacreativa anfibiacreativa merged commit 0f5aaef into Azure-Samples:main Aug 5, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anfibiacreativa anfibiacreativa anfibiacreativa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hund030 @anfibiacreativa