Add sustained throttling auto-suspension for SummaryRules#990
Open
Add sustained throttling auto-suspension for SummaryRules#990
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an auto-suspension feature for SummaryRules to protect ADX from sustained throttling. When a SummaryRule experiences throttling errors for an extended period (at least max(3 * spec.interval, 15m)), the ADX Exporter automatically suspends execution and surfaces a condition requiring manual operator intervention to resume.
Key changes:
- Adds suspension detection logic that monitors throttling failures and automatically suspends rules exceeding the threshold
- Updates reconciliation flow to skip submissions, backfill, and retries when a rule is suspended while still tracking inflight operations
- Adds comprehensive test coverage for suspension scenarios including skip logic and threshold calculations
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| docs/crds.md | Documents the auto-suspension guardrail feature with details on trigger conditions and operator intervention requirements |
| adxexporter/summaryrule.go | Implements suspension evaluation, throttle detection, and updates reconciliation flow to respect suspension state |
| adxexporter/summaryrule_test.go | Adds five new tests covering suspension scenarios: skip submission, idle backlog, inflight tracking, retry skipping, and threshold evaluation |
Comments suppressed due to low confidence (1)
adxexporter/summaryrule.go:1
- [nitpick] The logic for handling backlog operations when suspended is split across two conditionals (lines 553-555 and 556-559). This could be simplified by combining into a single conditional:
if op.OperationId == \"\" { if !suspended { r.processBacklogOperation(ctx, rule, op) } return }.
package adxexporter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing