Skip to content

Conversation

@fpolisupsi
Copy link

Typo in the schema property, in the final output.
cli output sample:
{
"id": "[cut]",
"isAvailiable": true,
"name": "[cut]",
"type": "Microsoft.NotificationHubs/namespaces/checkNamespaceAvailability"
}


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Typo in the schema property, in the final output.
cli output sample:
{
  "id": "[cut]",
  "isAvailiable": true,
  "name": "[cut]",
  "type": "Microsoft.NotificationHubs/namespaces/checkNamespaceAvailability"
}
Copilot AI review requested due to automatic review settings October 19, 2025 00:34
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @fpolisupsi,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Oct 19, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a spelling error in the availability schema property name, correcting "isAvailiable" to "isAvailable" in both the Python property name and its serialized JSON representation.

Key Changes

  • Corrected misspelled property name from is_availiable to is_available
  • Updated corresponding serialized name from "isAvailiable" to "isAvailable"

@microsoft-github-policy-service microsoft-github-policy-service bot added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Oct 19, 2025
@github-actions
Copy link

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

Hi @fpolisupsi

Release Suggestions

Module: notification-hub

  • Please log updates into to src/notification-hub/HISTORY.rst
  • Update VERSION to 2.0.0b2 in src/notification-hub/setup.py

Notes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants