Skip to content

Conversation

@JackStromberg
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

  • az aks applicationloadbalancer enable: Enable Application Load Balancer add-on for an existing cluster.
  • az aks applicationloadbalancer disable: Disable Application Load Balancer add-on for an existing cluster.
  • az aks applicationloadbalancer update: Update Application Load Balancer add-on for an existing cluster.

General Guidelines

  • [yes] Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • [yes] Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • [yes] My extension version conforms to the Extension version schema

Copilot AI review requested due to automatic review settings November 4, 2025 08:05
@azure-client-tools-bot-prd
Copy link

Validation for Breaking Change Starting...

Thanks for your contribution!

@azure-client-tools-bot-prd
Copy link

Hi @JackStromberg,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 4, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Nov 4, 2025

Hi @JackStromberg

Release Suggestions

Module: aks-preview

  • Update VERSION to 19.0.0b11 in src/aks-preview/setup.py

Notes

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the Application Load Balancer (Application Gateway for Containers) addon to AKS clusters. The implementation follows the pattern established for other special addons like web app routing.

Key changes:

  • Adds new CLI commands az aks applicationloadbalancer enable/disable/update for managing the addon
  • Integrates the addon into existing addon management infrastructure (aks addon enable/disable)
  • Stores configuration in the cluster's ingress profile rather than the standard addon profile

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
managed_cluster_decorator.py Adds getter method for the parameter and methods to set up and update the application load balancer profile in the ingress profile
custom.py Implements the enable/disable/update commands and integrates with existing addon list/show/enable/disable functionality
commands.py Registers the new aks applicationloadbalancer command group with enable, disable, and update commands
addonconfiguration.py Adds handling for the applicationloadbalancer addon in the update_addons function
_help.py Adds documentation for the new commands and updates addon descriptions; fixes typo in app routing help
_consts.py Defines constants for the new addon name and adds it to the ADDONS dictionary and descriptions
HISTORY.rst Documents the new feature in the pending release notes

JackStromberg and others added 2 commits November 4, 2025 00:17
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please add a new scenario test case (may refer to existing examples from test_aks_commands.py) for the change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AKS Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants