Client Parity: CLI Refresh for Dynatrace API version 2024-04-24 #9389
Conversation
❌Azure CLI Extensions Breaking Change Test
|
|
Hi @arushiarora24, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
There was a problem hiding this comment.
Pull Request Overview
This pull request adds comprehensive test coverage for Dynatrace observability and monitored subscription commands, while making location, email, and version updates to existing tests.
- Adds new test files for
dynatrace observability monitoranddynatrace monitored-subscriptioncommand groups - Updates test locations from
eastus/eastustocentraluseuap/eastus2euap - Updates email addresses from
agarwalshiv@microsoft.comtoarushiarora@microsoft.com - Adds
timeimport and manual delay logic for backend stabilization - Updates minimum CLI core version requirement from
2.70.0to2.75.0
Reviewed Changes
Copilot reviewed 49 out of 51 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| test_dynatrace_observability_monitor.py | New test file for observability monitor commands with list and manage-agent-installation operations |
| test_dynatrace_monitored_subscription.py | New test file for monitored-subscription lifecycle (create, list, show, delete) |
| test_dynatrace.py | Updated locations, email addresses, added stabilization delay, and SSO config update command |
| test_observability_monitor_commands.yaml | Recording file for new observability monitor test scenarios |
| test_monitored_subscription_commands.yaml | Recording file for new monitored subscription test scenarios |
| test_dynatrace_saas_resource.yaml | Updated API version and response format for SaaS resource details |
| azext_metadata.json | Bumped minimum CLI version from 2.70.0 to 2.75.0 |
| aaz files | Added new command group infrastructure for observability monitor and SSO config update |
| self.kwargs.update({ | ||
| 'monitor': self.create_random_name('monitor', 15), | ||
| 'sub_id': self.get_subscription_id(), | ||
| 'updated_status': 'InProgress', |
There was a problem hiding this comment.
The variable 'updated_status' is defined but never used in this test. Remove this unused variable to keep the test code clean.
| 'subscription_id': '/SUBSCRIPTIONS/b16e4b4e-2ed8-4f32-bac1-0e3eb56bef5c', # normalized variable name | ||
| 'subs_id': '/subscriptions/b16e4b4e-2ed8-4f32-bac1-0e3eb56bef5c', | ||
| 'updated_status': 'InProgress' |
There was a problem hiding this comment.
Two variables ('subs_id' and 'updated_status') are defined but never used in the test. Additionally, 'subscription_id' and 'subs_id' contain the same value with different casing, creating redundancy. Remove the unused variables.
| # Wait for monitor provisioning to complete before performing update | ||
| self.cmd('dynatrace monitor wait -g {rg} -n {monitor} --created') | ||
| # Add a manual delay for backend service stabilization | ||
| time.sleep(60) | ||
| # Use standard tag syntax key=value to avoid shorthand parsing issues |
There was a problem hiding this comment.
A hard-coded 60-second sleep is added for 'backend service stabilization', but the actual update command referenced in the comment on line 49 has been removed (lines 45-50 replace the previous update command). This creates dead code and misleading comments. Either restore the update command or remove the stabilization delay and its comments.
… as a result of PR workflow runs
@microsoft-github-policy-service agree company="Microsoft" |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
|
[Release] Update index.json for extension [ dynatrace-2.0.0 ] : https://dev.azure.com/msazure/One/_build/results?buildId=143445874&view=results |
5 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.###Testing details:
