Skip to content

Conversation

@Greedygre
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copilot AI review requested due to automatic review settings November 5, 2025 10:19
@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Nov 5, 2025

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 5, 2025

Thank you for your contribution! We will review the pull request and get back to you soon.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR.

Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions).
After that please run the following commands to enable git hooks:

pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Container App extension's API version from 2025-02-02-preview to 2025-10-02-preview, aligning with the latest Azure Container Apps preview API. The changes include SDK enum updates for workflow kinds, renaming of provisioning state classes, and updated test recordings to reflect current test infrastructure.

Key Changes

  • Updated API version constant to 2025-10-02-preview
  • Added new enum types (WorkflowKind, DaprComponentProvisioningState) and removed deprecated ones
  • Added FUNCTIONAPP kind support to the Kind enum
  • Updated test recordings with current cluster versions and timestamps

Reviewed Changes

Copilot reviewed 4 out of 165 changed files in this pull request and generated 1 comment.

File Description
_clients.py Updates the preview API version constant from 2025-02-02-preview to 2025-10-02-preview
_sdk_enums.py Refactors enum classes, including renaming provisioning states, adding WorkflowKind and functionapp support, and documentation cleanup
test_containerapp_up_on_connected_env.py Comments out extension installation commands for connectedk8s and k8s-extension
test_containerapp_arc_setup_core_dns_e2e.yaml Updates test recording data with newer cluster versions and timestamps

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

CodeGen Tools Feedback Collection

Thank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey

@github-actions
Copy link

github-actions bot commented Nov 5, 2025

Hi @Greedygre

Release Suggestions

Module: containerapp

  • Update VERSION to 1.2.0b6 in src/containerapp/setup.py

Notes

@yonzhan
Copy link
Collaborator

yonzhan commented Nov 6, 2025

Please fix CI issues

# Wait for extensions to be installed
# We mock time.sleep in azure-sdk-tools, that's why we need to use sleep here.
sleep(120)
# cmd = ['azdev', 'extension', 'add', 'connectedk8s']
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not remove the code if not used

@yanzhudd yanzhudd merged commit 59814d0 into Azure:main Nov 13, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants