-
Notifications
You must be signed in to change notification settings - Fork 1.5k
[Containerapp] Update api-version to 2025-10-02-preview #9392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Containerapp] Update api-version to 2025-10-02-preview #9392
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi @Greedygre, |
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
|
The git hooks are available for azure-cli and azure-cli-extensions repos. They could help you run required checks before creating the PR. Please sync the latest code with latest dev branch (for azure-cli) or main branch (for azure-cli-extensions). pip install azdev --upgrade
azdev setup -c <your azure-cli repo path> -r <your azure-cli-extensions repo path>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Container App extension's API version from 2025-02-02-preview to 2025-10-02-preview, aligning with the latest Azure Container Apps preview API. The changes include SDK enum updates for workflow kinds, renaming of provisioning state classes, and updated test recordings to reflect current test infrastructure.
Key Changes
- Updated API version constant to
2025-10-02-preview - Added new enum types (
WorkflowKind,DaprComponentProvisioningState) and removed deprecated ones - Added
FUNCTIONAPPkind support to theKindenum - Updated test recordings with current cluster versions and timestamps
Reviewed Changes
Copilot reviewed 4 out of 165 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
_clients.py |
Updates the preview API version constant from 2025-02-02-preview to 2025-10-02-preview |
_sdk_enums.py |
Refactors enum classes, including renaming provisioning states, adding WorkflowKind and functionapp support, and documentation cleanup |
test_containerapp_up_on_connected_env.py |
Comments out extension installation commands for connectedk8s and k8s-extension |
test_containerapp_arc_setup_core_dns_e2e.yaml |
Updates test recording data with newer cluster versions and timestamps |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
CodeGen Tools Feedback CollectionThank you for using our CodeGen tool. We value your feedback, and we would like to know how we can improve our product. Please take a few minutes to fill our codegen survey |
|
Hi @Greedygre Release SuggestionsModule: containerapp
Notes
|
|
Please fix CI issues |
| # Wait for extensions to be installed | ||
| # We mock time.sleep in azure-sdk-tools, that's why we need to use sleep here. | ||
| sleep(120) | ||
| # cmd = ['azdev', 'extension', 'add', 'connectedk8s'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not remove the code if not used
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.