Skip to content

Conversation

@dhawal-msft
Copy link
Contributor

@dhawal-msft dhawal-msft commented Sep 26, 2025

Things to consider before you submit the PR:

  • Are tests passing locally?
  • Are the files formatted correctly?
  • Did you add unit tests?
  • Did you test your change with either the sample apps that are included in the repository or with a blank app that uses your change?

Description

Test file update for some mock data to be added

Related PRs or issues

List related PRs and other issues.

Misc

Add what's missing, notes on what you tested, additional thoughts or questions.

@dhawal-msft dhawal-msft requested a review from Copilot September 26, 2025 10:20
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates test files to replace sensitive SharedAccessKey values with mock data for security purposes.

  • Replaces actual SharedAccessKey values with standardized mock keys in test files
  • Ensures sensitive credentials are not exposed in the codebase
  • Maintains consistent mock data format across all test files

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
MSNotificationHubTemplatesTests.m Updates SharedAccessKey to use mock value
MSNotificationHubTagsTests.m Updates SharedAccessKey to use mock value
MSInstallationManagerTests.m Updates SharedAccessKey to use mock value

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Member

@pranav-gupta-msft pranav-gupta-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirm that there are no other secrets.

@dhawal-msft
Copy link
Contributor Author

@microsoft-github-policy-service agree [company="{microsoft}"]

@dhawal-msft
Copy link
Contributor Author

@microsoft-github-policy-service agree company="microsoft"

@dhawal-msft dhawal-msft merged commit f9b3c88 into main Sep 26, 2025
1 of 6 checks passed
@dhawal-msft dhawal-msft deleted the issue/fix_tests/dhawsingh branch September 26, 2025 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants