Sync tools folder from main branch to generation branch (#25610)

Co-authored-by: azurepowershell <azurepowershell@ms.com>

Author: azure-powershell-bot

.azure-pipelines/code-gen.yml

@@ -21,7 +21,8 @@ jobs:
   pool: pool-windows-2019
   steps:
   - checkout: self
-  - template: util/get-github-pat-steps.yml
+    persistCredentials: true
+  - template: util/get-github-token-steps.yml
   - task: NodeTool@0
     displayName: Use Node 14.15.5
     inputs:

.azure-pipelines/live-test.yml

@@ -52,6 +52,7 @@ variables:
   ArtifactsName: LiveTestArtifacts
   DataLocation: $(Pipeline.Workspace)/$(ArtifactsName)
   SuppressAzurePowerShellBreakingChangeWarnings: true
+  Codeql.Enabled: false
 
 schedules:
 - cron: "0 19 * * *"

.azure-pipelines/util/analyze-steps.yml

@@ -5,7 +5,6 @@ parameters:
   IsGenerateBased: ''
 
 steps:
-- template: get-github-pat-steps.yml
 - template: download-build-steps.yml
   parameters:
     artifactName: build-${{ parameters.testFramework }}
@@ -50,7 +49,6 @@ steps:
     custom: msbuild
     arguments: 'build.proj /t:GenerateHelp /p:Configuration=${{ parameters.configuration }};PullRequestNumber=$(System.PullRequest.PullRequestNumber)'
   env:
-      OCTOKITPAT: $(GithubToken)
       PowerShellPlatform: ${{ parameters.powerShellPlatform }}
 
 - task: DotNetCoreCLI@2
@@ -60,7 +58,6 @@ steps:
     custom: msbuild
     arguments: 'build.proj /t:StaticAnalysis /p:Configuration=${{ parameters.configuration }};PullRequestNumber=$(System.PullRequest.PullRequestNumber)'
   env:
-      OCTOKITPAT: $(GithubToken)
       IsGenerateBased: ${{ parameters.IsGenerateBased }}
 
 - template: publish-artifacts-steps.yml

.azure-pipelines/util/build-steps.yml

@@ -4,7 +4,9 @@ parameters:
   powerShellPlatform: ''
 
 steps:
-- template: get-github-pat-steps.yml
+- checkout: self
+  persistCredentials: true
+- template: get-github-token-steps.yml
 - task: NodeTool@0
   condition: eq(variables.IsGenerateBased, true)
   displayName: Install Autorest

.azure-pipelines/util/get-github-token-steps.yml

@@ -0,0 +1,12 @@
+steps:
+- task: PowerShell@2
+  displayName: Get GitHub Token
+  inputs:
+    targetType: 'inline'
+    script: |
+      $httpConfigs = (git config --get-regexp "http" )
+      $authConfig = $httpConfigs | Where-Object {$_ -like "*AUTHORIZATION*"}
+      $token = ($authConfig -split ' ')[-1]
+      $ghToken = ([System.Text.Encoding]::ASCII.GetString([System.Convert]::FromBase64String($token)) -split ':')[1]
+      Write-Host "##vso[task.setvariable variable=GithubToken;issecret=true]$ghToken"
+

.azure-pipelines/util/test-steps.yml

@@ -6,7 +6,6 @@ parameters:
   powerShellPlatform: ''
 
 steps:
-- template: get-github-pat-steps.yml
 - template: download-build-steps.yml
   parameters:
     artifactName: build-${{ parameters.testFramework }}
@@ -31,7 +30,6 @@ steps:
     custom: msbuild
     arguments: 'build.proj /t:${{ parameters.testTarget }} /p:Configuration=${{ parameters.configuration }};TestFramework=${{ parameters.testFramework }};PullRequestNumber=$(System.PullRequest.PullRequestNumber)'
   env:
-    OCTOKITPAT: $(GithubToken)
     PowerShellPlatform: ${{ parameters.powerShellPlatform }}
   continueOnError: true
 

src/lib/netstandard2.0/Azure.Core.dll

@@ -22,7 +22,7 @@
     <PackageReference Include="Microsoft.CSharp" Version="4.7.0" />
   </ItemGroup>
   <ItemGroup>
-    <PackageReference Include="Azure.Core" Version="1.40.0"/>
+    <PackageReference Include="Azure.Core" Version="1.41.0"/>
   </ItemGroup>
   <ItemGroup Condition="'$(IsTestProject)' != 'true'">
     <PackageReference Include="Microsoft.ApplicationInsights" Version="2.18.0">

tools/Common.Netcore.Dependencies.targets

@@ -88,3 +88,6 @@
 "Az.Resources","Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.SetAzSubscriptionDeploymentStack","Set-AzSubscriptionDeploymentStack","1","8410","Parameter DenySettingsApplyToChildScopes of cmdlet Set-AzSubscriptionDeploymentStack does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
 "Az.Resources","Get-AzADOrganization","Get-AzADOrganization","2","8010","Get-AzADOrganization Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute.","Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue"
 "Az.Resources","Get-AzADOrganization","Get-AzADOrganization","2","8200","Get-AzADOrganization changes the confirm impact.  Please ensure that the change in ConfirmImpact is justified","Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact."
+"Az.Resources","Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.TestAzManagementGroupDeploymentStack","Test-AzManagementGroupDeploymentStack","1","8410","Parameter DenySettingsApplyToChildScopes of cmdlet Test-AzManagementGroupDeploymentStack does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
+"Az.Resources","Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.TestAzResourceGroupDeploymentStack","Test-AzResourceGroupDeploymentStack","1","8410","Parameter DenySettingsApplyToChildScopes of cmdlet Test-AzResourceGroupDeploymentStack does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."
+"Az.Resources","Microsoft.Azure.Commands.ResourceManager.Cmdlets.Implementation.TestAzSubscriptionDeploymentStack","Test-AzSubscriptionDeploymentStack","1","8410","Parameter DenySettingsApplyToChildScopes of cmdlet Test-AzSubscriptionDeploymentStack does not follow the enforced naming convention of using a singular noun for a parameter name.","Consider using a singular noun for the parameter name."

tools/StaticAnalysis/Exceptions/Az.Resources/SignatureIssues.csv

@@ -302,9 +302,11 @@ function Invoke-LiveTestScenario {
 
         do {
             try {
-                $prefs = @([psvariable]::new("ErrorActionPreference", "Stop"))
                 if ($snrRetryCount -eq $script:ScenarioMaxRetryCount) {
-                    $prefs += [psvariable]::new("DebugPreference", "Continue")
+                    $prefs = @([psvariable]::new("ErrorActionPreference", "Stop"), [psvariable]::new("DebugPreference", "Continue"))
+                }
+                else {
+                    $prefs = [psvariable]::new("ErrorActionPreference", "Stop")
                 }
 
                 $ScenarioScript.InvokeWithContext($null, $prefs, $snrResourceGroup)