network and help

Author: audunn

src/NetAppFiles/NetAppFiles/VolumeGroup/NewNetAppFilesVolumeGroup.cs

@@ -112,7 +112,7 @@ public class NewAzureRmNetAppFilesVolumeGroup : AzureNetAppFilesCmdletBase
             Mandatory = false,
             HelpMessage = "Application Type, default "+ DefaultApplicationType)]
         [ValidateNotNullOrEmpty]
-        [PSArgumentCompleter("SAP-HANA")]
+        [PSArgumentCompleter("SAP-HANA", "ORACLE")]
         [PSDefaultValue(Help = "Default \"SAP-HANA\"", Value = DefaultApplicationType)]
         public string ApplicationType { get; set; } = DefaultApplicationType;
 
@@ -271,6 +271,12 @@ public class NewAzureRmNetAppFilesVolumeGroup : AzureNetAppFilesCmdletBase
         [PSArgumentCompleter("Microsoft.NetApp", "Microsoft.KeyVault")]
         public string EncryptionKeySource { get; set; }
 
+        [Parameter(
+            Mandatory = false,
+            HelpMessage = "Basic network, or Standard features available to the volume (Basic, Standard).")]
+        [PSArgumentCompleter("Basic", "Standard")]
+        public string NetworkFeature { get; set; }
+
         [Parameter(
             Mandatory = false,
             HelpMessage = "The resource ID of private endpoint for KeyVault. It must reside in the same VNET as the volume. Only applicable if encryptionKeySource = 'Microsoft.KeyVault'")]
@@ -450,7 +456,8 @@ private VolumeGroupDetails CreateHostVolumeGroup(string name, string sid, string
                     ExportPolicy = volumeExportPolicy,
                     Zones = zoneList,
                     KeyVaultPrivateEndpointResourceId = this.KeyVaultPrivateEndpointResourceId,
-                    EncryptionKeySource = this.EncryptionKeySource
+                    EncryptionKeySource = this.EncryptionKeySource,
+                    NetworkFeatures = this.NetworkFeature
                 };
 
                 volumesInGroup.Add(dataVolume);
@@ -468,7 +475,8 @@ private VolumeGroupDetails CreateHostVolumeGroup(string name, string sid, string
                     ExportPolicy = volumeExportPolicy,
                     Zones = zoneList,
                     KeyVaultPrivateEndpointResourceId = this.KeyVaultPrivateEndpointResourceId,
-                    EncryptionKeySource = this.EncryptionKeySource
+                    EncryptionKeySource = this.EncryptionKeySource,
+                    NetworkFeatures = this.NetworkFeature
                 };
                 volumesInGroup.Add(logVolume);
                 //Shared, Log backup and Data backup only created for HostID==1.
@@ -489,7 +497,8 @@ private VolumeGroupDetails CreateHostVolumeGroup(string name, string sid, string
                         ExportPolicy = volumeExportPolicy,
                         Zones = zoneList,
                         KeyVaultPrivateEndpointResourceId = this.KeyVaultPrivateEndpointResourceId,
-                        EncryptionKeySource = this.EncryptionKeySource
+                        EncryptionKeySource = this.EncryptionKeySource,
+                        NetworkFeatures = this.NetworkFeature
                     };
                     if (this.Zone != null)
                     {
@@ -511,7 +520,8 @@ private VolumeGroupDetails CreateHostVolumeGroup(string name, string sid, string
                         ExportPolicy = volumeExportPolicy,
                         Zones = zoneList,
                         KeyVaultPrivateEndpointResourceId = this.KeyVaultPrivateEndpointResourceId,
-                        EncryptionKeySource = this.EncryptionKeySource
+                        EncryptionKeySource = this.EncryptionKeySource,
+                        NetworkFeatures = this.NetworkFeature
                     };
                     if (this.Zone != null)
                     {
@@ -533,7 +543,8 @@ private VolumeGroupDetails CreateHostVolumeGroup(string name, string sid, string
                         ExportPolicy = volumeExportPolicy,
                         Zones = zoneList,
                         KeyVaultPrivateEndpointResourceId = this.KeyVaultPrivateEndpointResourceId,
-                        EncryptionKeySource = this.EncryptionKeySource
+                        EncryptionKeySource = this.EncryptionKeySource,
+                        NetworkFeatures = this.NetworkFeature
                     };
                     if (this.Zone != null)
                     {

src/NetAppFiles/NetAppFiles/help/New-AzNetAppFilesVolumeGroup.md

@@ -25,9 +25,9 @@ New-AzNetAppFilesVolumeGroup -ResourceGroupName <String> -Location <String> -Acc
  [-LogBackupPerformance <Int32>] [-HannaSystemReplication] [-DisasterRecoveryDestination]
  [-BackupProtocolType <String[]>] [-ExportPolicy <PSNetAppFilesVolumeExportPolicy>]
  [-GlobalPlacementRule <System.Collections.Generic.IList`1[Microsoft.Azure.Management.NetApp.Models.PlacementKeyValuePairs]>]
- [-EncryptionKeySource <String>] [-KeyVaultPrivateEndpointResourceId <String>] [-Zone <String[]>]
- [-Tag <Hashtable>] [-DefaultProfile <IAzureContextContainer>] [-WhatIf]
- [-Confirm] [<CommonParameters>]
+ [-EncryptionKeySource <String>] [-NetworkFeature <String>] [-KeyVaultPrivateEndpointResourceId <String>]
+ [-Zone <String[]>] [-Tag <Hashtable>] [-DefaultProfile <IAzureContextContainer>]
+ [-ProgressAction <ActionPreference>] [-WhatIf] [-Confirm] [<CommonParameters>]
 ```
 
 ### ByParentObjectParameterSet
@@ -42,9 +42,10 @@ New-AzNetAppFilesVolumeGroup -PoolName <String> [-Name <String>] [-GroupDescript
  [-DisasterRecoveryDestination] [-BackupProtocolType <String[]>]
  [-ExportPolicy <PSNetAppFilesVolumeExportPolicy>]
  [-GlobalPlacementRule <System.Collections.Generic.IList`1[Microsoft.Azure.Management.NetApp.Models.PlacementKeyValuePairs]>]
- [-EncryptionKeySource <String>] [-KeyVaultPrivateEndpointResourceId <String>] [-Zone <String[]>]
- [-Tag <Hashtable>] -AccountObject <PSNetAppFilesAccount> [-DefaultProfile <IAzureContextContainer>]
- [-WhatIf] [-Confirm] [<CommonParameters>]
+ [-EncryptionKeySource <String>] [-NetworkFeature <String>] [-KeyVaultPrivateEndpointResourceId <String>]
+ [-Zone <String[]>] [-Tag <Hashtable>] -AccountObject <PSNetAppFilesAccount>
+ [-DefaultProfile <IAzureContextContainer>] [-ProgressAction <ActionPreference>] [-WhatIf] [-Confirm]
+ [<CommonParameters>]
 ```
 
 ## DESCRIPTION
@@ -59,6 +60,13 @@ New-AzNetAppFilesVolumeGroup -ResourceGroupName "MyRG" -AccountName "MyAnfAccoun
 
 This command creates the new "PRIMARY" ANF VolumeGroup "MyAnfVolumeGroup" within the Account "MyAnfAccount" using the proximityPlacementGroup "MyPPGResourceId", the vnet "MyAnfVnet", and NodeMemory of 100
 
+### Example 2
+```powershell
+New-AzNetAppFilesVolumeGroup -ResourceGroupName "MyRG" -AccountName "MyAnfAccount" -PoolName "MyAnfPool" -Name "MyAnfVolumeGroupName" -Location "westus2"  -GroupDescription "MyAnfVolumeGroup Description" -ApplicationIdentifier "OR1" -Zone 1 -Vnet "MyAnfVnet" -SystemRole "PRIMARY" -NodeMemory 100
+```
+
+This command creates the new "PRIMARY" ANF VolumeGroup "MyAnfVolumeGroup" within the Account "MyAnfAccount" using Zone 1, the vnet "MyAnfVnet", and NodeMemory of 100
+
 ## PARAMETERS
 
 ### -AccountName
@@ -449,6 +457,21 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
+### -NetworkFeature
+Basic network, or Standard features available to the volume (Basic, Standard).
+
+```yaml
+Type: System.String
+Parameter Sets: (All)
+Aliases:
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: False
+Accept wildcard characters: False
+```
+
 ### -NodeMemory
 SAP node memory (GiB), Memory on SAP compute host
 
@@ -496,6 +519,21 @@ Accept pipeline input: False
 Accept wildcard characters: False
 ```
 
+### -ProgressAction
+{{ Fill ProgressAction Description }}
+
+```yaml
+Type: System.Management.Automation.ActionPreference
+Parameter Sets: (All)
+Aliases: proga
+
+Required: False
+Position: Named
+Default value: None
+Accept pipeline input: False
+Accept wildcard characters: False
+```
+
 ### -ProximityPlacementGroup
 Default proximity placement group, for data, log, and if present the shared volume, in all volume groups.
 Specifies that the data, log, and shared volumes are to be created close to the VMs