Skip to content

[Az.RecoveryServices] Added support for enabling and disabling the azure monitor and email notification alerts for site recovery in recovery services vault #24620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

vidyadharijami
Copy link
Member

Description

Added support for enabling and disabling the azure monitor and email notification alerts for site recovery in recovery services vault

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

…e azure monitor and email notification alerts for site recovery in recovery services vault
Copy link

azure-client-tools-bot-prd bot commented Apr 14, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Signature Check
❌PowerShell Core - Windows
Type Cmdlet Description Remediation
New-AzRecoveryServicesVault Parameter DisableAzureMonitorAlertsForAllReplicationIssues of cmdlet New-AzRecoveryServicesVault does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
New-AzRecoveryServicesVault Parameter DisableAzureMonitorAlertsForAllFailoverIssues of cmdlet New-AzRecoveryServicesVault does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
Update-AzRecoveryServicesVault Parameter DisableAzureMonitorAlertsForAllReplicationIssues of cmdlet Update-AzRecoveryServicesVault does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
Update-AzRecoveryServicesVault Parameter DisableAzureMonitorAlertsForAllFailoverIssues of cmdlet Update-AzRecoveryServicesVault does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
❌Windows PowerShell - Windows
Type Cmdlet Description Remediation
New-AzRecoveryServicesVault Parameter DisableAzureMonitorAlertsForAllReplicationIssues of cmdlet New-AzRecoveryServicesVault does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
New-AzRecoveryServicesVault Parameter DisableAzureMonitorAlertsForAllFailoverIssues of cmdlet New-AzRecoveryServicesVault does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
Update-AzRecoveryServicesVault Parameter DisableAzureMonitorAlertsForAllReplicationIssues of cmdlet Update-AzRecoveryServicesVault does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
Update-AzRecoveryServicesVault Parameter DisableAzureMonitorAlertsForAllFailoverIssues of cmdlet Update-AzRecoveryServicesVault does not follow the enforced naming convention of using a singular noun for a parameter name. Consider using a singular noun for the parameter name.
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️File Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Generated Sdk Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Test
❌ - Linux
❌ - MacOS
❌PowerShell Core - Windows
❌Windows PowerShell - Windows

@Nickcandy
Copy link
Contributor

Hi @vidyadharijami, please see the error for the ci pipeline
please try to fix the parameter to singular noun

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@vidyadharijami
Copy link
Member Author

Abandoning this PR. Creating a new PR fixing the test recordings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants