Skip to content

[Get-AzMetric.md]fix: don't worked example 4 #24653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 8, 2024
Merged

Conversation

sakkuntyo
Copy link
Contributor

@sakkuntyo sakkuntyo commented Apr 18, 2024

fix: don't worked example 4

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

fix: don't worked example 4
Copy link

azure-client-tools-bot-prd bot commented Apr 18, 2024

️✔️Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

Copy link
Contributor

Thank you for your contribution sakkuntyo! We will review the pull request and get back to you soon.

@sakkuntyo sakkuntyo changed the title Update Get-AzMetric.md [Get-AzMetric.md]fix: don't worked example 4 Apr 18, 2024
Nickcandy
Nickcandy previously approved these changes Apr 19, 2024
@Nickcandy
Copy link
Contributor

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@sakkuntyo
Copy link
Contributor Author

Sorry, there were also errors in the corrected script. I will specify the corrections later.

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@Nickcandy
Copy link
Contributor

Just a friendly reminder: our code freeze deadline is at 6 PM PST on April 22nd. If your code is intended for this release, please ensure it is completed as soon as possible.

@YanaXu
Copy link
Contributor

YanaXu commented Apr 24, 2024

Hi @sakkuntyo , I feel the update is not correct. I'll convert it to draft. If you test it, could you provide your test logs or screenshot amd change it to be ready again?

@YanaXu YanaXu marked this pull request as draft April 24, 2024 08:32
@sakkuntyo
Copy link
Contributor Author

I apologize for the delay. I have corrected my incorrect modification. The left side was the incorrect modification, and the right side is the correct one.

4f6819f

incorrect fix:
There were errors in the designation and output of the red line section.
image

correct fix:
image

@YanaXu YanaXu marked this pull request as ready for review April 25, 2024 05:04
@YanaXu
Copy link
Contributor

YanaXu commented Apr 25, 2024

/azp run azure-powershell - security-tools

Copy link
Contributor

Azure Pipelines successfully started running 1 pipeline(s).

@YanaXu
Copy link
Contributor

YanaXu commented Apr 25, 2024

were errors in the designation and outp

Hi @sakkuntyo, could you please run the complete test? I see you update the paramter from an string arry to string, could you also run the Get-AzMetric? And please provide the screen log since the screenshot is not clear.

@YanaXu YanaXu merged commit 45cf803 into Azure:main May 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants