Skip to content

Conversation

fangru2023
Copy link
Member

@fangru2023 fangru2023 commented Aug 22, 2024

Description

ChangeLog

  1. Added new Cmdlets:
Get-AzStandbyContainerGroupPoolStatus

Get-AzStandbyVMPoolStatus
  1. Update existing Cmdlets
New-AzStandbyVMPool by add new parameter -MinReadyCapacity to support new added properties in put call.
  1. Deprecated Cmdlets
Get-StandbyVMPoolVM

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Aug 22, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.StandbyPool
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzStandbyContainerGroupPool Get-AzStandbyContainerGroupPool Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStandbyContainerGroupPool Get-AzStandbyContainerGroupPool changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzStandbyContainerGroupPoolStatus Get-AzStandbyContainerGroupPoolStatus Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStandbyContainerGroupPoolStatus Get-AzStandbyContainerGroupPoolStatus changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzStandbyVMPool Get-AzStandbyVMPool Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStandbyVMPool Get-AzStandbyVMPool changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzStandbyVMPoolStatus Get-AzStandbyVMPoolStatus Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzStandbyVMPoolStatus Get-AzStandbyVMPoolStatus changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
️✔️Help Example Check
️✔️PowerShell Core - Windows
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.StandbyPool. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows

@fangru2023 fangru2023 changed the title Powershell release StandbyPool 2024-03-01-preview Powershell release StandbyPool 2024-03-01 Aug 23, 2024
@dolauli
Copy link
Contributor

dolauli commented Aug 27, 2024

@fangru2023 Please add a file like https://github.com/Azure/azure-powershell/blob/main/tools/StaticAnalysis/Exceptions/Az.Cdn/UXMetadataIssues.csv for your module to suppress the UX failures. Please check the failed CI job for what you should input in the file.

@dolauli dolauli self-assigned this Aug 27, 2024
Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@fangru2023
Copy link
Member Author

cc: @mimckitt @jiaosummer

@fangru2023
Copy link
Member Author

@fangru2023 Please add a file like https://github.com/Azure/azure-powershell/blob/main/tools/StaticAnalysis/Exceptions/Az.Cdn/UXMetadataIssues.csv for your module to suppress the UX failures. Please check the failed CI job for what you should input in the file.

Hi @msJinLei , and @dolauli ,

Thanks for reviewing, address this comment and updated pr.

@msJinLei msJinLei self-assigned this Sep 10, 2024
@msJinLei
Copy link
Contributor

Lei is following up the build issue

@msJinLei msJinLei added Waiting for CI :shipit: needs-author-feedback More information is needed from author to address the issue. and removed needs-revision Waiting for CI :shipit: labels Sep 11, 2024
Copy link
Contributor

@msJinLei msJinLei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide a change log for your PR

@fangru2023
Copy link
Member Author

fangru2023 commented Sep 13, 2024

Please provide a change log for your PR

Hi @msJinLei thanks for reviewing, updated PR description with ChangeLog.

@microsoft-github-policy-service microsoft-github-policy-service bot added needs-team-attention This issue needs attention from Azure service team or SDK team and removed needs-author-feedback More information is needed from author to address the issue. labels Sep 13, 2024
@msJinLei msJinLei added needs-revision and removed needs-team-attention This issue needs attention from Azure service team or SDK team labels Sep 14, 2024
Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@fangru2023
Copy link
Member Author

Thanks @msJinLei, updated pr to address your comment.

@fangru2023 fangru2023 added the needs-team-attention This issue needs attention from Azure service team or SDK team label Sep 17, 2024
@msJinLei msJinLei merged commit 6ebcd50 into Azure:generation Sep 18, 2024
9 checks passed
@fangru2023
Copy link
Member Author

Hi @dolauli, and @msJinLei, do you know when will our powershell package release, do we need start a release?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-revision needs-team-attention This issue needs attention from Azure service team or SDK team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants