Skip to content

Migrate Workloads from generation to main #25994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Migrate Workloads from generation to main #25994

wants to merge 1 commit into from

Conversation

@azure-pipelines
Copy link
Contributor

Description

Migrate Workloads from generation to main
The last commit of src/Workloads in generation is:
commit c95185e Author: Jaskirat Singh 108129510+jaskisin@users.noreply.github.com Date: Tue Sep 3 10:55:58 2024 +0530 Generation of Powershell module after splitting at RT level (#25818) * Release new PS release with split before GA * Update MSI logic during migration (#25712) * Sync tools folder from main branch to generation branch (#25741) Co-authored-by: azurepowershell azurepowershell@ms.com * Sync tools folder from main branch to generation branch (#25744) Co-authored-by: azurepowershell azurepowershell@ms.com * Generate Defender for Storage V2 cmdlets (#25728) * Generate Defender for Storage V2 cmdlets * Fix build and PR comments * Make DefenderForStorageSettings a submodule * Create UXMetadataIssues.csv to suppress false positive UX metadata issue * Edit one of the examples --------- Co-authored-by: Xiaogang xidi@microsoft.com * Sync tools folder from main branch to generation branch (#25772) Co-authored-by: azurepowershell azurepowershell@ms.com * changing module name * Adding aliases to commands * Adding aliases to commands * Adding docs and examples * Update README.md to add root module for SapVirtualInstance * Adding parameter to readme file * Adding Monitors and Removing --------- Co-authored-by: Jaskirat Singh jasksingh@microsoft.com Co-authored-by: TracyYaoYao 40618305+TracyYaoYao@users.noreply.github.com Co-authored-by: Azure PowerShell 65331932+azure-powershell-bot@users.noreply.github.com Co-authored-by: azurepowershell azurepowershell@ms.com Co-authored-by: TalFrankel 73380649+TalFrankel@users.noreply.github.com Co-authored-by: Xiaogang xidi@microsoft.com

Checklist

  • SHOULD select appropriate branch. Cmdlets from Autorest.PowerShell should go to generation branch.
  • SHOULD make the title of PR clear and informative, and in the present imperative tense.
  • SHOULD update ChangeLog.md file(s) appropriately
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense. Add changelog in description section if PR goes into generation branch.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD have approved design review for the changes in this repository (Microsoft internal only) with following situations
    • Create new module from scratch
    • Create new resource types which are not easy to conform to Azure PowerShell Design Guidelines
    • Create new resource type which name doesn't use module name as prefix
    • Have design question before implementation
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT introduce breaking changes in Az minor release except preview version.
  • SHOULD NOT adjust version of module manually in pull request

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Sep 3, 2024 •
edited
Loading

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Az.Workloads
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzWorkloadsMonitor Get-AzWorkloadsMonitor Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsMonitor Get-AzWorkloadsMonitor changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsProviderInstance Get-AzWorkloadsProviderInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsProviderInstance Get-AzWorkloadsProviderInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapApplicationInstance Get-AzWorkloadsSapApplicationInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapApplicationInstance Get-AzWorkloadsSapApplicationInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapCentralInstance Get-AzWorkloadsSapCentralInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapCentralInstance Get-AzWorkloadsSapCentralInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapDatabaseInstance Get-AzWorkloadsSapDatabaseInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapDatabaseInstance Get-AzWorkloadsSapDatabaseInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapLandscapeMonitor Get-AzWorkloadsSapLandscapeMonitor Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapLandscapeMonitor Get-AzWorkloadsSapLandscapeMonitor changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapVirtualInstance Get-AzWorkloadsSapVirtualInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapVirtualInstance Get-AzWorkloadsSapVirtualInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderDB2InstanceObject New-AzWorkloadsProviderDB2InstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderHanaDbInstanceObject New-AzWorkloadsProviderHanaDbInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderPrometheusHaClusterInstanceObject New-AzWorkloadsProviderPrometheusHaClusterInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderPrometheusOSInstanceObject New-AzWorkloadsProviderPrometheusOSInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderSapNetWeaverInstanceObject New-AzWorkloadsProviderSapNetWeaverInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderSqlServerInstanceObject New-AzWorkloadsProviderSqlServerInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsSapLandscapeMonitorMetricThresholdsObject New-AzWorkloadsSapLandscapeMonitorMetricThresholdsObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsSapLandscapeMonitorSidMappingObject New-AzWorkloadsSapLandscapeMonitorSidMappingObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzWorkloadsMonitor Get-AzWorkloadsMonitor Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsMonitor Get-AzWorkloadsMonitor changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsProviderInstance Get-AzWorkloadsProviderInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsProviderInstance Get-AzWorkloadsProviderInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapApplicationInstance Get-AzWorkloadsSapApplicationInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapApplicationInstance Get-AzWorkloadsSapApplicationInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapCentralInstance Get-AzWorkloadsSapCentralInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapCentralInstance Get-AzWorkloadsSapCentralInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapDatabaseInstance Get-AzWorkloadsSapDatabaseInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapDatabaseInstance Get-AzWorkloadsSapDatabaseInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapLandscapeMonitor Get-AzWorkloadsSapLandscapeMonitor Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapLandscapeMonitor Get-AzWorkloadsSapLandscapeMonitor changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWorkloadsSapVirtualInstance Get-AzWorkloadsSapVirtualInstance Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWorkloadsSapVirtualInstance Get-AzWorkloadsSapVirtualInstance changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderDB2InstanceObject New-AzWorkloadsProviderDB2InstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderHanaDbInstanceObject New-AzWorkloadsProviderHanaDbInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderPrometheusHaClusterInstanceObject New-AzWorkloadsProviderPrometheusHaClusterInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderPrometheusOSInstanceObject New-AzWorkloadsProviderPrometheusOSInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderSapNetWeaverInstanceObject New-AzWorkloadsProviderSapNetWeaverInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsProviderSqlServerInstanceObject New-AzWorkloadsProviderSqlServerInstanceObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsSapLandscapeMonitorMetricThresholdsObject New-AzWorkloadsSapLandscapeMonitorMetricThresholdsObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ New-AzWorkloadsSapLandscapeMonitorSidMappingObject New-AzWorkloadsSapLandscapeMonitorSidMappingObject changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzWorkloadsProviderInstance 2 1 Mismatched_Parameter_Value_Type New-AzWorkloadsProviderInstance -ProviderSetting '{'sslPreference':'Disabled','providerType':'MsSqlServer','hostname':'10.1.14.5','sapSid':'X00','dbPort':'1433','dbUsername':'','dbPassword':''}' is not an expected parameter value type. -ProviderSetting Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.IProviderSpecificProperties. Now the type is string.(Static).
⚠️ New-AzWorkloadsProviderSapNetWeaverInstanceObject 1 1 Unassigned_Variable New-AzWorkloadsProviderSapNetWeaverInstanceObject -SapPassword $password is a null-valued parameter value. -SapPassword Assign value for $password.
⚠️ New-AzWorkloadsProviderSqlServerInstanceObject 1 1 Unassigned_Variable New-AzWorkloadsProviderSqlServerInstanceObject -Password $password is a null-valued parameter value. -Password Assign value for $password.
⚠️ New-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingLandscape '{'name':'Prod','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingLandscape Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ New-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingSapApplication '{'name':'ERP1','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingSapApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ New-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -TopMetricsThreshold '{'name':'Instance Availability','green':90,'yellow':75,'red':50}' is not an expected parameter value type. -TopMetricsThreshold Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorMetricThresholds. Now the type is string.(Static).
⚠️ Update-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingLandscape '{'name':'Prod','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingLandscape Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ Update-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingSapApplication '{'name':'ERP1','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingSapApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ Update-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -TopMetricsThreshold '{'name':'Instance Availability','green':90,'yellow':75,'red':50}' is not an expected parameter value type. -TopMetricsThreshold Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorMetricThresholds. Now the type is string.(Static).
⚠️ New-AzWorkloadsProviderInstance 2 1 Mismatched_Parameter_Value_Type New-AzWorkloadsProviderInstance -ProviderSetting '{'sslPreference':'Disabled','providerType':'MsSqlServer','hostname':'10.1.14.5','sapSid':'X00','dbPort':'1433','dbUsername':'','dbPassword':''}' is not an expected parameter value type. -ProviderSetting Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.IProviderSpecificProperties. Now the type is string.(Static).
⚠️ New-AzWorkloadsProviderSapNetWeaverInstanceObject 1 1 Unassigned_Variable New-AzWorkloadsProviderSapNetWeaverInstanceObject -SapPassword $password is a null-valued parameter value. -SapPassword Assign value for $password.
⚠️ New-AzWorkloadsProviderSqlServerInstanceObject 1 1 Unassigned_Variable New-AzWorkloadsProviderSqlServerInstanceObject -Password $password is a null-valued parameter value. -Password Assign value for $password.
⚠️ New-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingLandscape '{'name':'Prod','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingLandscape Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ New-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingSapApplication '{'name':'ERP1','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingSapApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ New-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -TopMetricsThreshold '{'name':'Instance Availability','green':90,'yellow':75,'red':50}' is not an expected parameter value type. -TopMetricsThreshold Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorMetricThresholds. Now the type is string.(Static).
⚠️ Update-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingLandscape '{'name':'Prod','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingLandscape Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ Update-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingSapApplication '{'name':'ERP1','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingSapApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ Update-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -TopMetricsThreshold '{'name':'Instance Availability','green':90,'yellow':75,'red':50}' is not an expected parameter value type. -TopMetricsThreshold Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorMetricThresholds. Now the type is string.(Static).
⚠️Windows PowerShell - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzWorkloadsProviderInstance 2 1 Mismatched_Parameter_Value_Type New-AzWorkloadsProviderInstance -ProviderSetting '{'sslPreference':'Disabled','providerType':'MsSqlServer','hostname':'10.1.14.5','sapSid':'X00','dbPort':'1433','dbUsername':'','dbPassword':''}' is not an expected parameter value type. -ProviderSetting Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.IProviderSpecificProperties. Now the type is string.(Static).
⚠️ New-AzWorkloadsProviderSapNetWeaverInstanceObject 1 1 Unassigned_Variable New-AzWorkloadsProviderSapNetWeaverInstanceObject -SapPassword $password is a null-valued parameter value. -SapPassword Assign value for $password.
⚠️ New-AzWorkloadsProviderSqlServerInstanceObject 1 1 Unassigned_Variable New-AzWorkloadsProviderSqlServerInstanceObject -Password $password is a null-valued parameter value. -Password Assign value for $password.
⚠️ New-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingLandscape '{'name':'Prod','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingLandscape Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ New-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingSapApplication '{'name':'ERP1','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingSapApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ New-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -TopMetricsThreshold '{'name':'Instance Availability','green':90,'yellow':75,'red':50}' is not an expected parameter value type. -TopMetricsThreshold Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorMetricThresholds. Now the type is string.(Static).
⚠️ Update-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingLandscape '{'name':'Prod','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingLandscape Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ Update-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingSapApplication '{'name':'ERP1','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingSapApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ Update-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -TopMetricsThreshold '{'name':'Instance Availability','green':90,'yellow':75,'red':50}' is not an expected parameter value type. -TopMetricsThreshold Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorMetricThresholds. Now the type is string.(Static).
⚠️ New-AzWorkloadsProviderInstance 2 1 Mismatched_Parameter_Value_Type New-AzWorkloadsProviderInstance -ProviderSetting '{'sslPreference':'Disabled','providerType':'MsSqlServer','hostname':'10.1.14.5','sapSid':'X00','dbPort':'1433','dbUsername':'','dbPassword':''}' is not an expected parameter value type. -ProviderSetting Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.IProviderSpecificProperties. Now the type is string.(Static).
⚠️ New-AzWorkloadsProviderSapNetWeaverInstanceObject 1 1 Unassigned_Variable New-AzWorkloadsProviderSapNetWeaverInstanceObject -SapPassword $password is a null-valued parameter value. -SapPassword Assign value for $password.
⚠️ New-AzWorkloadsProviderSqlServerInstanceObject 1 1 Unassigned_Variable New-AzWorkloadsProviderSqlServerInstanceObject -Password $password is a null-valued parameter value. -Password Assign value for $password.
⚠️ New-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingLandscape '{'name':'Prod','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingLandscape Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ New-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingSapApplication '{'name':'ERP1','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingSapApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ New-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -TopMetricsThreshold '{'name':'Instance Availability','green':90,'yellow':75,'red':50}' is not an expected parameter value type. -TopMetricsThreshold Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorMetricThresholds. Now the type is string.(Static).
⚠️ Update-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingLandscape '{'name':'Prod','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingLandscape Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ Update-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -GroupingSapApplication '{'name':'ERP1','topSid':['SID1','SID2']}' is not an expected parameter value type. -GroupingSapApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorSidMapping. Now the type is string.(Static).
⚠️ Update-AzWorkloadsSapLandscapeMonitor 1 1 Mismatched_Parameter_Value_Type New-AzWorkloadsSapLandscapeMonitor -TopMetricsThreshold '{'name':'Instance Availability','green':90,'yellow':75,'red':50}' is not an expected parameter value type. -TopMetricsThreshold Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.Workloads.Models.Api20230401.ISapLandscapeMonitorMetricThresholds. Now the type is string.(Static).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Workloads. Add a changelog record under Upcoming Release section with past tense.
⚠️Windows PowerShell - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Workloads. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows

@microsoft-github-policy-service
Copy link
Contributor

Thank you for your contribution azure-pipelines[bot]! We will review the pull request and get back to you soon.

@msJinLei
Copy link
Contributor

msJinLei commented Sep 3, 2024 •
edited
Loading

@jaskisin Please fix the issues find in security scan. You can submit a new PR based on generation branch.

##[error]1. Credential Scanner Error CSCAN-MSFT0090 - File: SecurityTmp/src/Workloads/Monitors.Autorest/test/New-AzWorkloadsProviderDB2InstanceObject.Recording.json:SecurityTmp/src/Workloads/Monitors.Autorest/test/New-AzWorkloadsProviderDB2InstanceObject.Recording.json. Line: 6. Column 279. 

##[error]2. Credential Scanner Error CSCAN-GENERAL0060 - File: SecurityTmp/src/Workloads/Monitors.Autorest/test/New-AzWorkloadsProviderHanaDbInstanceObject.Recording.json:SecurityTmp/src/Workloads/Monitors.Autorest/test/New-AzWorkloadsProviderHanaDbInstanceObject.Recording.json. Line: 6. Column 320. 

##[error]3. Credential Scanner Error CSCAN-MSFT0090 - File: SecurityTmp/src/Workloads/Monitors.Autorest/test/New-AzWorkloadsProviderSapNetWeaverInstanceObject.Recording.json:SecurityTmp/src/Workloads/Monitors.Autorest/test/New-AzWorkloadsProviderSapNetWeaverInstanceObject.Recording.json. Line: 6. Column 414. 

##[error]4. Credential Scanner Error CSCAN-MSFT0090 - File: SecurityTmp/src/Workloads/Monitors.Autorest/test/New-AzWorkloadsProviderSapNetWeaverInstanceObject.Tests.ps1:SecurityTmp/src/Workloads/Monitors.Autorest/test/New-AzWorkloadsProviderSapNetWeaverInstanceObject.Tests.ps1. Line: 19. Column 262. 

##[error]5. Credential Scanner Error CSCAN-MSFT0090 - File: SecurityTmp/src/Workloads/Monitors.Autorest/test/New-AzWorkloadsProviderSqlServerInstanceObject.Recording.json:SecurityTmp/src/Workloads/Monitors.Autorest/test/New-AzWorkloadsProviderSqlServerInstanceObject.Recording.json. Line: 6. Column 248. 

##[error]6. Credential Scanner Error CSCAN-MSFT0090 - File: SecurityTmp/src/Workloads/Monitors.Autorest/test/New-AzWorkloadsProviderSqlServerInstanceObject.Tests.ps1:SecurityTmp/src/Workloads/Monitors.Autorest/test/New-AzWorkloadsProviderSqlServerInstanceObject.Tests.ps1. Line: 19. Column 85. 

##[error]7. Credential Scanner Error CSCAN-GENERAL0020 - File: SecurityTmp/src/Workloads/SapVirtualInstance.Autorest/test/CreateDistributedHAAvSetDiffTransRgShareConfig.json:SecurityTmp/src/Workloads/SapVirtualInstance.Autorest/test/CreateDistributedHAAvSetDiffTransRgShareConfig.json. Line: 72. Column 29. 

##[error]8. Credential Scanner Error CSCAN-GENERAL0020 - File: SecurityTmp/src/Workloads/SapVirtualInstance.Autorest/test/DistributedHAAvSetDiffTransRgShare.Recording.json:SecurityTmp/src/Workloads/SapVirtualInstance.Autorest/test/DistributedHAAvSetDiffTransRgShare.Recording.json. Line: 3834. Column 1155.

@github-actions
Copy link

github-actions bot commented Sep 3, 2024

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@dolauli dolauli closed this Sep 3, 2024
@dolauli dolauli deleted the codegen/Workloads branch September 3, 2024 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@jaskisin jaskisin

Labels

customer-reported needs-revision

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msJinLei @dolauli @jaskisin @azure-powershell-bot