Skip to content

Conversation

alec-baird
Copy link
Member

@alec-baird alec-baird commented Sep 3, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

ryanosh and others added 11 commits January 29, 2024 14:29
* build powershell off 2023-11-01

* run tests with recording

* add missing app attach packages

* fix examples and docs

* fix invalidcmdlet examples

* regenerate docs

* remove last invalide param from update SHC

* fix typo in SHM examples

* fix last typo

* update control SHU example

* reformat controlSessionHostUpdate example

* add exception for ux parameter set
* Updated README and built module based on new API

* Updated New and Update examples with UDP Params

* Built module with new examples

* Updated tests to use new params

* Successful remove session host recording

* update test with backtick and changed AppAttach Model API

* all tests pass

* added backticks to examples and rebuilt

* removed bad colons on parameters
Sync desktopvirtualization generation branch to latest gen
* Upgrade api version to 2024-01-16 <Author: alec-baird>

* Create BreakingChangeIssues.csv
Copy link

azure-client-tools-bot-prd bot commented Sep 3, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
⚠️Az.DesktopVirtualization
️✔️Build
️✔️PowerShell Core - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
⚠️Signature Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ Get-AzWvdActiveSessionHostConfiguration Get-AzWvdActiveSessionHostConfiguration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdActiveSessionHostConfiguration Get-AzWvdActiveSessionHostConfiguration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdAppAttachPackage Get-AzWvdAppAttachPackage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdAppAttachPackage Get-AzWvdAppAttachPackage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdApplication Get-AzWvdApplication Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdApplication Get-AzWvdApplication changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdApplicationGroup Get-AzWvdApplicationGroup Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdApplicationGroup Get-AzWvdApplicationGroup changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdDesktop Get-AzWvdDesktop Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdDesktop Get-AzWvdDesktop changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdHostPool Get-AzWvdHostPool Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdHostPool Get-AzWvdHostPool changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdMsixPackage Get-AzWvdMsixPackage Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdMsixPackage Get-AzWvdMsixPackage changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdPrivateEndpointConnection Get-AzWvdPrivateEndpointConnection Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdPrivateEndpointConnection Get-AzWvdPrivateEndpointConnection changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdPrivateLinkResource Get-AzWvdPrivateLinkResource Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdPrivateLinkResource Get-AzWvdPrivateLinkResource changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdRegistrationInfo Get-AzWvdRegistrationInfo Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdRegistrationInfo Get-AzWvdRegistrationInfo changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdScalingPlan Get-AzWvdScalingPlan Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdScalingPlan Get-AzWvdScalingPlan changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdScalingPlanPersonalSchedule Get-AzWvdScalingPlanPersonalSchedule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdScalingPlanPersonalSchedule Get-AzWvdScalingPlanPersonalSchedule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdScalingPlanPooledSchedule Get-AzWvdScalingPlanPooledSchedule Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdScalingPlanPooledSchedule Get-AzWvdScalingPlanPooledSchedule changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdSessionHost Get-AzWvdSessionHost Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdSessionHost Get-AzWvdSessionHost changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdSessionHostConfiguration Get-AzWvdSessionHostConfiguration Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdSessionHostConfiguration Get-AzWvdSessionHostConfiguration changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdSessionHostConfigurationsOperationStatus Get-AzWvdSessionHostConfigurationsOperationStatus Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdSessionHostConfigurationsOperationStatus Get-AzWvdSessionHostConfigurationsOperationStatus changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdSessionHostManagement Get-AzWvdSessionHostManagement Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdSessionHostManagement Get-AzWvdSessionHostManagement changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdSessionHostManagementsOperationStatus Get-AzWvdSessionHostManagementsOperationStatus Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdSessionHostManagementsOperationStatus Get-AzWvdSessionHostManagementsOperationStatus changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdStartMenuItem Get-AzWvdStartMenuItem Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdStartMenuItem Get-AzWvdStartMenuItem changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdUserSession Get-AzWvdUserSession Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdUserSession Get-AzWvdUserSession changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️ Get-AzWvdWorkspace Get-AzWvdWorkspace Changes the ConfirmImpact but does not set the SupportsShouldProcess property to true in the cmdlet attribute. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue
⚠️ Get-AzWvdWorkspace Get-AzWvdWorkspace changes the confirm impact. Please ensure that the change in ConfirmImpact is justified Verify that ConfirmImpact is changed appropriately by the cmdlet. It is very rare for a cmdlet to change the ConfirmImpact.
⚠️Help Example Check
⚠️PowerShell Core - Windows
Type Cmdlet Example Line RuleName Description Extent Remediation
⚠️ New-AzWvdAppAttachPackage 1 12 Mismatched_Parameter_Value_Type New-AzWvdAppAttachPackage -ImagePackageApplication $apps is not an expected parameter value type. -ImagePackageApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.Api20240116Preview.IMsixPackageApplications. Now the type is string.(Static).
⚠️ New-AzWvdAppAttachPackage 1 13 Mismatched_Parameter_Value_Type New-AzWvdAppAttachPackage -ImagePackageDependency $deps is not an expected parameter value type. -ImagePackageDependency Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.Api20240116Preview.IMsixPackageDependencies. Now the type is string.(Static).
⚠️ New-AzWvdAppAttachPackage 2 6 Mismatched_Parameter_Value_Type New-AzWvdAppAttachPackage -AppAttachPackage imageObject is not an expected parameter value type. -AppAttachPackage Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.Api20240116Preview.AppAttachPackage. Now the type is string.(Static).
⚠️ New-AzWvdMsixPackage 2 12 Mismatched_Parameter_Value_Type New-AzWvdMsixPackage -PackageApplication $apps is not an expected parameter value type. -PackageApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.Api20240116Preview.IMsixPackageApplications. Now the type is string.(Static).
⚠️ New-AzWvdMsixPackage 2 13 Mismatched_Parameter_Value_Type New-AzWvdMsixPackage -PackageDependency $deps is not an expected parameter value type. -PackageDependency Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.Api20240116Preview.IMsixPackageDependencies. Now the type is string.(Static).
⚠️ Update-AzWvdAppAttachPackage 1 11 Mismatched_Parameter_Value_Type Update-AzWvdAppAttachPackage -ImagePackageApplication $apps is not an expected parameter value type. -ImagePackageApplication Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.Api20240116Preview.IMsixPackageApplications. Now the type is string.(Static).
⚠️ Update-AzWvdAppAttachPackage 1 12 Mismatched_Parameter_Value_Type Update-AzWvdAppAttachPackage -ImagePackageDependency $deps is not an expected parameter value type. -ImagePackageDependency Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.Api20240116Preview.IMsixPackageDependencies. Now the type is string.(Static).
⚠️ Update-AzWvdAppAttachPackage 2 5 Mismatched_Parameter_Value_Type Update-AzWvdAppAttachPackage -AppAttachPackage imageObject is not an expected parameter value type. -AppAttachPackage Use correct parameter value type. Expected Type is Microsoft.Azure.PowerShell.Cmdlets.DesktopVirtualization.Models.Api20240116Preview.AppAttachPackage. Now the type is string.(Static).
️✔️Help File Existence Check
️✔️PowerShell Core - Windows
⚠️File Change Check
⚠️PowerShell Core - Windows
Type Cmdlet Description Remediation
⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.DesktopVirtualization. Add a changelog record under Upcoming Release section with past tense.
️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Test
️✔️PowerShell Core - Linux
️✔️PowerShell Core - MacOS
️✔️PowerShell Core - Windows

@msJinLei msJinLei changed the base branch from generation-DesktopVirtualization-preview-backup to generation-DesktopVirtualization-preview September 3, 2024 07:33
@msJinLei msJinLei self-assigned this Sep 3, 2024
@alec-baird alec-baird changed the title 2024-04-03 DesktopVirtualization Preview 2024-03-06 DesktopVirtualization Preview Sep 4, 2024
@msJinLei msJinLei changed the title 2024-03-06 DesktopVirtualization Preview [Do Not Squash] 2024-03-06 DesktopVirtualization Preview Sep 5, 2024
@msJinLei msJinLei merged commit efe936e into Azure:generation-DesktopVirtualization-preview Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants