Skip to content

[PS] Migrate NetworkCloud module to autorest v4 #27399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

JoyerJin
Copy link
Contributor

@JoyerJin JoyerJin commented Mar 21, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@YanaXu YanaXu self-assigned this Jun 24, 2025
@YanaXu YanaXu added the Breaking Change Release This PR contains breaking change label Jul 25, 2025
Copy link

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@YanaXu YanaXu removed their assignment Jul 29, 2025
@Copilot Copilot AI review requested due to automatic review settings August 11, 2025 03:38
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 220 out of 236 changed files in this pull request and generated 6 comments.

@@ -9,7 +9,7 @@ schema: 2.0.0

## SYNOPSIS
Patch properties of bare metal machine key set for the provided cluster, or update the tags associated with it.
Properties and tag updates can be done independently.
Properties and tag update can be done independently.
Copy link
Preview

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'update' should be 'updates' to maintain grammatical consistency with the plural subject 'Properties and tag'.

Suggested change
Properties and tag update can be done independently.
Properties and tag updates can be done independently.

Copilot uses AI. Check for mistakes.

@@ -9,7 +9,7 @@ schema: 2.0.0

## SYNOPSIS
Patch properties of the provided bare metal machine, or update tags associated with the bare metal machine.
Properties and tag updates can be done independently.
Properties and tag update can be done independently.
Copy link
Preview

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'update' should be 'updates' to maintain grammatical consistency with the plural subject 'Properties and tag'.

Suggested change
Properties and tag update can be done independently.
Properties and tag updates can be done independently.

Copilot uses AI. Check for mistakes.

@@ -9,7 +9,7 @@ schema: 2.0.0

## SYNOPSIS
Patch the properties of the provided Kubernetes cluster agent pool, or update the tags associated with the Kubernetes cluster agent pool.
Properties and tag updates can be done independently.
Properties and tag update can be done independently.
Copy link
Preview

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The word 'update' should be 'updates' to maintain grammatical consistency with the plural subject 'Properties and tag'.

Suggested change
Properties and tag update can be done independently.
Properties and tag updates can be done independently.

Copilot uses AI. Check for mistakes.

@@ -8,19 +8,34 @@ schema: 2.0.0
# New-AzNetworkCloudVolume

## SYNOPSIS
Create a new volume or update the properties of the existing one.
Create a new volume or create the properties of the existing one.
Copy link
Preview

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase 'create the properties' should be 'update the properties' as you cannot create properties of an existing volume.

Suggested change
Create a new volume or create the properties of the existing one.
Create a new volume or update the properties of the existing one.

Copilot uses AI. Check for mistakes.

@@ -8,33 +8,46 @@ schema: 2.0.0
# New-AzNetworkCloudVirtualMachine

## SYNOPSIS
Create a new virtual machine or update the properties of the existing virtual machine.
Create a new virtual machine or create the properties of the existing virtual machine.
Copy link
Preview

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase 'create the properties' should be 'update the properties' as you cannot create properties of an existing virtual machine.

Suggested change
Create a new virtual machine or create the properties of the existing virtual machine.
Create a new virtual machine or update the properties of the existing virtual machine.

Copilot uses AI. Check for mistakes.

@@ -8,20 +8,35 @@ schema: 2.0.0
# New-AzNetworkCloudTrunkedNetwork

## SYNOPSIS
Create a new trunked network or update the properties of the existing trunked network.
Create a new trunked network or create the properties of the existing trunked network.
Copy link
Preview

Copilot AI Aug 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The phrase 'create the properties' should be 'update the properties' as you cannot create properties of an existing trunked network.

Suggested change
Create a new trunked network or create the properties of the existing trunked network.
Create a new trunked network or update the properties of the existing trunked network.

Copilot uses AI. Check for mistakes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Release This PR contains breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants