-
Notifications
You must be signed in to change notification settings - Fork 4k
[PS] Migrate NetworkCloud module to autorest v4 #27399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
To the author of the pull request, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 220 out of 236 changed files in this pull request and generated 6 comments.
@@ -9,7 +9,7 @@ schema: 2.0.0 | |||
|
|||
## SYNOPSIS | |||
Patch properties of bare metal machine key set for the provided cluster, or update the tags associated with it. | |||
Properties and tag updates can be done independently. | |||
Properties and tag update can be done independently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'update' should be 'updates' to maintain grammatical consistency with the plural subject 'Properties and tag'.
Properties and tag update can be done independently. | |
Properties and tag updates can be done independently. |
Copilot uses AI. Check for mistakes.
@@ -9,7 +9,7 @@ schema: 2.0.0 | |||
|
|||
## SYNOPSIS | |||
Patch properties of the provided bare metal machine, or update tags associated with the bare metal machine. | |||
Properties and tag updates can be done independently. | |||
Properties and tag update can be done independently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'update' should be 'updates' to maintain grammatical consistency with the plural subject 'Properties and tag'.
Properties and tag update can be done independently. | |
Properties and tag updates can be done independently. |
Copilot uses AI. Check for mistakes.
@@ -9,7 +9,7 @@ schema: 2.0.0 | |||
|
|||
## SYNOPSIS | |||
Patch the properties of the provided Kubernetes cluster agent pool, or update the tags associated with the Kubernetes cluster agent pool. | |||
Properties and tag updates can be done independently. | |||
Properties and tag update can be done independently. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The word 'update' should be 'updates' to maintain grammatical consistency with the plural subject 'Properties and tag'.
Properties and tag update can be done independently. | |
Properties and tag updates can be done independently. |
Copilot uses AI. Check for mistakes.
@@ -8,19 +8,34 @@ schema: 2.0.0 | |||
# New-AzNetworkCloudVolume | |||
|
|||
## SYNOPSIS | |||
Create a new volume or update the properties of the existing one. | |||
Create a new volume or create the properties of the existing one. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'create the properties' should be 'update the properties' as you cannot create properties of an existing volume.
Create a new volume or create the properties of the existing one. | |
Create a new volume or update the properties of the existing one. |
Copilot uses AI. Check for mistakes.
@@ -8,33 +8,46 @@ schema: 2.0.0 | |||
# New-AzNetworkCloudVirtualMachine | |||
|
|||
## SYNOPSIS | |||
Create a new virtual machine or update the properties of the existing virtual machine. | |||
Create a new virtual machine or create the properties of the existing virtual machine. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'create the properties' should be 'update the properties' as you cannot create properties of an existing virtual machine.
Create a new virtual machine or create the properties of the existing virtual machine. | |
Create a new virtual machine or update the properties of the existing virtual machine. |
Copilot uses AI. Check for mistakes.
@@ -8,20 +8,35 @@ schema: 2.0.0 | |||
# New-AzNetworkCloudTrunkedNetwork | |||
|
|||
## SYNOPSIS | |||
Create a new trunked network or update the properties of the existing trunked network. | |||
Create a new trunked network or create the properties of the existing trunked network. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The phrase 'create the properties' should be 'update the properties' as you cannot create properties of an existing trunked network.
Create a new trunked network or create the properties of the existing trunked network. | |
Create a new trunked network or update the properties of the existing trunked network. |
Copilot uses AI. Check for mistakes.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.