Skip to content

Add Dedicated Host redeploy support #27764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

thomascoats
Copy link

@thomascoats thomascoats commented May 14, 2025

Description

Adding parameter to Update-AzHost to support dedicated host redeploy

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

Copy link
Member

@grizzlytheodore grizzlytheodore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msJinLei
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

msJinLei commented May 20, 2025

@thomascoats please fix the 4 failed test cases
Here is the example for one of them

2025-05-19T17:30:58.9674130Z   [xUnit.net 00:02:00.03]     Microsoft.Azure.Commands.Compute.Test.ScenarioTests.DedicatedHostTests.TestDedicatedHostRestart [FAIL]
2025-05-19T17:30:59.5034067Z     Failed Microsoft.Azure.Commands.Compute.Test.ScenarioTests.DedicatedHostTests.TestDedicatedHostRestart [801 ms]
2025-05-19T17:30:59.5037835Z EXEC : error Message:  [D:\a\_work\1\s\build.proj]
2025-05-19T17:30:59.5038589Z      System.Management.Automation.CommandNotFoundException : The term 'Test-DedicatedHostRestart' is not recognized as a name of a cmdlet, function, script file, or executable program.
2025-05-19T17:30:59.5039331Z   Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
2025-05-19T17:30:59.5040183Z     Stack Trace:
2025-05-19T17:30:59.5040867Z        at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
2025-05-19T17:30:59.5041507Z      at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
2025-05-19T17:30:59.5042183Z      at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
2025-05-19T17:30:59.5042915Z      at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
2025-05-19T17:30:59.5043677Z      at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
2025-05-19T17:30:59.5044330Z      at System.Management.Automation.PowerShell.Invoke()
2025-05-19T17:30:59.5045014Z      at Microsoft.Azure.Commands.TestFx.EnvironmentSetupHelper.RunPowerShellTest(String[] scripts) in D:\a\_work\1\s\tools\TestFx\EnvironmentSetupHelper.cs:line 501
2025-05-19T17:30:59.5045860Z      at Microsoft.Azure.Commands.TestFx.TestManager.RunTestScriptCore(Action setUp, Action`1 contextAction, Action tearDown, String[] scripts) in D:\a\_work\1\s\tools\TestFx\TestManager.cs:line 250
2025-05-19T17:30:59.5046658Z      at Microsoft.Azure.Commands.TestFx.TestManager.RunTestScript(String[] scripts) in D:\a\_work\1\s\tools\TestFx\TestManager.cs:line 216
2025-05-19T17:30:59.5047447Z      at Microsoft.Azure.Commands.Compute.Test.ScenarioTests.DedicatedHostTests.TestDedicatedHostRestart() in D:\a\_work\1\s\src\Compute\Compute.Test\ScenarioTests\DedicatedHostTests.cs:line 45
2025-05-19T17:30:59.5048219Z      at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
2025-05-19T17:30:59.5048858Z      at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
2025-05-19T17:30:59.5049409Z     Standard Output Messages:
2025-05-19T17:30:59.5049876Z    Test-DedicatedHostRestart
2025-05-19T17:30:59.5050514Z    Caught Exception: System.Management.Automation.CommandNotFoundException: The term 'Test-DedicatedHostRestart' is not recognized as a name of a cmdlet, function, script file, or executable program.
2025-05-19T17:30:59.5051239Z    Check the spelling of the name, or if a path was included, verify that the path is correct and try again.
2025-05-19T17:30:59.5051840Z       at System.Management.Automation.Runspaces.PipelineBase.Invoke(IEnumerable input)
2025-05-19T17:30:59.5052471Z       at System.Management.Automation.PowerShell.Worker.ConstructPipelineAndDoWork(Runspace rs, Boolean performSyncInvoke)
2025-05-19T17:30:59.5053158Z       at System.Management.Automation.PowerShell.Worker.CreateRunspaceIfNeededAndDoWork(Runspace rsToUse, Boolean isSync)
2025-05-19T17:30:59.5053877Z       at System.Management.Automation.PowerShell.CoreInvokeHelper[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
2025-05-19T17:30:59.5054647Z       at System.Management.Automation.PowerShell.CoreInvoke[TInput,TOutput](PSDataCollection`1 input, PSDataCollection`1 output, PSInvocationSettings settings)
2025-05-19T17:30:59.5055283Z       at System.Management.Automation.PowerShell.Invoke()
2025-05-19T17:30:59.5055951Z       at Microsoft.Azure.Commands.TestFx.EnvironmentSetupHelper.RunPowerShellTest(String[] scripts) in D:\a\_work\1\s\tools\TestFx\EnvironmentSetupHelper.cs:line 501
2025-05-19T17:30:59.5056684Z    Message: The term 'Test-DedicatedHostRestart' is not recognized as a name of a cmdlet, function, script file, or executable program.

Copy link

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@thomascoats
Copy link
Author

@msJinLei Hi, where can I find these logs for the failed test runs? Also, are these the same tests outlined in this documentation? https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/785405/Testing-and-Release

@msJinLei
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

@msJinLei Hi, where can I find these logs for the failed test runs? Also, are these the same tests outlined in this documentation? https://dev.azure.com/msazure/AzureWiki/_wiki/wikis/AzureWiki.wiki/785405/Testing-and-Release

image

Please clicked the linked buttons here

@thomascoats
Copy link
Author

/azp run

Copy link
Contributor

Commenter does not have sufficient privileges for PR 27764 in repo Azure/azure-powershell

@thomascoats
Copy link
Author

@msJinLei will tests rerun automatically? if not, could you trigger another run? the failing tests should be fixed now

@msJinLei
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@msJinLei
Copy link
Contributor

@msJinLei will tests rerun automatically? if not, could you trigger another run? the failing tests should be fixed now

It cannot run automatically for now....Ping me to run it for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants