sql registration fix #27772
Merged
sql registration fix #27772
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
Thank you for your contribution @kumarutkarsh3b2166! We will review the pull request and get back to you soon. |
hiaga
reviewed
May 15, 2025
| @@ -101,6 +101,7 @@ public override void ExecuteCmdlet() | |||
| ResourceIdentifier resourceIdentifier = new ResourceIdentifier(VaultId); | |||
| string vaultName = resourceIdentifier.ResourceName; | |||
| string vaultResourceGroupName = resourceIdentifier.ResourceGroupName; | |||
| string vmResourceGroupName = Container != null ? Container.Name : ResourceId.Split('/')[4]; | |||
There was a problem hiding this comment.
- why are we initializing the vmResourceGroupName = container.Name ?
- )[4] - we shouldn't use the index, we have common funtion to extract resourcegroupname from ARMIDs in general.
There was a problem hiding this comment.
corrected, using vault rg name by default now
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
|
msJinLei
requested changes
May 20, 2025
| @@ -12,6 +12,7 @@ | |||
| </PropertyGroup> | |||
|
|
|||
| <ItemGroup> | |||
| <ProjectReference Include="..\..\Compute\Compute\Compute.csproj" /> | |||
There was a problem hiding this comment.
Please don't reference csproject of other modules in your non-test csproject. You can refer package directly
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
msJinLei
approved these changes
May 21, 2025
hiaga
reviewed
May 21, 2025
| { | ||
| AzureVmWorkloadContainer azureVmWorkloadContainer = (AzureVmWorkloadContainer)Container; | ||
| Dictionary<UriEnums, string> keyValueDict = HelperUtils.ParseUri(azureVmWorkloadContainer.SourceResourceId); | ||
| vmResourceGroupParsed = HelperUtils.GetResourceGroupNameFromId(keyValueDict, ResourceId); |
There was a problem hiding this comment.
pass SourceResourceId here instead of ResourceId
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds check to compare the VM resource group in the list of VMs returned for registration
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.