[Az.RecoveryServices.Backup] Added suspend backup as MUA protected operation #27835
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
There was a problem hiding this comment.
Pull Request Overview
Adds suspend backup as an MUA-protected operation and updates related cmdlets, providers, and tests.
- Documented the new
RetainRecoveryPointsAsPerPolicyoption in ChangeLog. - Updated the Disable-AzRecoveryServicesBackupProtection cmdlet and provider SuspendBackup methods to accept an auxiliary access token and MUA flag.
- Extended PowerShell and C# scenario tests to cover the suspend backup flow.
- Revised the purge date calculation logic in
AzureWorkloadSQLDatabaseProtectedItem.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/RecoveryServices/RecoveryServices/ChangeLog.md | Added MUA-protected RetainRecoveryPointsAsPerPolicy entry |
| src/RecoveryServices/RecoveryServices.Backup/Cmdlets/Item/DisableAzureRmRecoveryServicesBackupProtection.cs | Removed previous validation to enable suspend backup scenario |
| src/RecoveryServices/RecoveryServices.Backup.Test/ScenarioTests/IaasVm/ItemTests.ps1 | Updated VM names and added suspend backup assertions |
| src/RecoveryServices/RecoveryServices.Backup.Test/ScenarioTests/IaasVm/ItemTests.cs | Un-skipped the MUA test case |
| src/RecoveryServices/RecoveryServices.Backup.Providers/Providers/IaasVmPsBackupProvider.cs | Added auxiliaryAccessToken and isMUAProtected parameters |
| src/RecoveryServices/RecoveryServices.Backup.Providers/Providers/AzureWorkloadPsBackupProvider.cs | Same for Azure workload provider |
| src/RecoveryServices/RecoveryServices.Backup.Providers/Providers/AzureFilesPsBackupProvider.cs | Same for Azure files provider |
| src/RecoveryServices/RecoveryServices.Backup.Models/AzureVmWorkloadModels/AzureWorkloadSQLDatabaseProtectedItem.cs | Changed purge date computation to use DateTime.UtcNow |
Comments suppressed due to low confidence (1)
src/RecoveryServices/RecoveryServices.Backup/Cmdlets/Item/DisableAzureRmRecoveryServicesBackupProtection.cs:103
- The variable 'plainToken' is assigned but never used after removing the previous validation block. Consider removing this unused variable to clean up the code.
string plainToken = HelperUtils.GetPlainToken(Token, SecureToken);
Comment on lines
+291
to
+292
| string auxiliaryAccessToken = ProviderData.ContainsKey(ResourceGuardParams.Token) ? (string)ProviderData[ResourceGuardParams.Token] : null; | ||
| bool isMUAProtected = true; |
There was a problem hiding this comment.
This initialization of 'auxiliaryAccessToken' and the 'isMUAProtected' flag is duplicated across multiple providers. Consider refactoring into a shared helper to reduce code duplication.
Suggested change
| string auxiliaryAccessToken = ProviderData.ContainsKey(ResourceGuardParams.Token) ? (string)ProviderData[ResourceGuardParams.Token] : null; | |
| bool isMUAProtected = true; | |
| (string auxiliaryAccessToken, bool isMUAProtected) = GetAuxiliaryAccessTokenAndMUAProtection(); |
Copilot uses AI. Check for mistakes.
| resourceGroupName: resourceGroupName, | ||
| auxiliaryAccessToken, | ||
| isMUAProtected, | ||
| true); |
There was a problem hiding this comment.
[nitpick] Passing a positional boolean literal 'true' makes the argument’s intent unclear. Consider using a named argument or constant to clarify its purpose.
Suggested change
| true); | |
| enableValidation: true); |
Copilot uses AI. Check for mistakes.
...ecoveryServices.Backup.Models/AzureVmWorkloadModels/AzureWorkloadSQLDatabaseProtectedItem.cs
Show resolved
Hide resolved
| @@ -129,6 +129,9 @@ public RestAzureNS.AzureOperationResponse<ProtectedItemResource> SuspendBackup() | |||
| string resourceGroupName = (string)ProviderData[VaultParams.ResourceGroupName]; | |||
|
|
|||
| ItemBase itemBase = (ItemBase)ProviderData[ItemParams.Item]; | |||
|
|
|||
| string auxiliaryAccessToken = ProviderData.ContainsKey(ResourceGuardParams.Token) ? (string)ProviderData[ResourceGuardParams.Token] : null; | |||
There was a problem hiding this comment.
This initialization is duplicated from other providers. Consider refactoring into a shared helper method to reduce code duplication.
Suggested change
| string auxiliaryAccessToken = ProviderData.ContainsKey(ResourceGuardParams.Token) ? (string)ProviderData[ResourceGuardParams.Token] : null; | |
| string auxiliaryAccessToken = GetAuxiliaryAccessToken(); |
Copilot uses AI. Check for mistakes.
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
msJinLei
reviewed
May 26, 2025
| @@ -101,11 +101,7 @@ public override void ExecuteCmdlet() | |||
| string resourceGroupName = resourceIdentifier.ResourceGroupName; | |||
|
|
|||
| string plainToken = HelperUtils.GetPlainToken(Token, SecureToken); | |||
There was a problem hiding this comment.
You can use SecureStringExtensions.ConvertToString
msJinLei
approved these changes
May 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added suspend backup as MUA protected operation i.e. RetainRecoveryPointsAsPerPolicy as MUA protected operation in Disable-AzRecoveryServicesBackupProtection cmdlet.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.