-
Notifications
You must be signed in to change notification settings - Fork 4k
Spelling Fixes #28073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling Fixes #28073
Conversation
Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
Thank you for your contribution @ArieHein! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request applies a series of spelling corrections across comments, error messages, and documentation strings. The changes improve clarity and consistency in user‐facing texts without affecting any programmatic functionality.
- Fixed typos in error messages and help texts in C# files.
- Updated spelling in PowerShell test files and markdown documentation.
- Corrected common misspellings in resource files and scripts.
Reviewed Changes
Copilot reviewed 47 out of 49 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
src/Resources/Resources/RoleAssignments/SetAzureRoleAssignmentCommand.cs | Corrects "formated" to "formatted" in exception message. |
src/Resources/Resources/RoleAssignments/NewAzureRoleAssignmentCommand.cs | Fixes "asignee" to "assigned" and "formated" to "formatted" in help messages and exceptions. |
src/Resources/Resources/Properties/Resources.resx | Fixes "insuficient" to "insufficient". |
src/Resources/Resources/Models.Authorization/AuthorizationClient.cs | Corrects typos "roleDefintion" and "definiton". |
src/Resources/Resources/Gallery/GalleryItem.cs | Corrects "artificat" to "artifact". |
src/Resources/Resources/ActiveDirectory/Models/ActiveDirectoryClient.cs | Corrects "OdataErroException" to "OdataErrorException". |
src/Resources/Resources.Test/ScenarioTests/TemplateSpecTests.ps1 | Updates "existant" to "non-existent". |
src/Resources/Resources.Test/ScenarioTests/TagTests.ps1 | Fixes several typos including "CreeteOrUpdate", "repalce", and "creare". |
src/Resources/Resources.Test/ScenarioTests/RoleDefinitionTests.ps1 | Corrects "Defintion" to "Definition". |
src/Resources/Resources.Test/ScenarioTests/RoleAssignmentTests.ps1 | Fixes "Conect" and "succesfully". |
src/Resources/Resources.Test/ScenarioTests/DeploymentTests.ps1 | Updates "temployment" to "deployment". |
src/Resources/Resources.Test/Mocks/MockDataStore.cs | Corrects "Regeular" to "Regular". |
src/Resources/Resources.Management.Sdk/generate.ps1 | Fixes "exisiting" to "existing". |
src/Resources/Resources.Management.Sdk/Utility/SafeJsonConvertWrapper.cs | Corrects "tempalte" to "template". |
src/Resources/ResourceManager/Utilities/TemplateUtility.cs | Updates "existant" to "non existent". |
src/Resources/ResourceManager/Utilities/ParameterUtility.cs | Fixes "paramterObject" to "parameterObject". |
src/Resources/ResourceManager/SdkModels/TemplateSpecs/PSTemplateSpec.cs | Corrects "PSTempateSpecs" to "PSTemplateSpecs". |
src/Resources/ResourceManager/SdkModels/DeploymentStacks/PSDeploymentStack.cs | Fixes "explict" to "explicit" and "desialize" to "deserialize". |
src/Resources/ResourceManager/SdkExtensions/ResourcesExtensions.cs | Corrects "contruction" to "construction". |
src/Resources/ResourceManager/SdkClient/NewResourceManagerSdkClient.cs | Fixes "fiter" to "filter". |
src/Resources/ResourceManager/SdkClient/DeploymentStacksSdkClient.cs | Corrects "curent" to "current" and "Evaulate" to "Evaluate". |
src/Resources/ResourceManager/Properties/Resources.resx | Fixes "paramater" to "parameter". |
src/Resources/ResourceManager/Implementation/TemplateSpecs/SetAzTemplateSpec.cs | Fixes "inadvertantly" to "inadvertently" and "seperate" to "separate". |
src/Resources/ResourceManager/Implementation/TemplateSpecs/NewAzTemplateSpec.cs | Fixes "inadvertantly" to "inadvertently". |
src/Resources/ResourceManager/Implementation/Resource/GetAzureResourceCmdlet.cs | Corrects "satifying" to "satisfying". |
src/Resources/ResourceManager/Implementation/Lock/ResourceLockManagementCmdletBase.cs | Fixes "parametere" to "parameter" and "databaserName" to "databaseName". |
src/Resources/ResourceManager/Implementation/Lock/GetAzureResourceLockCmdlet.cs | Updates "satifying" to "satisfying". |
src/Resources/ResourceManager/Implementation/CmdletBase/DeploymentStacksCreateCmdletBase.cs | Fixes "popluated" to "populated" and "extration" to "extraction". |
src/Resources/ResourceManager/Implementation/CmdletBase/DeploymentCmdletBase.cs | Fixes "popluated" to "populated" and "extration" to "extraction". |
src/Resources/ResourceManager/Components/TemplateSpecPackagingEngine.cs | Corrects "unneccessary", "heirarchy", and "seperator". |
src/Resources/ResourceManager/Components/HttpClientHelperFactory.cs | Fixes "facotry" to "factory". |
src/Resources/ResourceManager/Components/Constants.cs | Corrects "appliction" to "application". |
src/Resources/Policy.Autorest/test/PolicyObjectPiping.Tests.ps1 | Fixes "pipline" to "pipeline". |
src/Resources/Policy.Autorest/test/ExemptionResourceSelector.Tests.ps1 | Corrects "defintion" to "definition". |
src/Resources/Policy.Autorest/test/Common.ps1 | Updates "peformed" to "performed". |
src/Resources/Policy.Autorest/test/AssignmentResourceSelector.Tests.ps1 | Corrects "defintion" to "definition". |
src/Resources/Policy.Autorest/test/AssignmentOverride.Tests.ps1 | Corrects "defintion" to "definition". |
src/Resources/Policy.Autorest/custom/New-AzPolicyExemption.ps1 | Fixes "remomve" to "remove". |
src/Resources/Policy.Autorest/custom/New-AzPolicyAssignment.ps1 | Corrects "assignement" to "assignment". |
src/Resources/MSGraph.Autorest/examples/Remove-AzADGroupOwner.md | Fixes "onwer" to "owner". |
src/Resources/MSGraph.Autorest/examples/New-AzADServicePrincipal.md | Corrects "pincipal" to "principal". |
src/Resources/MSGraph.Autorest/docs/Update-AzADUser.md | Fixes "speci./fied" to "specified". |
src/Resources/MSGraph.Autorest/docs/Remove-AzADGroupOwner.md | Corrects "onwer" to "owner". |
src/Resources/MSGraph.Autorest/docs/New-AzADServicePrincipal.md | Corrects "pincipal" to "principal". |
src/Resources/MSGraph.Autorest/custom/Update-AzADUser.ps1 | Fixes "speci./fied" to "specified". |
src/Resources/Authorization.Autorest/examples/New-AzRoleEligibilityScheduleRequest.md | Corrects "eligibile" to "eligible" in both examples. |
src/Resources/Authorization.Autorest/docs/New-AzRoleEligibilityScheduleRequest.md | Corrects "eligibile" to "eligible" in both examples. |
Files not reviewed (2)
- src/Resources/ResourceManager/Properties/Resources.Designer.cs: Language not supported
- src/Resources/Resources/Properties/Resources.Designer.cs: Language not supported
Comments suppressed due to low confidence (59)
src/Resources/ResourceManager/Properties/Resources.resx:367
- Correct spelling 'paramater' to 'parameter'.
<value>Unregistering provider ...</value>
src/Resources/Resources/RoleAssignments/SetAzureRoleAssignmentCommand.cs:71
- Correct spelling 'formated' to 'formatted'.
WriteVerbose("Deserializing the input role definition failed.");
src/Resources/Resources/RoleAssignments/NewAzureRoleAssignmentCommand.cs:215
- Correct spelling 'asignee' to 'assigned' in help message.
[Parameter(Mandatory = false, ValueFromPipelineByPropertyName = true, ParameterSetName = ParameterSet.Empty,
src/Resources/Resources/RoleAssignments/NewAzureRoleAssignmentCommand.cs:287
- Correct spelling 'formated' to 'formatted'.
WriteVerbose("Deserializing the input role assignment failed.");
src/Resources/Resources/Properties/Resources.resx:456
- Correct spelling 'insuficient' to 'insufficient'.
<data name="NotAuthorizedInGraph" xml:space="preserve">
src/Resources/Resources/Models.Authorization/AuthorizationClient.cs:399
- Correct spelling 'roleDefintion' to 'roleDefinition'.
{
src/Resources/Resources/Models.Authorization/AuthorizationClient.cs:471
- Correct spelling 'definiton' to 'definition'.
/// Updates a role definition.
src/Resources/Resources/ActiveDirectory/Models/ActiveDirectoryClient.cs:250
- Correct spelling 'OdataErroException' to 'OdataErrorException'.
{
src/Resources/Resources.Test/ScenarioTests/TemplateSpecTests.ps1:249
- Correct spelling 'existant' to 'non-existent'.
.SYNOPSIS
src/Resources/Resources.Test/ScenarioTests/TagTests.ps1:129
- Correct spelling 'repalce' to 'replace'.
{
src/Resources/Resources.Test/ScenarioTests/TagTests.ps1:454
- Correct spelling 'creare' to 'create'.
.SYNOPSIS
src/Resources/Resources.Test/ScenarioTests/RoleAssignmentTests.ps1:645
- Correct spelling 'Conect' to 'Connect'.
{
src/Resources/Resources.Test/ScenarioTests/RoleAssignmentTests.ps1:697
- Correct spelling 'succesfully' to 'successfully'.
#Then
src/Resources/Resources.Test/ScenarioTests/RoleAssignmentTests.ps1:726
- Correct spelling 'succesfully' to 'successfully'.
$assignment = New-AzRoleAssignmentWithId -ObjectId $PrincipalId -Scope $Scope -RoleDefinitionId $RoleDefinitionId -Description $Description -Condition $Condition -roleAssignmentId 734de5f5-c680-41c0-8beb-67b98c3539d2
src/Resources/Resources.Test/ScenarioTests/DeploymentTests.ps1:421
- Correct spelling 'temployment' to 'deployment'.
.SYNOPSIS
src/Resources/Resources.Test/Mocks/MockDataStore.cs:308
- Correct spelling 'Regeular' to 'Regular'.
/// <param name="wildcard">Asterisk based pattern</param>
src/Resources/Resources.Management.Sdk/generate.ps1:3
- Correct spelling 'exisiting' to 'existing'.
# and copy these new set of files to the main Generated folder. This way existing files will not be deleted.
src/Resources/ResourceManager/Utilities/TemplateUtility.cs:146
- Correct spelling 'existant' to 'non existent'.
// If the templateSpec resourceID is pointing to a non existent resource
src/Resources/ResourceManager/Utilities/ParameterUtility.cs:34
- Correct spelling 'paramterObject' to 'parameterObject'.
/// <summary>
src/Resources/ResourceManager/SdkModels/TemplateSpecs/PSTemplateSpec.cs:121
- Correct spelling 'PSTempateSpecs' to 'PSTemplateSpecs'.
/// <summary>
src/Resources/ResourceManager/SdkModels/DeploymentStacks/PSDeploymentStack.cs:251
- Correct spelling 'explict' to 'explicit'.
/// custom output formatting. It also enables type population for parameters that are not returned with an explicit type.
src/Resources/ResourceManager/SdkModels/DeploymentStacks/PSDeploymentStack.cs:284
- Correct spelling 'desialize' to 'deserialize'.
// Attempt to deserialize the DeploymentVariable:
src/Resources/ResourceManager/SdkExtensions/ResourcesExtensions.cs:157
- Correct spelling 'contruction' to 'construction'.
// TODO: This function and the above tags construction function could be combined into one function.
src/Resources/ResourceManager/SdkClient/NewResourceManagerSdkClient.cs:1024
- Correct spelling 'fiter' to 'filter'.
/// <summary>
src/Resources/ResourceManager/SdkClient/DeploymentStacksSdkClient.cs:545
- Correct spelling 'curent' to 'current'.
if (deleteResponse.Response.StatusCode == System.Net.HttpStatusCode.NoContent)
src/Resources/ResourceManager/SdkClient/DeploymentStacksSdkClient.cs:846
- Correct spelling 'Evaulate' to 'Evaluate'.
// Evaluate Template:
src/Resources/ResourceManager/Implementation/TemplateSpecs/SetAzTemplateSpec.cs:218
- Correct spelling 'inadvertantly' to 'inadvertently'.
{
src/Resources/ResourceManager/Implementation/TemplateSpecs/NewAzTemplateSpec.cs:177
- Correct spelling 'inadvertantly' to 'inadvertently'.
}
src/Resources/ResourceManager/Implementation/Resource/GetAzureResourceCmdlet.cs:45
- Correct spelling 'satifying' to 'satisfying'.
/// <summary>
src/Resources/ResourceManager/Implementation/Lock/ResourceLockManagementCmdletBase.cs:51
- Correct spelling 'parametere' to 'parameter'.
/// <summary>
src/Resources/ResourceManager/Implementation/Lock/ResourceLockManagementCmdletBase.cs:63
- Correct spelling 'databaserName' to 'databaseName'.
/// </summary>
src/Resources/ResourceManager/Implementation/Lock/GetAzureResourceLockCmdlet.cs:32
- Correct spelling 'satifying' to 'satisfying'.
/// Contains the errors that encountered while satisfying the request.
src/Resources/ResourceManager/Implementation/CmdletBase/DeploymentStacksCreateCmdletBase.cs:186
- Correct spelling 'popluated' to 'populated' and 'extration' to 'extraction'.
/// Runs on every tab complete and before processing on execution.
src/Resources/ResourceManager/Implementation/CmdletBase/DeploymentCmdletBase.cs:192
- Correct spelling 'popluated' to 'populated' and 'extration' to 'extraction'.
/// Runs on every tab complete and before processing on execution.
src/Resources/ResourceManager/Components/TemplateSpecPackagingEngine.cs:99
- Correct spelling 'unneccessary' to 'unnecessary'.
{
src/Resources/ResourceManager/Components/TemplateSpecPackagingEngine.cs:163
- Correct spelling 'heirarchy' to 'hierarchy'.
// hierarchy. We won't allow such references for security purposes:
src/Resources/ResourceManager/Components/TemplateSpecPackagingEngine.cs:249
- Correct spelling 'heirarchy' to 'hierarchy'.
$"Unable to unpack artifact '{artifact.Path}' because it would create a file " +
src/Resources/ResourceManager/Components/TemplateSpecPackagingEngine.cs:391
- Correct spelling 'seperator' to 'separator'.
// Ensure we have a trailing separator
src/Resources/ResourceManager/Components/HttpClientHelperFactory.cs:26
- Correct spelling 'facotry' to 'factory'.
/// <summary>
src/Resources/ResourceManager/Components/Constants.cs:77
- Correct spelling 'appliction' to 'application'.
/// <summary>
src/Resources/MSGraph.Autorest/docs/Remove-AzADGroupOwner.md:33
- Correct spelling 'onwer' to 'owner'.
Notice: 1.this cmdlet does not delete the owner directory object.
src/Resources/MSGraph.Autorest/custom/Update-AzADUser.ps1:74
- Correct spelling 'speci./fied' to 'specified'.
# It can be updated, but the user will be required to change the password on the next login.
src/Resources/Authorization.Autorest/examples/New-AzRoleEligibilityScheduleRequest.md:1
- Correct spelling 'eligibile' to 'eligible'.
### Example 1: Create a new role eligible schedule request as Admin
src/Resources/Authorization.Autorest/examples/New-AzRoleEligibilityScheduleRequest.md:17
- Correct spelling 'eligibile' to 'eligible'.
### Example 2: Remove a role eligible schedule request as Admin
@@ -223,7 +223,7 @@ public string Summary | |||
|
|||
/// <summary> | |||
/// Optional. Gets or sets Azure Portal Uder Interface Definition |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct spelling 'artificat' to 'artifact'.
/// Optional. Gets or sets Azure Portal Uder Interface Definition | |
/// Optional. Gets or sets Azure Portal User Interface Definition |
Copilot uses AI. Check for mistakes.
@@ -14,7 +14,7 @@ | |||
|
|||
<# | |||
.SYNOPSIS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct spelling 'CreeteOrUpdate' to 'CreateOrUpdate'.
Copilot uses AI. Check for mistakes.
@@ -3,7 +3,7 @@ | |||
// license information. | |||
// |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct spelling 'tempalte' to 'template'.
Copilot uses AI. Check for mistakes.
/azp run azure-powershell - security-tools |
Azure Pipelines successfully started running 1 pipeline(s). |
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Hi @ArieHein, I'm going to close this PR since it can't pass the CI.
|
Description
This does spelling fixes in codebase files that are either:
in comments.
in displayable strings.
There are NO other changes to programmatic aspects or code behavior.
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.md
and reviewed the following information:ChangeLog.md
file(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
.## Upcoming Release
header in the past tense.ChangeLog.md
if no new release is required, such as fixing test case only.