Skip to content

Conversation

Pan-Qi
Copy link
Contributor

@Pan-Qi Pan-Qi commented Jul 31, 2025

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status.

@Pan-Qi Pan-Qi marked this pull request as ready for review August 6, 2025 13:46
@Copilot Copilot AI review requested due to automatic review settings August 6, 2025 13:46
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the Azure ResourceMover PowerShell module from AutoRest v3 to AutoRest v4. The migration involves updating model type namespaces, correcting parameter types, adding new parameter sets, and resolving breaking changes in the generated code.

Key Changes

  • Updated model type namespaces from Microsoft.Azure.PowerShell.Cmdlets.ResourceMover.Models.Api20230801 to Microsoft.Azure.PowerShell.Cmdlets.ResourceMover.Models
  • Replaced strongly-typed enum parameters with string parameters for flexibility
  • Added new parameter sets and JSON-based input methods for various cmdlets

Reviewed Changes

Copilot reviewed 79 out of 79 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
tools/StaticAnalysis/Exceptions/Az.ResourceMover/BreakingChangeIssues.csv Documents breaking changes and exceptions for the v4 migration
src/ResourceMover/ResourceMover/help/*.md Updates help documentation with corrected type names and parameter sets
src/ResourceMover/ResourceMover.Autorest/test/*.ps1 Updates test files to use new parameter syntax
src/ResourceMover/ResourceMover.Autorest/examples/*.md Updates example documentation with corrected type references
src/ResourceMover/ResourceMover.Autorest/custom/csharp/*.cs Updates C# custom code with new model namespaces

## EXAMPLES

### Example 1: Validate the dependenciesss before remove of the Move Resources from Move Collection
### Example 1: Validate the dependecies before remove of the Move Resources from Move Collection
Copy link

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in 'dependecies'. It should be 'dependencies'.

Suggested change
### Example 1: Validate the dependecies before remove of the Move Resources from Move Collection
### Example 1: Validate the dependencies before remove of the Move Resources from Move Collection

Copilot uses AI. Check for mistakes.

```

Validate the dependencies before remove of the move resources from Move Collection.
Validate the dependecies before remove of the move resources from Move Collection.
Copy link

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in 'dependecies'. It should be 'dependencies'.

Suggested change
Validate the dependecies before remove of the move resources from Move Collection.
Validate the dependencies before remove of the move resources from Move Collection.

Copilot uses AI. Check for mistakes.

## EXAMPLES

### Example 1: Validate the dependencies before remove of the Move Resources from Move Collection
### Example 1: Validate the dependecies before remove of the Move Resources from Move Collection
Copy link

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in 'dependecies'. It should be 'dependencies'.

Suggested change
### Example 1: Validate the dependecies before remove of the Move Resources from Move Collection
### Example 1: Validate the dependencies before remove of the Move Resources from Move Collection

Copilot uses AI. Check for mistakes.

```

Validate the dependencies before remove of the move resources from Move Collection.
Validate the dependecies before remove of the move resources from Move Collection.
Copy link

Copilot AI Aug 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a spelling error in 'dependecies'. It should be 'dependencies'.

Suggested change
Validate the dependecies before remove of the move resources from Move Collection.
Validate the dependencies before remove of the move resources from Move Collection.

Copilot uses AI. Check for mistakes.

@Pan-Qi Pan-Qi added the Contains Breaking Change This PR contains breaking change label Aug 14, 2025
Copy link

To the author of the pull request,
This PR was labeled "Breaking Change Release" because it contains breaking changes.

  • According to our policy, breaking changes can only take place during major release and they must be preannounced.
  • Please follow our guide on the detailed steps.
  • Required: Please fill in the task below to facilitate our contact,you will receive notifications related to breaking changes.

@isra-fel isra-fel added the autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 label Oct 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autorest v4 migration pr migrating module from generated by autorest.powershell v3 to v4 Contains Breaking Change This PR contains breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants