Monitoring expedite changes v2 #28531
Conversation
…e parameter - Added new parameter -Expedite to expedite the operation of a replicating server. - Updated documentation to include usage examples for the -Expedite parameter. - Modified existing examples to reflect new project and resource group names. - Enhanced output formatting in examples to provide clearer information. - Added tests for the new -Expedite functionality. - Updated ChangeLog to document the addition of the -Expedite feature.
| Thanks for your contribution! The pull request validation has started. Please revisit this comment for updated status. |
|
Thank you for your contribution @ankitbaluni123! We will review the pull request and get back to you soon. |
There was a problem hiding this comment.
Pull Request Overview
This PR enhances the Get-AzMigrateServerMigrationStatus cmdlet by adding support for the -Expedite parameter, which provides detailed resource utilization information and recommendations for optimizing server migration performance.
Key changes:
- Added a new
GetByPrioritiseServerparameter set with the-Expediteswitch parameter - Enhanced output to include resource sharing analysis and utilization recommendations
- Updated documentation and examples to demonstrate the new expedite functionality
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/Migrate/Migrate/help/Get-AzMigrateServerMigrationStatus.md |
Updated help documentation with new parameter set, examples, and parameter descriptions for the -Expedite feature |
src/Migrate/Migrate/ChangeLog.md |
Added changelog entry documenting the enhancement to support the -Expedite parameter |
src/Migrate/Migrate.Autorest/test/Get-AzMigrateServerMigrationStatus.Tests.ps1 |
Added test stub for the new GetByPrioritiseServer parameter set |
src/Migrate/Migrate.Autorest/custom/Get-AzMigrateServerMigrationStatus.ps1 |
Implemented the core expedite functionality with resource analysis and recommendations logic |
| Multiple documentation files | Updated path references from ..\ to ../ for consistency |
Comments suppressed due to low confidence (1)
| if ($ReplicationMigrationItem.MigrationState -eq "MigrationFailed") { | ||
| return "Migration Failed" | ||
| } | ||
|
|
||
| if ($ReplicationMigrationItem.MigrationState -match "MigrationInProgress" -and $ReplicationMigrationItem.migrationProgressPercentage -eq $null) { | ||
| return "FinalDeltaReplication Queued" | ||
| elseif ($ReplicationMigrationItem.MigrationState -match "InitialSeedingFailed") { | ||
| return "InitialReplication Failed" | ||
| } | ||
|
|
||
| if ($ReplicationMigrationItem.MigrationState -eq "MigrationSucceeded") { | ||
| return "Migration Completed" | ||
| if ([string]::IsNullOrEmpty($State)) { | ||
| return $ReplicationMigrationItem.MigrationState | ||
| } |
There was a problem hiding this comment.
The logic flow has been altered in a way that could cause incorrect behavior. The original commented-out logic handled multiple migration states, but the new implementation only checks for specific failure states before falling back to the raw migration state. This could result in incomplete state mapping for non-failure scenarios.
Copilot uses AI. Check for mistakes.
| [assembly: System.Reflection.AssemblyFileVersionAttribute("0.1.0.0")] | ||
| [assembly: System.Reflection.AssemblyVersionAttribute("0.1.0.0")] |
There was a problem hiding this comment.
The assembly version has been downgraded from "2.8.0" to "0.1.0.0", which would be a breaking change and inconsistent with the versioning strategy. This appears to be an unintended change that should be reverted.
| [assembly: System.Reflection.AssemblyFileVersionAttribute("0.1.0.0")] | |
| [assembly: System.Reflection.AssemblyVersionAttribute("0.1.0.0")] | |
| [assembly: System.Reflection.AssemblyFileVersionAttribute("2.8.0.0")] | |
| [assembly: System.Reflection.AssemblyVersionAttribute("2.8.0.0")] |
Copilot uses AI. Check for mistakes.
| if ($null -ne $Value) { | ||
| return "$Value %" | ||
| } else { | ||
| return "-" | ||
| } |
There was a problem hiding this comment.
The condition has been changed from checking both $Value -ne $null -and $Value -ne 0 to only $null -ne $Value. This means that zero values will now display as "0 %" instead of "-", which may not be the intended behavior for percentage displays where zero might be considered as "no data".
Copilot uses AI. Check for mistakes.
1 participant
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.