Skip to content

Update HDInsight Linked Service Swagger definition with new payload f… #36664

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nakul16168
Copy link
Contributor

…ields: {clusterAuthType, credential}

Choose a PR Template

Switch to "Preview" on this description then select one of the choices below.

Click here to open a PR for a Data Plane API.

Click here to open a PR for a Control Plane (ARM) API.

Click here to open a PR for only SDK configuration.

Copy link

github-actions bot commented Aug 14, 2025

Next Steps to Merge

Next steps that must be taken to merge this PR:
  • ❌ This PR targets either the main branch of the public specs repo or the RPSaaSMaster branch of the private specs repo. These branches are not intended for iterative development. Therefore, you must acknowledge you understand that after this PR is merged, the APIs are considered shipped to Azure customers. Any further attempts at in-place modifications to the APIs will be subject to Azure's versioning and breaking change policies. Additionally, for control plane APIs, you must acknowledge that you are following all the best practices documented by ARM at aka.ms/armapibestpractices. If you do intend to release the APIs to your customers by merging this PR, add the PublishToCustomers label to your PR in acknowledgement of the above. Otherwise, retarget this PR onto a feature branch, i.e. with prefix release- (see aka.ms/azsdk/api-versions#release--branches).
  • ❌ This PR is in purview of the ARM review (label: ARMReview). This PR must get ARMSignedOff label from an ARM reviewer.
    This PR is awaiting ARM reviewer feedback (label: WaitForARMFeedback).
    To learn when this PR will get reviewed, see ARM review queue at aka.ms/azsdk/pr-arm-review
    For details of the ARM review, see aka.ms/azsdk/pr-arm-review


Comment generated by summarize-checks workflow run.

@github-actions github-actions bot added ARMReview data-plane resource-manager WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required and removed WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required labels Aug 14, 2025
Copy link

github-actions bot commented Aug 14, 2025

API Change Check

APIView identified API level changes in this PR and created the following API reviews

Language API Review for Package
Swagger Microsoft.DataFactory
Swagger Microsoft.Synapse
Go sdk/resourcemanager/datafactory/armdatafactory
Java com.azure.resourcemanager:azure-resourcemanager-datafactory
JavaScript @azure/arm-datafactory
C# Azure.ResourceManager.DataFactory

@JeffreyRichter JeffreyRichter added the Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 label Aug 14, 2025
@github-actions github-actions bot added WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required and removed NotReadyForARMReview labels Aug 14, 2025
@sandipsh
Copy link
Contributor

@nakul16168 The Breaking Change validation for this PR flagged OAD violations during same-version comparison of LinkedService.json. Based on the report, these appear to be additions of properties. So, please confirm / justify that.

Given this, VersioningReviewRequired label seems appropriate. In that case:
Here’s the correct order of operations:

  1. Versioning Review First
    The reviewer must evaluate whether the changes are backward-compatible.
    If the changes are safe (e.g., adding optional fields, improving descriptions), the label can be removed.
    If the changes are not safe, the reviewer should request the author to:
  • Create a new API version.
  • Or justify why the change is safe under existing version.
  1. ARM Signoff Comes After
    Do not request or apply ARMReviewSignedOff until the versioning review is complete and the label is removed.
    ARM reviewers rely on the versioning review to ensure the API versioning strategy is sound before signing off.
    Once confirmed, the label can be removed, and ARM reviewers can proceed with their review.

@mentat9 for awareness.

@sandipsh sandipsh removed the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 16, 2025
@github-actions github-actions bot added the WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required label Aug 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ARMReview BreakingChange-JavaScript-Sdk data-plane resource-manager Versioning-Approved-BugFix https://github.com/Azure/azure-sdk-tools/issues/6374 VersioningReviewRequired <valid label in PR review process>add this label when versioning review is required WaitForARMFeedback <valid label in PR review process> add this label when ARM review is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants