[FEATURE REQ]Unable to unit tests GeocodingResponse and sub classes

[FranckSix]

Library name

Azure.Maps.Search

Please describe the feature.

I everybody,

I use Moq for unit tests and I try to mock MapsSearchClient.GetGeocodingAsync. But I am unable to fake the GeocodingResponse class all of its constructors ar internal and no interface on the class. The same problem for subclasses of GeocodingResponse.

On assembly Azure.Maps.Search.Models:

• Azure.Maps.Search.Models.FeaturesItem
• Azure.Maps.Search.Models.FeaturesItemProperties
• Azure.Maps.Search.Models.Address
• Intersection
• AddressAdminDistrictsItem
• AddressCountryRegion
• GeocodePointsItem

I see the MapsSearchModelFactory , may help but missing the FeaturesItem generator.

I can't apply the recommendations from the documentation Mocking

Thanks!

[github-actions]

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @dubiety.

[github-actions]

Hi @FranckSix, I'm an AI Support assistant here to help with your issue. While the Azure SDK team reviews your request, I wanted to provide some possible tips and documentation that might help you in the meantime.

• The Azure SDK libraries are designed with testability in mind by exposing model factories (e.g. SecretModelFactory in other libraries) to create responses and models for mocking. You may leverage similar patterns for Geocoding-related models.
• Please review our guidance on unit testing and mocking with the Azure SDK for .NET which explains how to work with types whose constructors are internal: Unit testing and mocking with the Azure SDK for .NET.
• Existing model factory features in the SDK (such as MapsSearchModelFactory) are intended to enable creation of service response objects. Though a generator for FeaturesItem isn’t available, the approach is consistent with our design for other mixtures of internal constructors.
• Additional examples demonstrating how to mock client methods and responses can be found in our core guidance on mocking: Mocking client types using Azure.Core.

The Azure SDK team will respond to your issue shortly. I hope these suggestions are helpful in the meantime. If this comment helped you, please give it a 👍. If the suggestion was not helpful or incorrect, please give it a 👎. Your feedback helps us improve!

[Pieeer1]

ugh I just ran into the same issue ironically. Here is the example implementation for a full sample.

public class MockValidMapsSearchClient : MapsSearchClient
{
    public override Task<Response<GeocodingResponse>> GetReverseGeocodingAsync(GeoPosition coordinates, ReverseGeocodingQuery? options = null, CancellationToken cancellationToken = default)
    {
        var featureProperties = MapsSearchModelFactory.FeaturesItemProperties(null, null, [], MapsSearchModelFactory.Address(
            "123 a street",
            "some locality",
            "some neighborhood",
            [MapsSearchModelFactory.AddressAdminDistrictsItem("a name", "a second name")],
            "some postal code",
            MapsSearchModelFactory.AddressCountryRegion("some iso", "some name"),
            "some formatted address",
            "some street name",
            "some street number",
            MapsSearchModelFactory.Intersection("some base street", "some secondary street", "some secondary street 2", "some other intersection type", "some display nmae")));
        return Task.FromResult(Response.FromValue(MapsSearchModelFactory.GeocodingResponse(FeatureCollectionEnum.FeatureCollection, new List<FeaturesItem>()
        { 
            MapsSearchModelFactory.FeaturesItem() /*DOES NOT EXIST*/,
        }), new MockResponse()));
    }
}