From 0bc1b6caca2aeeaf2f3d31a027d2a87cd33e5d41 Mon Sep 17 00:00:00 2001 From: Madalyn Redding Date: Mon, 9 Jun 2025 13:27:55 -0700 Subject: [PATCH 01/10] initial commit --- .github/prompts/fix-aot-warnings.prompt.md | 0 eng/Directory.Build.Common.targets | 6 +++++- eng/scripts/Language-Settings.ps1 | 20 ++++++++++++++----- .../Baseline-Existing-AOT-Warnings.ps1 | 0 .../src/Azure.Data.AppConfiguration.csproj | 2 ++ sdk/appconfiguration/ci.yml | 6 +----- .../src/Microsoft.Extensions.Azure.csproj | 3 +++ sdk/extensions/ci.yml | 4 ---- .../src/Azure.Identity.Broker.csproj | 2 ++ .../Azure.Identity/src/Azure.Identity.csproj | 2 ++ sdk/identity/ci.yml | 3 --- .../Azure.Security.KeyVault.Secrets.csproj | 2 ++ sdk/keyvault/ci.yml | 4 ---- ...zure.Monitor.OpenTelemetry.Exporter.csproj | 2 ++ sdk/monitor/ci.yml | 6 +----- sdk/servicebus/ci.yml | 1 - sdk/storage/ci.yml | 4 ---- 17 files changed, 35 insertions(+), 32 deletions(-) create mode 100644 .github/prompts/fix-aot-warnings.prompt.md create mode 100644 eng/scripts/compatibility/Baseline-Existing-AOT-Warnings.ps1 diff --git a/.github/prompts/fix-aot-warnings.prompt.md b/.github/prompts/fix-aot-warnings.prompt.md new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/eng/Directory.Build.Common.targets b/eng/Directory.Build.Common.targets index 080f8d584f1c..5b014cd1f3bf 100644 --- a/eng/Directory.Build.Common.targets +++ b/eng/Directory.Build.Common.targets @@ -380,9 +380,13 @@ + + + false + true - + diff --git a/eng/scripts/Language-Settings.ps1 b/eng/scripts/Language-Settings.ps1 index 3a17657c1986..bb1539a60914 100644 --- a/eng/scripts/Language-Settings.ps1 +++ b/eng/scripts/Language-Settings.ps1 @@ -33,7 +33,7 @@ function Get-AllPackageInfoFromRepo($serviceDirectory) continue } - $pkgPath, $serviceDirectory, $pkgName, $pkgVersion, $sdkType, $isNewSdk, $dllFolder = $projectOutput.Split("' '", [System.StringSplitOptions]::RemoveEmptyEntries).Trim("' ") + $pkgPath, $serviceDirectory, $pkgName, $pkgVersion, $sdkType, $isNewSdk, $dllFolder, $isAotCompatible = $projectOutput.Split("' '", [System.StringSplitOptions]::RemoveEmptyEntries).Trim("' ") if(!(Test-Path $pkgPath)) { Write-Host "Parsed package path `$pkgPath` does not exist so skipping the package line '$projectOutput'." continue @@ -51,10 +51,11 @@ function Get-AllPackageInfoFromRepo($serviceDirectory) if ($ciProps) { # CheckAOTCompat is opt _in_, so we should default to false if not specified $shouldAot = GetValueSafelyFrom-Yaml $ciProps.ParsedYml @("extends", "parameters", "CheckAOTCompat") + $aotFromYaml = $false if ($null -ne $shouldAot) { $parsedBool = $null if ([bool]::TryParse($shouldAot, [ref]$parsedBool)) { - $pkgProp.CIParameters["CheckAOTCompat"] = $parsedBool + $aotFromYaml = $parsedBool } # when AOTCompat is true, there is an additional parameter we need to retrieve @@ -64,8 +65,15 @@ function Get-AllPackageInfoFromRepo($serviceDirectory) $pkgProp.CIParameters["AOTTestInputs"] = $aotArtifacts } } - else { - $pkgProp.CIParameters["CheckAOTCompat"] = $false + + # Check if the project has IsAotCompatible property set to true + $aotFromProject = ($isAotCompatible -eq 'true') + + # AOT should run if EITHER the CI YAML parameter is true OR the project has IsAotCompatible set to true + $pkgProp.CIParameters["CheckAOTCompat"] = ($aotFromYaml -or $aotFromProject) + + if (-not $aotFromYaml -and $aotFromProject) { + # If AOT is enabled from project but not from YAML, ensure we have an empty AOTTestInputs array $pkgProp.CIParameters["AOTTestInputs"] = @() } @@ -84,7 +92,9 @@ function Get-AllPackageInfoFromRepo($serviceDirectory) # if the package isn't associated with a CI.yml, we still want to set the defaults values for these parameters # so that when we are checking the package set for which need to "Build Snippets" or "Check AOT" we won't crash due to the property being null else { - $pkgProp.CIParameters["CheckAOTCompat"] = $false + # Check if the project has IsAotCompatible property set to true even if there's no CI.yml + $shouldAotFromProject = ($isAotCompatible -eq 'true') + $pkgProp.CIParameters["CheckAOTCompat"] = $shouldAotFromProject $pkgProp.CIParameters["AOTTestInputs"] = @() $pkgProp.CIParameters["BuildSnippets"] = $true } diff --git a/eng/scripts/compatibility/Baseline-Existing-AOT-Warnings.ps1 b/eng/scripts/compatibility/Baseline-Existing-AOT-Warnings.ps1 new file mode 100644 index 000000000000..e69de29bb2d1 diff --git a/sdk/appconfiguration/Azure.Data.AppConfiguration/src/Azure.Data.AppConfiguration.csproj b/sdk/appconfiguration/Azure.Data.AppConfiguration/src/Azure.Data.AppConfiguration.csproj index d24da5451425..9645d2ca7dd2 100644 --- a/sdk/appconfiguration/Azure.Data.AppConfiguration/src/Azure.Data.AppConfiguration.csproj +++ b/sdk/appconfiguration/Azure.Data.AppConfiguration/src/Azure.Data.AppConfiguration.csproj @@ -9,6 +9,8 @@ Microsoft Azure Application Configuration;Data;AppConfig;$(PackageCommonTags) $(RequiredTargetFrameworks) $(NoWarn);3021; + true + true true diff --git a/sdk/appconfiguration/ci.yml b/sdk/appconfiguration/ci.yml index d7b94a65564a..c056d5139256 100644 --- a/sdk/appconfiguration/ci.yml +++ b/sdk/appconfiguration/ci.yml @@ -34,8 +34,4 @@ extends: ArtifactName: packages Artifacts: - name: Azure.Data.AppConfiguration - safeName: AzureDataAppConfiguration - CheckAOTCompat: true - AOTTestInputs: - - ArtifactName: Azure.Data.AppConfiguration - ExpectedWarningsFilepath: None + safeName: AzureDataAppConfiguration \ No newline at end of file diff --git a/sdk/extensions/Microsoft.Extensions.Azure/src/Microsoft.Extensions.Azure.csproj b/sdk/extensions/Microsoft.Extensions.Azure/src/Microsoft.Extensions.Azure.csproj index 5a89456fd384..d8f4a42e713c 100644 --- a/sdk/extensions/Microsoft.Extensions.Azure/src/Microsoft.Extensions.Azure.csproj +++ b/sdk/extensions/Microsoft.Extensions.Azure/src/Microsoft.Extensions.Azure.csproj @@ -11,6 +11,9 @@ false + + true + true true false diff --git a/sdk/extensions/ci.yml b/sdk/extensions/ci.yml index 12b68ad7c818..813360f62cb3 100644 --- a/sdk/extensions/ci.yml +++ b/sdk/extensions/ci.yml @@ -37,7 +37,3 @@ extends: safeName: AzureExtensionsAspNetCoreConfigurationSecrets - name: Microsoft.Azure.WebJobs.Extensions.Clients safeName: MicrosoftAzureWebJobsExtensionsClients - CheckAOTCompat: true - AOTTestInputs: - - ArtifactName: Microsoft.Extensions.Azure - ExpectedWarningsFilepath: None diff --git a/sdk/identity/Azure.Identity.Broker/src/Azure.Identity.Broker.csproj b/sdk/identity/Azure.Identity.Broker/src/Azure.Identity.Broker.csproj index ced189bfedcb..aad66af2a8f3 100644 --- a/sdk/identity/Azure.Identity.Broker/src/Azure.Identity.Broker.csproj +++ b/sdk/identity/Azure.Identity.Broker/src/Azure.Identity.Broker.csproj @@ -10,6 +10,8 @@ $(RequiredTargetFrameworks);net8.0 $(RequiredTargetFrameworks);net8.0 $(NoWarn);3021 + true + true true diff --git a/sdk/identity/Azure.Identity/src/Azure.Identity.csproj b/sdk/identity/Azure.Identity/src/Azure.Identity.csproj index 342318bfe6fe..33435b284ef1 100644 --- a/sdk/identity/Azure.Identity/src/Azure.Identity.csproj +++ b/sdk/identity/Azure.Identity/src/Azure.Identity.csproj @@ -8,6 +8,8 @@ Microsoft Azure Identity;$(PackageCommonTags) $(RequiredTargetFrameworks) $(NoWarn);3021;AZC0011 + true + true true diff --git a/sdk/identity/ci.yml b/sdk/identity/ci.yml index 1f2b510c28c8..42f55e8294cb 100644 --- a/sdk/identity/ci.yml +++ b/sdk/identity/ci.yml @@ -31,9 +31,6 @@ extends: safeName: AzureIdentity - name: Azure.Identity.Broker safeName: AzureIdentityBroker - CheckAOTCompat: true AOTTestInputs: - - ArtifactName: Azure.Identity - ExpectedWarningsFilepath: None - ArtifactName: Azure.Identity.Broker ExpectedWarningsFilepath: "Azure.Identity.Broker/tests/compatibility/ExpectedWarnings.txt" diff --git a/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/Azure.Security.KeyVault.Secrets.csproj b/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/Azure.Security.KeyVault.Secrets.csproj index dc6bf7ca0d8f..97bc265d336c 100644 --- a/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/Azure.Security.KeyVault.Secrets.csproj +++ b/sdk/keyvault/Azure.Security.KeyVault.Secrets/src/Azure.Security.KeyVault.Secrets.csproj @@ -10,6 +10,8 @@ $(RequiredTargetFrameworks) $(NoWarn);3021 + true + true true true diff --git a/sdk/keyvault/ci.yml b/sdk/keyvault/ci.yml index 231e208ced50..4a21586d78be 100644 --- a/sdk/keyvault/ci.yml +++ b/sdk/keyvault/ci.yml @@ -47,7 +47,3 @@ extends: safeName: AzureSecurityKeyVaultSecrets triggeringPaths: - Azure.Security.Keyvault.Shared - CheckAOTCompat: true - AOTTestInputs: - - ArtifactName: Azure.Security.KeyVault.Secrets - ExpectedWarningsFilepath: None diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Azure.Monitor.OpenTelemetry.Exporter.csproj b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Azure.Monitor.OpenTelemetry.Exporter.csproj index ebac0be3b1c8..c7b70ccc1ce0 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Azure.Monitor.OpenTelemetry.Exporter.csproj +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Azure.Monitor.OpenTelemetry.Exporter.csproj @@ -9,6 +9,8 @@ $(RequiredTargetFrameworks) true $(DefineConstants);AZURE_MONITOR_EXPORTER; + true + true diff --git a/sdk/monitor/ci.yml b/sdk/monitor/ci.yml index c930cb9bd5ca..89a0bb1590e8 100644 --- a/sdk/monitor/ci.yml +++ b/sdk/monitor/ci.yml @@ -46,8 +46,4 @@ extends: - name: Azure.Monitor.Query safeName: AzureMonitorQuery - name: Azure.Monitor.Ingestion - safeName: AzureMonitorIngestion - CheckAOTCompat: true - AOTTestInputs: - - ArtifactName: Azure.Monitor.OpenTelemetry.Exporter - ExpectedWarningsFilepath: None + safeName: AzureMonitorIngestion \ No newline at end of file diff --git a/sdk/servicebus/ci.yml b/sdk/servicebus/ci.yml index 22ac253abfd4..0e414f57d568 100644 --- a/sdk/servicebus/ci.yml +++ b/sdk/servicebus/ci.yml @@ -34,7 +34,6 @@ extends: Artifacts: - name: Azure.Messaging.ServiceBus safeName: AzureMessagingServiceBus - CheckAotCompat: true AOTTestInputs: - ArtifactName: Azure.Messaging.ServiceBus ExpectedWarningsFilepath: Azure.Messaging.ServiceBus/tests/aotcompatibility/ExpectedWarnings.txt diff --git a/sdk/storage/ci.yml b/sdk/storage/ci.yml index 2ca0501b60bd..24a6fa7fb27d 100644 --- a/sdk/storage/ci.yml +++ b/sdk/storage/ci.yml @@ -73,7 +73,3 @@ extends: skipSmokeTests: true TestSetupSteps: - template: /sdk/storage/tests-install-azurite.yml - CheckAOTCompat: true - AOTTestInputs: - - ArtifactName: Azure.Storage.Blobs - ExpectedWarningsFilepath: None From f0267651f9bf05abfc632d7b13a5b7e2c0944640 Mon Sep 17 00:00:00 2001 From: Madalyn Redding Date: Tue, 10 Jun 2025 09:34:38 -0700 Subject: [PATCH 02/10] tweaks to language settings --- eng/scripts/Language-Settings.ps1 | 37 +++++++++++++------------------ 1 file changed, 16 insertions(+), 21 deletions(-) diff --git a/eng/scripts/Language-Settings.ps1 b/eng/scripts/Language-Settings.ps1 index bb1539a60914..dca6a53ad63d 100644 --- a/eng/scripts/Language-Settings.ps1 +++ b/eng/scripts/Language-Settings.ps1 @@ -49,31 +49,28 @@ function Get-AllPackageInfoFromRepo($serviceDirectory) $ciProps = $pkgProp.GetCIYmlForArtifact() if ($ciProps) { - # CheckAOTCompat is opt _in_, so we should default to false if not specified + # see if the check is enabled/disabled in the CI.yml $shouldAot = GetValueSafelyFrom-Yaml $ciProps.ParsedYml @("extends", "parameters", "CheckAOTCompat") - $aotFromYaml = $false if ($null -ne $shouldAot) { $parsedBool = $null if ([bool]::TryParse($shouldAot, [ref]$parsedBool)) { - $aotFromYaml = $parsedBool - } - - # when AOTCompat is true, there is an additional parameter we need to retrieve - $aotArtifacts = GetValueSafelyFrom-Yaml $ciProps.ParsedYml @("extends", "parameters", "AOTTestInputs") - if ($aotArtifacts) { - $aotArtifacts = $aotArtifacts | Where-Object { $_.ArtifactName -eq $pkgProp.ArtifactName } - $pkgProp.CIParameters["AOTTestInputs"] = $aotArtifacts + $pkgProp.CIParameters["CheckAOTCompat"] = $parsedBool } } + else + { + # respect the ci file first, but if it is not specified, then we should check the project file + $pkgProp.CIParameters["CheckAOTCompat"] = ($isAotCompatible -eq 'true') + } - # Check if the project has IsAotCompatible property set to true - $aotFromProject = ($isAotCompatible -eq 'true') - - # AOT should run if EITHER the CI YAML parameter is true OR the project has IsAotCompatible set to true - $pkgProp.CIParameters["CheckAOTCompat"] = ($aotFromYaml -or $aotFromProject) - - if (-not $aotFromYaml -and $aotFromProject) { - # If AOT is enabled from project but not from YAML, ensure we have an empty AOTTestInputs array + # see if the AOT artifacts are specified in the CI.yml + $aotArtifacts = GetValueSafelyFrom-Yaml $ciProps.ParsedYml @("extends", "parameters", "AOTTestInputs") + if ($aotArtifacts) { + $aotArtifacts = $aotArtifacts | Where-Object { $_.ArtifactName -eq $pkgProp.ArtifactName } + $pkgProp.CIParameters["AOTTestInputs"] = $aotArtifacts + } + else + { $pkgProp.CIParameters["AOTTestInputs"] = @() } @@ -92,9 +89,7 @@ function Get-AllPackageInfoFromRepo($serviceDirectory) # if the package isn't associated with a CI.yml, we still want to set the defaults values for these parameters # so that when we are checking the package set for which need to "Build Snippets" or "Check AOT" we won't crash due to the property being null else { - # Check if the project has IsAotCompatible property set to true even if there's no CI.yml - $shouldAotFromProject = ($isAotCompatible -eq 'true') - $pkgProp.CIParameters["CheckAOTCompat"] = $shouldAotFromProject + $pkgProp.CIParameters["CheckAOTCompat"] = ($isAotCompatible -eq 'true') $pkgProp.CIParameters["AOTTestInputs"] = @() $pkgProp.CIParameters["BuildSnippets"] = $true } From cd783ce3d566141b0e4bd2dd19d1e02f0d1fad30 Mon Sep 17 00:00:00 2001 From: Madalyn Redding Date: Thu, 12 Jun 2025 12:52:10 -0700 Subject: [PATCH 03/10] fix AOT warning --- .../src/Internals/Filtering/Filter.cs | 1 + 1 file changed, 1 insertion(+) diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Internals/Filtering/Filter.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Internals/Filtering/Filter.cs index 4947a96bbd6c..bea83bfcc273 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Internals/Filtering/Filter.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Internals/Filtering/Filter.cs @@ -366,6 +366,7 @@ private static MethodInfo GetMethodInfo(Expression Date: Thu, 12 Jun 2025 12:56:25 -0700 Subject: [PATCH 04/10] more fixes --- .../src/Generated/Models/DocumentIngress.cs | 4 ++++ .../src/Generated/Models/DocumentType.cs | 2 ++ 2 files changed, 6 insertions(+) diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentIngress.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentIngress.cs index 2514fbf02f8e..463107592f5e 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentIngress.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentIngress.cs @@ -6,6 +6,7 @@ #nullable disable using System.Collections.Generic; +using System.Diagnostics.CodeAnalysis; namespace Azure.Monitor.OpenTelemetry.LiveMetrics.Models { @@ -35,10 +36,13 @@ internal DocumentIngress(DocumentType documentType, IList documentStream } /// Telemetry type. Types not defined in enum will get replaced with a 'Unknown' type. + [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] internal DocumentType DocumentType { get; set; } /// An array of document streaming ids. Each id identifies a flow of documents customized by UX customers. + [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] public IList DocumentStreamIds { get; } /// Collection of custom properties. + [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] public IList Properties { get; } } } diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentType.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentType.cs index f6908708d979..f5c6bfff78fe 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentType.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentType.cs @@ -7,10 +7,12 @@ using System; using System.ComponentModel; +using System.Diagnostics.CodeAnalysis; namespace Azure.Monitor.OpenTelemetry.LiveMetrics.Models { /// Document type. + [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] internal readonly partial struct DocumentType : IEquatable { private readonly string _value; From 8c159a3a3b5514a09735d6879522878da5e95ded Mon Sep 17 00:00:00 2001 From: Madalyn Redding Date: Thu, 12 Jun 2025 13:00:06 -0700 Subject: [PATCH 05/10] update --- .../src/Generated/Models/DocumentIngress.cs | 4 ---- .../src/Generated/Models/DocumentType.cs | 2 -- 2 files changed, 6 deletions(-) diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentIngress.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentIngress.cs index 463107592f5e..2514fbf02f8e 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentIngress.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentIngress.cs @@ -6,7 +6,6 @@ #nullable disable using System.Collections.Generic; -using System.Diagnostics.CodeAnalysis; namespace Azure.Monitor.OpenTelemetry.LiveMetrics.Models { @@ -36,13 +35,10 @@ internal DocumentIngress(DocumentType documentType, IList documentStream } /// Telemetry type. Types not defined in enum will get replaced with a 'Unknown' type. - [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] internal DocumentType DocumentType { get; set; } /// An array of document streaming ids. Each id identifies a flow of documents customized by UX customers. - [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] public IList DocumentStreamIds { get; } /// Collection of custom properties. - [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] public IList Properties { get; } } } diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentType.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentType.cs index f5c6bfff78fe..f6908708d979 100644 --- a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentType.cs +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Generated/Models/DocumentType.cs @@ -7,12 +7,10 @@ using System; using System.ComponentModel; -using System.Diagnostics.CodeAnalysis; namespace Azure.Monitor.OpenTelemetry.LiveMetrics.Models { /// Document type. - [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] internal readonly partial struct DocumentType : IEquatable { private readonly string _value; From 7384f7165f978fedd0261889281ebfc2aa24e5a6 Mon Sep 17 00:00:00 2001 From: Madalyn Redding Date: Thu, 12 Jun 2025 13:03:44 -0700 Subject: [PATCH 06/10] add attribute --- .../src/Customizations/Models/DocumentType.cs | 13 +++++++++++++ 1 file changed, 13 insertions(+) create mode 100644 sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Customizations/Models/DocumentType.cs diff --git a/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Customizations/Models/DocumentType.cs b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Customizations/Models/DocumentType.cs new file mode 100644 index 000000000000..7a10ccc6f770 --- /dev/null +++ b/sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Customizations/Models/DocumentType.cs @@ -0,0 +1,13 @@ +// Copyright (c) Microsoft Corporation. All rights reserved. +// Licensed under the MIT License. + +using System.Diagnostics.CodeAnalysis; + +namespace Azure.Monitor.OpenTelemetry.LiveMetrics.Models +{ + /// Additional properties used to calculate metrics. + [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)] + internal partial struct DocumentType + { + } +} From 0789cb026155de0f1d2ec22f7cb2a9bbd60e7dee Mon Sep 17 00:00:00 2001 From: Madalyn Redding Heaps <66138537+m-redding@users.noreply.github.com> Date: Thu, 12 Jun 2025 14:44:19 -0700 Subject: [PATCH 07/10] Update Directory.Build.Common.targets --- eng/Directory.Build.Common.targets | 1 - 1 file changed, 1 deletion(-) diff --git a/eng/Directory.Build.Common.targets b/eng/Directory.Build.Common.targets index b4281b82254d..7aceea325c1d 100644 --- a/eng/Directory.Build.Common.targets +++ b/eng/Directory.Build.Common.targets @@ -383,7 +383,6 @@ false true - From 22fb2d743df261c7cfd1054ad55c61c2b9eb346f Mon Sep 17 00:00:00 2001 From: Madalyn Redding Date: Thu, 12 Jun 2025 15:45:35 -0700 Subject: [PATCH 08/10] start prompt --- .github/prompts/analyze-aot-warnings.prompt.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 .github/prompts/analyze-aot-warnings.prompt.md diff --git a/.github/prompts/analyze-aot-warnings.prompt.md b/.github/prompts/analyze-aot-warnings.prompt.md new file mode 100644 index 000000000000..4ffc03b702a0 --- /dev/null +++ b/.github/prompts/analyze-aot-warnings.prompt.md @@ -0,0 +1,4 @@ +--- +mode: 'ask' +--- +Expected output and any relevant constraints for this task. \ No newline at end of file From d6560dad3501b0483289000639f685dd1217b166 Mon Sep 17 00:00:00 2001 From: Madalyn Redding Heaps <66138537+m-redding@users.noreply.github.com> Date: Thu, 26 Jun 2025 14:29:31 -0700 Subject: [PATCH 09/10] Delete .github/prompts/fix-aot-warnings.prompt.md --- .github/prompts/fix-aot-warnings.prompt.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) delete mode 100644 .github/prompts/fix-aot-warnings.prompt.md diff --git a/.github/prompts/fix-aot-warnings.prompt.md b/.github/prompts/fix-aot-warnings.prompt.md deleted file mode 100644 index e69de29bb2d1..000000000000 From 9d65f3ea2d8eeb51c2e46d76db863f19826b94e5 Mon Sep 17 00:00:00 2001 From: Madalyn Redding Date: Tue, 8 Jul 2025 10:02:29 -0700 Subject: [PATCH 10/10] attempt --- eng/Directory.Build.Common.targets | 2 -- 1 file changed, 2 deletions(-) diff --git a/eng/Directory.Build.Common.targets b/eng/Directory.Build.Common.targets index 4f9a93c1fddd..382698757ed6 100644 --- a/eng/Directory.Build.Common.targets +++ b/eng/Directory.Build.Common.targets @@ -385,8 +385,6 @@ false true - - '$(PackageRootDirectory)' '$(ServiceDirectory)' '$(PackageId)' '$(VersionForProperties)' '$(PackageSdkType)' '$(PackageIsNewSdk)' '$(BaseOutputPath)'