testing aot pipeline updates

.github/prompts/analyze-aot-warnings.prompt.md

@@ -0,0 +1,4 @@
+---
+mode: 'ask'
+---
+Expected output and any relevant constraints for this task.

eng/Directory.Build.Common.targets

@@ -381,14 +381,18 @@
 
       <!-- Parse out the service directory based on the relative path to the sdk folder -->
       <ServiceDirectory><![CDATA[$([System.Text.RegularExpressions.Regex]::Replace($(PackageRootDirectory), '^.*[\\/]+sdk[\\/]+([^\\/]+).*$', '$1'))]]></ServiceDirectory>
-
+      <!-- Check if the project has IsAotCompatible set to true -->
+      <PackageIsAotCompatible>false</PackageIsAotCompatible>
+      <PackageIsAotCompatible Condition="'$(IsAotCompatible)' == 'true'">true</PackageIsAotCompatible>
+
       <!-- Format package info line for output -->
       <PackageInfoText Condition="'$(IsShippingLibrary)' == 'true'">'$(PackageRootDirectory)' '$(ServiceDirectory)' '$(PackageId)' '$(VersionForProperties)' '$(PackageSdkType)' '$(PackageIsNewSdk)' '$(BaseOutputPath)'</PackageInfoText>
     </PropertyGroup>
 
     <ItemGroup Condition="'$(IsShippingLibrary)' == 'true'">
       <PackageInfoLine Include="$(PackageInfoText)" />
     </ItemGroup>
+
   </Target>
 
   <Target Name="GetCodeGenProjects" Returns="@(ProjectsToInclude)">

eng/scripts/Language-Settings.ps1

@@ -51,7 +51,7 @@ function Get-AllPackageInfoFromRepo($serviceDirectory)
       continue
     }
 
-    $pkgPath, $serviceDirectory, $pkgName, $pkgVersion, $sdkType, $isNewSdk, $dllFolder = $projectOutput.Split("' '", [System.StringSplitOptions]::RemoveEmptyEntries).Trim("' ")
+    $pkgPath, $serviceDirectory, $pkgName, $pkgVersion, $sdkType, $isNewSdk, $dllFolder, $isAotCompatible = $projectOutput.Split("' '", [System.StringSplitOptions]::RemoveEmptyEntries).Trim("' ")
     if(!(Test-Path $pkgPath)) {
       Write-Host "Parsed package path `$pkgPath` does not exist so skipping the package line '$projectOutput'."
       continue
@@ -67,23 +67,28 @@ function Get-AllPackageInfoFromRepo($serviceDirectory)
     $ciProps = $pkgProp.GetCIYmlForArtifact()
 
     if ($ciProps) {
-      # CheckAOTCompat is opt _in_, so we should default to false if not specified
+      # see if the check is enabled/disabled in the CI.yml
       $shouldAot = GetValueSafelyFrom-Yaml $ciProps.ParsedYml @("extends", "parameters", "CheckAOTCompat")
       if ($null -ne $shouldAot) {
         $parsedBool = $null
         if ([bool]::TryParse($shouldAot, [ref]$parsedBool)) {
           $pkgProp.CIParameters["CheckAOTCompat"] = $parsedBool
         }
+      }
+      else
+      {
+        # respect the ci file first, but if it is not specified, then we should check the project file
+        $pkgProp.CIParameters["CheckAOTCompat"] = ($isAotCompatible -eq 'true')
+      }
 
-        # when AOTCompat is true, there is an additional parameter we need to retrieve
-        $aotArtifacts = GetValueSafelyFrom-Yaml $ciProps.ParsedYml @("extends", "parameters", "AOTTestInputs")
-        if ($aotArtifacts) {
-          $aotArtifacts = $aotArtifacts | Where-Object { $_.ArtifactName -eq $pkgProp.ArtifactName }
-          $pkgProp.CIParameters["AOTTestInputs"] = $aotArtifacts
-        }
+      # see if the AOT artifacts are specified in the CI.yml
+      $aotArtifacts = GetValueSafelyFrom-Yaml $ciProps.ParsedYml @("extends", "parameters", "AOTTestInputs")
+      if ($aotArtifacts) {
+        $aotArtifacts = $aotArtifacts | Where-Object { $_.ArtifactName -eq $pkgProp.ArtifactName }
+        $pkgProp.CIParameters["AOTTestInputs"] = $aotArtifacts
       }
-      else {
-        $pkgProp.CIParameters["CheckAOTCompat"] = $false
+      else
+      {
         $pkgProp.CIParameters["AOTTestInputs"] = @()
       }
 
@@ -102,7 +107,7 @@ function Get-AllPackageInfoFromRepo($serviceDirectory)
     # if the package isn't associated with a CI.yml, we still want to set the defaults values for these parameters
     # so that when we are checking the package set for which need to "Build Snippets" or "Check AOT" we won't crash due to the property being null
     else {
-      $pkgProp.CIParameters["CheckAOTCompat"] = $false
+      $pkgProp.CIParameters["CheckAOTCompat"] = ($isAotCompatible -eq 'true')
       $pkgProp.CIParameters["AOTTestInputs"] = @()
       $pkgProp.CIParameters["BuildSnippets"] = $true
     }

sdk/appconfiguration/Azure.Data.AppConfiguration/src/Azure.Data.AppConfiguration.csproj

@@ -9,6 +9,8 @@
     <PackageTags>Microsoft Azure Application Configuration;Data;AppConfig;$(PackageCommonTags)</PackageTags>
     <TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
     <NoWarn>$(NoWarn);3021;</NoWarn>
+    <IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
+    <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
     <IncludeOperationsSharedSource>true</IncludeOperationsSharedSource>
   </PropertyGroup>
 

sdk/appconfiguration/ci.yml

@@ -34,8 +34,4 @@ extends:
     ArtifactName: packages
     Artifacts:
     - name: Azure.Data.AppConfiguration
-      safeName: AzureDataAppConfiguration
-    CheckAOTCompat: true
-    AOTTestInputs:
-    - ArtifactName: Azure.Data.AppConfiguration
-      ExpectedWarningsFilepath: None
+      safeName: AzureDataAppConfiguration

sdk/extensions/Microsoft.Extensions.Azure/src/Microsoft.Extensions.Azure.csproj

@@ -11,6 +11,9 @@
 
     <!-- Make sure that we don't pull in additional dependencies during build or package -->
     <ImportDefaultReferences>false</ImportDefaultReferences>
+
+    <IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
+    <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
 
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <EnableClientSdkAnalyzers>false</EnableClientSdkAnalyzers>

sdk/extensions/ci.yml

@@ -37,7 +37,3 @@ extends:
       safeName: AzureExtensionsAspNetCoreConfigurationSecrets
     - name: Microsoft.Azure.WebJobs.Extensions.Clients
       safeName: MicrosoftAzureWebJobsExtensionsClients
-    CheckAOTCompat: false
-    AOTTestInputs:
-    - ArtifactName: Microsoft.Extensions.Azure
-      ExpectedWarningsFilepath: None

sdk/identity/Azure.Identity.Broker/src/Azure.Identity.Broker.csproj

@@ -10,6 +10,8 @@
     <TargetFrameworks Condition="$([MSBuild]::IsOsPlatform('OSX'))">$(RequiredTargetFrameworks);net8.0</TargetFrameworks>
     <TargetFrameworks Condition="$([MSBuild]::IsOsPlatform('Linux'))">$(RequiredTargetFrameworks);net8.0</TargetFrameworks>
     <NoWarn>$(NoWarn);3021</NoWarn>
+    <IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
+    <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
   <ItemGroup>

sdk/identity/Azure.Identity/src/Azure.Identity.csproj

@@ -8,6 +8,8 @@
     <PackageTags>Microsoft Azure Identity;$(PackageCommonTags)</PackageTags>
     <TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
     <NoWarn>$(NoWarn);3021;AZC0011</NoWarn>
+    <IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
+    <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
   </PropertyGroup>
   <!--Conditionally define the PREVIEW_FEATURE_FLAG constant if the version is pre-release-->

sdk/identity/ci.yml

@@ -31,9 +31,6 @@ extends:
       safeName: AzureIdentity
     - name: Azure.Identity.Broker
       safeName: AzureIdentityBroker
-    CheckAOTCompat: true
     AOTTestInputs:
-    - ArtifactName: Azure.Identity
-      ExpectedWarningsFilepath: None
     - ArtifactName: Azure.Identity.Broker
       ExpectedWarningsFilepath: "Azure.Identity.Broker/tests/compatibility/ExpectedWarnings.txt"

sdk/keyvault/Azure.Security.KeyVault.Secrets/src/Azure.Security.KeyVault.Secrets.csproj

@@ -10,6 +10,8 @@
 
     <TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
     <NoWarn>$(NoWarn);3021</NoWarn>
+    <IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
+    <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
     <AllowUnsafeBlocks>true</AllowUnsafeBlocks>
     <IncludeOperationsSharedSource>true</IncludeOperationsSharedSource>
   </PropertyGroup>

sdk/keyvault/ci.yml

@@ -47,7 +47,3 @@ extends:
       safeName: AzureSecurityKeyVaultSecrets
       triggeringPaths:
       - Azure.Security.Keyvault.Shared
-    CheckAOTCompat: true
-    AOTTestInputs:
-    - ArtifactName: Azure.Security.KeyVault.Secrets
-      ExpectedWarningsFilepath: None

sdk/monitor/Azure.Monitor.OpenTelemetry.Exporter/src/Azure.Monitor.OpenTelemetry.Exporter.csproj

@@ -9,6 +9,8 @@
     <TargetFrameworks>$(RequiredTargetFrameworks)</TargetFrameworks>
     <IncludeOperationsSharedSource>true</IncludeOperationsSharedSource>
     <DefineConstants>$(DefineConstants);AZURE_MONITOR_EXPORTER;</DefineConstants>
+    <IsTrimmable Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net6.0'))">true</IsTrimmable>
+    <IsAotCompatible Condition="$([MSBuild]::IsTargetFrameworkCompatible('$(TargetFramework)', 'net7.0'))">true</IsAotCompatible>
   </PropertyGroup>
 
   <ItemGroup>

sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Customizations/Models/DocumentType.cs

@@ -0,0 +1,13 @@
+// Copyright (c) Microsoft Corporation. All rights reserved.
+// Licensed under the MIT License.
+
+using System.Diagnostics.CodeAnalysis;
+
+namespace Azure.Monitor.OpenTelemetry.LiveMetrics.Models
+{
+    /// <summary> Additional properties used to calculate metrics. </summary>
+    [DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicProperties)]
+    internal partial struct DocumentType
+    {
+    }
+}

sdk/monitor/Azure.Monitor.OpenTelemetry.LiveMetrics/src/Internals/Filtering/Filter.cs

@@ -366,6 +366,7 @@ private static MethodInfo GetMethodInfo<T1, T2, TResult>(Expression<Func<T1, T2,
             throw new ArgumentException(string.Format(CultureInfo.InvariantCulture, "Expression is not a method"), nameof(expression));
         }
 
+        [UnconditionalSuppressMessage("AOT", "IL2072", Justification = "The DocumentIngress class and its derived classes have DynamicallyAccessedMembers attribute applied to preserve public properties.")]
         private static Type GetPropertyTypeFromFieldName(string fieldName)
         {
             try

sdk/monitor/ci.yml

@@ -46,8 +46,4 @@ extends:
     - name: Azure.Monitor.Query
       safeName: AzureMonitorQuery
     - name: Azure.Monitor.Ingestion
-      safeName: AzureMonitorIngestion
-    CheckAOTCompat: true
-    AOTTestInputs:
-    - ArtifactName: Azure.Monitor.OpenTelemetry.Exporter
-      ExpectedWarningsFilepath: None
+      safeName: AzureMonitorIngestion

sdk/servicebus/ci.yml

@@ -34,7 +34,6 @@ extends:
     Artifacts:
     - name: Azure.Messaging.ServiceBus
       safeName: AzureMessagingServiceBus
-    CheckAotCompat: true
     AOTTestInputs:
     - ArtifactName: Azure.Messaging.ServiceBus
       ExpectedWarningsFilepath: Azure.Messaging.ServiceBus/tests/aotcompatibility/ExpectedWarnings.txt

sdk/storage/ci.yml

@@ -81,7 +81,3 @@ extends:
       skipSmokeTests: true
     TestSetupSteps:
     - template: /sdk/storage/tests-install-azurite.yml
-    CheckAOTCompat: true
-    AOTTestInputs:
-    - ArtifactName: Azure.Storage.Blobs
-      ExpectedWarningsFilepath: None