Add thread message delete operation #50665
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nick863
requested review from
trangevi,
dargilco,
jhakulin and
glharper
as code owners
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces a delete operation for thread messages in the Persistent Agents SDK, along with the necessary tests and documentation updates.
- Updated the commit hash in the configuration file.
- Added synchronous and asynchronous delete methods in ThreadMessages.cs with corresponding tests.
- Updated sample documentation and assets to reflect the new feature.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/ai/Azure.AI.Agents.Persistent/tsp-location.yaml | Updated commit reference. |
| sdk/ai/Azure.AI.Agents.Persistent/tests/PersistentAgentsTests.cs | Added tests to verify the delete message operation. |
| sdk/ai/Azure.AI.Agents.Persistent/src/Custom/ThreadMessages.cs | Added DeleteMessage and DeleteMessageAsync methods. |
| sdk/ai/Azure.AI.Agents.Persistent/samples/Sample20_PersistentAgents_FileSearch_Steaming.md | Updated sample title to include streaming. |
| sdk/ai/Azure.AI.Agents.Persistent/samples/README.md | Added a link for the new sample. |
| sdk/ai/Azure.AI.Agents.Persistent/assets.json | Updated asset tag revision. |
| sdk/ai/Azure.AI.Agents.Persistent/CHANGELOG.md | Documented the addition of the delete operation. |
Comments suppressed due to low confidence (2)
sdk/ai/Azure.AI.Agents.Persistent/src/Custom/ThreadMessages.cs:376
- The diagnostic scope name 'PersistentAgentsClient.DeleteThread' does not match the delete operation for messages. Consider updating it to 'PersistentAgentsClient.DeleteMessage' for clarity and consistency.
using DiagnosticScope scope = ClientDiagnostics.CreateScope("PersistentAgentsClient.DeleteThread");
sdk/ai/Azure.AI.Agents.Persistent/src/Custom/ThreadMessages.cs:402
- Similarly, in the asynchronous method, the diagnostic scope name should reflect the delete operation for messages by using 'PersistentAgentsClient.DeleteMessage' to avoid confusion.
using DiagnosticScope scope = ClientDiagnostics.CreateScope("PersistentAgentsClient.DeleteThread");
nick863
force-pushed
the
nirovins/add_message_delete
branch
from
d5a407a to
4208b77
Compare
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
nick863
force-pushed
the
nirovins/add_message_delete
branch
2 times, most recently
from
4542cec to
0b7bae6
Compare
glharper
approved these changes
Jun 23, 2025
nick863
force-pushed
the
nirovins/add_message_delete
branch
from
0b7bae6 to
c5e2f6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#50607
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.