-
Notifications
You must be signed in to change notification settings - Fork 5k
update Azure.Provisioning.Resources
to match latest api-version
#50786
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
update Azure.Provisioning.Resources
to match latest api-version
#50786
Conversation
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
…rsion-for-provisioning
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the Azure.Provisioning.Resources models to match the latest API version. Key changes include the introduction of derived types (AzureCliScript and AzurePowerShellScript) for ArmDeploymentScript, updates to API definitions across multiple target frameworks, and a package version bump for Azure.ResourceManager.Resources.
Reviewed Changes
Copilot reviewed 10 out of 57 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
sdk/provisioning/Generator/src/Specifications/ResourcesSpecification.cs | Added customization for AzureCliScript and AzurePowerShellScript and removed common properties on these resource types. |
sdk/provisioning/Generator/src/Specifications/ArmSpecification.cs | Added new using directives for AppService and System; no functional changes. |
sdk/provisioning/Generator/src/Specifications/AppServiceSpecification.cs | Changed visibility for FindConstructibleResources to private protected. |
sdk/provisioning/Generator/src/Model/Specification.Analyze.cs | Adjusted accessibility for FindConstructibleResources and used new collection expressions. |
sdk/provisioning/Generator/src/Model/Resource.cs | Updated class generation with conditional base constructor chaining based on BaseType. |
sdk/provisioning/Azure.Provisioning (api files) | Updated API definitions and added new resource types and properties consistent with the latest API version. |
sdk/provisioning/Azure.Provisioning/CHANGELOG.md | Updated changelog reflecting new features and version bump. |
eng/Packages.Data.props | Bumped package version for Azure.ResourceManager.Resources from 1.9.1 to 1.11.0. |
Comments suppressed due to low confidence (2)
sdk/provisioning/Generator/src/Specifications/AppServiceSpecification.cs:75
- [nitpick] The change from 'protected' to 'private protected' for FindConstructibleResources() should be reviewed to ensure it aligns with the intended API usage. Adding a brief comment on the rationale for this reduced accessibility might improve clarity for future maintainers.
private protected override Dictionary<Type, MethodInfo> FindConstructibleResources()
sdk/provisioning/Generator/src/Model/Resource.cs:149
- The conditional constructor chaining based on the presence of BaseType is central to the class generation logic. Please verify that the parameters passed in both branches align with the appropriate base constructor overloads.
}
Fixes #49283