Skip to content

Implement IJsonModel<> for Azure.Core.Expressions.DataFactory types #50807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Jul 15, 2025
Merged

Implement IJsonModel<> for Azure.Core.Expressions.DataFactory types #50807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
2552a51
Initial plan for issue
Copilot Jun 24, 2025
6c15a4e
Implement IJsonModel<> for DataFactory types - complete implementation
Copilot Jun 24, 2025
19d1900
Address PR review feedback - add parameterless constructors and updat…
Copilot Jun 24, 2025
358531c
Remove unnecessary warning suppressions for types with parameterless …
Copilot Jun 24, 2025
0e2eccf
Remove unnecessary null-coalescing throw operations in IPersistableMo…
Copilot Jun 25, 2025
e1c6116
Use parameterless constructors instead of null-forgiving operators in…
Copilot Jun 25, 2025
dbf6bfd
Remove parameterless constructor fallback and disable nullable warnin…
Copilot Jun 25, 2025
f31c7f0
Remove warning suppressions and add #nullable disable to serializatio…
Copilot Jun 25, 2025
9f25327
Remove unnecessary #nullable disable from serialization files and fix…
Copilot Jun 27, 2025
3d2e16a
Upgrade System.ClientModel to 1.5.0 for nullable IJsonModel/IPersista…
Copilot Jul 8, 2025
ab8fe9d
Merge remote-tracking branch 'origin/main' into copilot/fix-50787
Copilot Jul 10, 2025
24924eb
Update nullability for IJsonModel.Create and IPersistableModel.Create…
Copilot Jul 10, 2025
9942666
Update deserialize methods to return nullable types and fix converter…
Copilot Jul 10, 2025
84d9a3b
Update converter Read methods to return nullable types and remove nul…
Copilot Jul 10, 2025
ebdb288
Add Azure.Core.Expressions.DataFactory to AOT compatibility checks
Copilot Jul 10, 2025
d9a7e12
Update AOT config: use None instead of empty ExpectedAotWarnings.txt …
Copilot Jul 10, 2025
d2d4a16
Add ExpectedAotWarnings.txt file with existing AOT warnings and updat…
Copilot Jul 11, 2025
5b05eed
Remove numbered prefixes from ExpectedAotWarnings.txt file
Copilot Jul 11, 2025
37c96ed
Update ExpectedAotWarnings.txt with flexible regex patterns for warni…
Copilot Jul 11, 2025
435e68a
add missing warnings
live1206 Jul 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 24 additions & 4 deletions sdk/core/Azure.Core.Expressions.DataFactory/api/Azure.Core.Expressions.DataFactory.net8.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,29 @@ internal DataFactoryElement() { }
System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryElement<T>>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
public override string? ToString() { throw null; }
}
public partial class DataFactoryKeyVaultSecret : Azure.Core.Expressions.DataFactory.DataFactorySecret
public partial class DataFactoryKeyVaultSecret : Azure.Core.Expressions.DataFactory.DataFactorySecret, System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>, System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>
{
public DataFactoryKeyVaultSecret(Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference store, Azure.Core.Expressions.DataFactory.DataFactoryElement<string> secretName) { }
public Azure.Core.Expressions.DataFactory.DataFactoryElement<string> SecretName { get { throw null; } set { } }
public Azure.Core.Expressions.DataFactory.DataFactoryElement<string> SecretVersion { get { throw null; } set { } }
public Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference Store { get { throw null; } set { } }
Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret? System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>.Create(ref System.Text.Json.Utf8JsonReader reader, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
void System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>.Write(System.Text.Json.Utf8JsonWriter writer, System.ClientModel.Primitives.ModelReaderWriterOptions options) { }
Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret? System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>.Create(System.BinaryData data, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
string System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
}
public partial class DataFactoryLinkedServiceReference
public partial class DataFactoryLinkedServiceReference : System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>, System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>
{
public DataFactoryLinkedServiceReference(Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReferenceKind referenceKind, string referenceName) { }
public System.Collections.Generic.IDictionary<string, System.BinaryData?> Parameters { get { throw null; } }
public Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReferenceKind ReferenceKind { get { throw null; } set { } }
public string? ReferenceName { get { throw null; } set { } }
Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference? System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>.Create(ref System.Text.Json.Utf8JsonReader reader, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
void System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>.Write(System.Text.Json.Utf8JsonWriter writer, System.ClientModel.Primitives.ModelReaderWriterOptions options) { }
Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference? System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>.Create(System.BinaryData data, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
string System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
}
[System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
public readonly partial struct DataFactoryLinkedServiceReferenceKind : System.IEquatable<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReferenceKind>
Expand All @@ -75,14 +85,24 @@ public DataFactoryLinkedServiceReference(Azure.Core.Expressions.DataFactory.Data
public static bool operator !=(Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReferenceKind left, Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReferenceKind right) { throw null; }
public override string ToString() { throw null; }
}
public abstract partial class DataFactorySecret
public abstract partial class DataFactorySecret : System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>, System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>
{
protected DataFactorySecret() { }
Azure.Core.Expressions.DataFactory.DataFactorySecret? System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>.Create(ref System.Text.Json.Utf8JsonReader reader, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
void System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>.Write(System.Text.Json.Utf8JsonWriter writer, System.ClientModel.Primitives.ModelReaderWriterOptions options) { }
Azure.Core.Expressions.DataFactory.DataFactorySecret? System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>.Create(System.BinaryData data, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
string System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
}
public partial class DataFactorySecretString : Azure.Core.Expressions.DataFactory.DataFactorySecret
public partial class DataFactorySecretString : Azure.Core.Expressions.DataFactory.DataFactorySecret, System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>, System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>
{
public DataFactorySecretString(string value) { }
public string? Value { get { throw null; } set { } }
public static implicit operator Azure.Core.Expressions.DataFactory.DataFactorySecretString (string literal) { throw null; }
Azure.Core.Expressions.DataFactory.DataFactorySecretString? System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>.Create(ref System.Text.Json.Utf8JsonReader reader, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
void System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>.Write(System.Text.Json.Utf8JsonWriter writer, System.ClientModel.Primitives.ModelReaderWriterOptions options) { }
Azure.Core.Expressions.DataFactory.DataFactorySecretString? System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>.Create(System.BinaryData data, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
string System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
}
}
28 changes: 24 additions & 4 deletions ...ure.Core.Expressions.DataFactory/api/Azure.Core.Expressions.DataFactory.netstandard2.0.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,19 +44,29 @@ internal DataFactoryElement() { }
System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryElement<T>>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
public override string? ToString() { throw null; }
}
public partial class DataFactoryKeyVaultSecret : Azure.Core.Expressions.DataFactory.DataFactorySecret
public partial class DataFactoryKeyVaultSecret : Azure.Core.Expressions.DataFactory.DataFactorySecret, System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>, System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>
{
public DataFactoryKeyVaultSecret(Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference store, Azure.Core.Expressions.DataFactory.DataFactoryElement<string> secretName) { }
public Azure.Core.Expressions.DataFactory.DataFactoryElement<string> SecretName { get { throw null; } set { } }
public Azure.Core.Expressions.DataFactory.DataFactoryElement<string> SecretVersion { get { throw null; } set { } }
public Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference Store { get { throw null; } set { } }
Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret? System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>.Create(ref System.Text.Json.Utf8JsonReader reader, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
void System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>.Write(System.Text.Json.Utf8JsonWriter writer, System.ClientModel.Primitives.ModelReaderWriterOptions options) { }
Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret? System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>.Create(System.BinaryData data, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
string System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryKeyVaultSecret>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
}
public partial class DataFactoryLinkedServiceReference
public partial class DataFactoryLinkedServiceReference : System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>, System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>
{
public DataFactoryLinkedServiceReference(Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReferenceKind referenceKind, string referenceName) { }
public System.Collections.Generic.IDictionary<string, System.BinaryData?> Parameters { get { throw null; } }
public Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReferenceKind ReferenceKind { get { throw null; } set { } }
public string? ReferenceName { get { throw null; } set { } }
Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference? System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>.Create(ref System.Text.Json.Utf8JsonReader reader, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
void System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>.Write(System.Text.Json.Utf8JsonWriter writer, System.ClientModel.Primitives.ModelReaderWriterOptions options) { }
Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference? System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>.Create(System.BinaryData data, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
string System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReference>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
}
[System.Runtime.InteropServices.StructLayoutAttribute(System.Runtime.InteropServices.LayoutKind.Sequential)]
public readonly partial struct DataFactoryLinkedServiceReferenceKind : System.IEquatable<Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReferenceKind>
Expand All @@ -75,14 +85,24 @@ public DataFactoryLinkedServiceReference(Azure.Core.Expressions.DataFactory.Data
public static bool operator !=(Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReferenceKind left, Azure.Core.Expressions.DataFactory.DataFactoryLinkedServiceReferenceKind right) { throw null; }
public override string ToString() { throw null; }
}
public abstract partial class DataFactorySecret
public abstract partial class DataFactorySecret : System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>, System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>
{
protected DataFactorySecret() { }
Azure.Core.Expressions.DataFactory.DataFactorySecret? System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>.Create(ref System.Text.Json.Utf8JsonReader reader, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
void System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>.Write(System.Text.Json.Utf8JsonWriter writer, System.ClientModel.Primitives.ModelReaderWriterOptions options) { }
Azure.Core.Expressions.DataFactory.DataFactorySecret? System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>.Create(System.BinaryData data, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
string System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecret>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
}
public partial class DataFactorySecretString : Azure.Core.Expressions.DataFactory.DataFactorySecret
public partial class DataFactorySecretString : Azure.Core.Expressions.DataFactory.DataFactorySecret, System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>, System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>
{
public DataFactorySecretString(string value) { }
public string? Value { get { throw null; } set { } }
public static implicit operator Azure.Core.Expressions.DataFactory.DataFactorySecretString (string literal) { throw null; }
Azure.Core.Expressions.DataFactory.DataFactorySecretString? System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>.Create(ref System.Text.Json.Utf8JsonReader reader, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
void System.ClientModel.Primitives.IJsonModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>.Write(System.Text.Json.Utf8JsonWriter writer, System.ClientModel.Primitives.ModelReaderWriterOptions options) { }
Azure.Core.Expressions.DataFactory.DataFactorySecretString? System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>.Create(System.BinaryData data, System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
string System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>.GetFormatFromOptions(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
System.BinaryData System.ClientModel.Primitives.IPersistableModel<Azure.Core.Expressions.DataFactory.DataFactorySecretString>.Write(System.ClientModel.Primitives.ModelReaderWriterOptions options) { throw null; }
}
}
Loading