Initial release for Azure.ResourceManager.Resources.Deployments #50929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
Initial release for Azure.ResourceManager.Resources.Deployments, adding the core SDK deliverables and project scaffolding.
- Introduce
ArmDeploymentPropertiesExtendedmodel extension with debug and resource listing helpers - Add project metadata files (
.csproj, solution, props, assets, samples) for package setup - Provide documentation and release notes (README, CHANGELOG)
Reviewed Changes
Copilot reviewed 8 out of 173 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| sdk/resources/Azure.ResourceManager.Resources.Deployments/src/Custom/Model/ArmDeploymentPropertiesExtended.cs | Add extended deployment properties model |
| sdk/resources/Azure.ResourceManager.Resources.Deployments/src/Azure.ResourceManager.Resources.Deployments.csproj | Define package version, ID, and metadata |
| sdk/resources/Azure.ResourceManager.Resources.Deployments/samples/Azure.ResourceManager.Resources.Deployments.Samples.csproj | Add sample project references and test dependencies |
| sdk/resources/Azure.ResourceManager.Resources.Deployments/assets.json | Configure assets repository settings |
| sdk/resources/Azure.ResourceManager.Resources.Deployments/Directory.Build.props | Import shared build settings |
| sdk/resources/Azure.ResourceManager.Resources.Deployments/README.md | Add library overview and usage instructions |
| sdk/resources/Azure.ResourceManager.Resources.Deployments/CHANGELOG.md | Initialize release history for 1.0.0-beta.1 |
| sdk/resources/Azure.ResourceManager.Resources.Deployments/Azure.ResourceManager.Resources.Deployments.sln | Create solution file linking projects |
Comments suppressed due to low confidence (4)
sdk/resources/Azure.ResourceManager.Resources.Deployments/README.md:3
- The README contains a placeholder description at the top. Please replace this with a concise overview of the Azure Resources.Deployments service functionality.
**[Describe the service briefly first.]**
sdk/resources/Azure.ResourceManager.Resources.Deployments/CHANGELOG.md:19
- The link URL contains a double slash after the domain, which may break navigation. Please correct it to a single slash:
https://docs.microsoft.com/dotnet/api/overview/azure/identity-readme?view=azure-dotnet.
> NOTE: For more information about unified authentication, please refer to [Microsoft Azure Identity documentation for .NET](https://docs.microsoft.com//dotnet/api/overview/azure/identity-readme?view=azure-dotnet).
sdk/resources/Azure.ResourceManager.Resources.Deployments/src/Custom/Model/ArmDeploymentPropertiesExtended.cs:33
- [nitpick] Filtering null IDs by creating SubResource with null may lead to invalid entries. Consider filtering out details where d.Id is null before mapping or handling null values explicitly.
=> OutputResourceDetails.Select(d => ResourceManagerModelFactory.SubResource(d.Id != null ? new ResourceIdentifier(d.Id) : null)).ToArray();
sdk/resources/Azure.ResourceManager.Resources.Deployments/src/Custom/Model/ArmDeploymentPropertiesExtended.cs:41
- [nitpick] Similar to OutputResources, this mapping may include entries with null IDs. Consider filtering out or handling null Ids to prevent creating SubResource instances with null identifiers.
=> ValidatedResourceDetails.Select(d => ResourceManagerModelFactory.SubResource(d.Id != null ? new ResourceIdentifier(d.Id) : null)).ToArray();
| { | ||
| get => DebugSetting?.DetailLevel; | ||
| [EditorBrowsable(EditorBrowsableState.Never)] | ||
| set => DebugSetting.DetailLevel = value; |
There was a problem hiding this comment.
The setter for DebugSettingDetailLevel assumes DebugSetting is non-null and will throw a NullReferenceException if DebugSetting is null. Consider initializing DebugSetting or adding a null check before setting DetailLevel.
Copilot uses AI. Check for mistakes.
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
anthony-c-martin
force-pushed
the
ant/deployments
branch
from
531a36a to
9ce301a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.