Refine new project scaffolding. #50930
Open
+56
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haiyuazhang
requested review from
JoshLove-msft,
m-nash,
jorgerangel-msft,
live1206,
ArcturusZhang,
jsquire and
christothes
as code owners
github-actions
bot
added
Client
There was a problem hiding this comment.
Pull Request Overview
Refines the new project scaffolding to consolidate compile-include logic, cache path-segment calculations, and improve the helper method’s interface.
- Introduces a cached
PathSegmentCountproperty for directory-depth computation - Extracts compile-include assembly into a new
BuildCompileIncludesoverride - Updates
GetCompileIncludesignature with an optional parameter and XML documentation
Comments suppressed due to low confidence (1)
eng/packages/http-client-csharp/generator/Azure.Generator/src/Primitives/NewAzureProjectScaffolding.cs:138
- Consider adding unit tests for
BuildCompileIncludesto verify include lists under different scenarios (API key auth enabled, operations present, long-running operations present).
protected override IReadOnlyList<CSharpProjectCompileInclude> BuildCompileIncludes()
...es/http-client-csharp/generator/Azure.Generator/src/Primitives/NewAzureProjectScaffolding.cs
Show resolved
Hide resolved
...es/http-client-csharp/generator/Azure.Generator/src/Primitives/NewAzureProjectScaffolding.cs
Outdated
Show resolved
Hide resolved
…Primitives/NewAzureProjectScaffolding.cs a minor change. Co-authored-by: Dapeng Zhang <ufo54153@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this change is to let management generator has the ability to add dedicated compile include files.