add AdditionalProperties in VirtualMachineScaleSetVmProperties
#50933
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for additional properties in the VirtualMachineScaleSetVmProperties model, enabling the SDK to send and receive private/internal properties as defined by the service. Key changes include:
- Updates to the autorest configuration to enable additional properties on VirtualMachineScaleSetVMProperties.
- Modifications to the VirtualMachineScaleSetVmData and related factory methods to include the new AdditionalProperties.
- Version bump and changelog updates reflecting the production release.
Reviewed Changes
Copilot reviewed 7 out of 14 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/compute/Azure.ResourceManager.Compute/src/autorest.md | Added directives to enable additional properties on VirtualMachineScaleSetVM and VirtualMachineScaleSetVMProperties. |
| sdk/compute/Azure.ResourceManager.Compute/src/Customize/VirtualMachineScaleSetVmData.cs | Updated data model properties to support the new AdditionalProperties functionality. |
| sdk/compute/Azure.ResourceManager.Compute/src/Customize/ArmComputeModelFactory.cs | Added overloads for the new AdditionalProperties parameter in factory methods. |
| sdk/compute/Azure.ResourceManager.Compute.csproj | Updated version from beta to final. |
| sdk/compute/Azure.ResourceManager.Compute/api/* | Updated API definitions and model classes to include AdditionalProperties. |
| sdk/compute/Azure.ResourceManager.Compute/CHANGELOG.md | Updated changelog entries with new features and breaking changes. |
Comments suppressed due to low confidence (1)
sdk/compute/Azure.ResourceManager.Compute/src/autorest.md:428
- There is a naming inconsistency between the autorest directive ('VirtualMachineScaleSetVMProperties') and the SDK class name ('VirtualMachineScaleSetVmProperties'). Consider reviewing this naming to ensure it is intentional and consistent.
$.VirtualMachineScaleSetVMProperties.additionalProperties = true;
ArthurMa1978
approved these changes
Jun 27, 2025
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.