fix the NullReferenceException issue in Azure.ResourceManager.Network
#50935
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a NullReferenceException in LoadBalancingRuleData by ensuring its Properties field is always initialized, and updates the package version and changelog to release the fix.
- Replaced parameterless
LoadBalancingRuleProperties()calls withLoadBalancingRuleProperties(default, default)in each setter - Bumped
<Version>to1.11.1in the project file - Added an entry in
CHANGELOG.mdfor the bug fix
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| sdk/network/Azure.ResourceManager.Network/src/Customization/LoadBalancingRuleData.cs | Guard against null Properties by calling the new constructor with defaults |
| sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj | Updated package <Version> to 1.11.1 |
| sdk/network/Azure.ResourceManager.Network/CHANGELOG.md | Added release entry and bug fix description |
Comments suppressed due to low confidence (2)
sdk/network/Azure.ResourceManager.Network/src/Customization/LoadBalancingRuleData.cs:26
- Add unit tests to cover the case when
Propertiesis initially null to ensure assignments no longer trigger aNullReferenceException.
Properties = new LoadBalancingRuleProperties(default, default);
sdk/network/Azure.ResourceManager.Network/src/Azure.ResourceManager.Network.csproj:3
- The
<Version>was updated to1.11.1but the<ApiCompatVersion>remains at1.11.0. Verify whether the API compatibility version should be aligned with the package version.
<Version>1.11.1</Version>
sdk/network/Azure.ResourceManager.Network/src/Customization/LoadBalancingRuleData.cs
Outdated
Show resolved
Hide resolved
ArthurMa1978
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #50934
Since
BackendAddressPoolsproperty is a collection and does not have a setter, we could not fix the issue that if some one tries to add values directly to this, and gets NRE.We always recommend to use those properties in the
LoadBalancingRulePropertiesinstead.Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.