Generating new SDKs for Microsoft.Dashboard 2024-11-01-preview after adding missing LRO header for Grafana_Update #51318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshelton1
commented
Jul 17, 2025
sdk/grafana/Azure.ResourceManager.Grafana/src/Generated/GrafanaIntegrationFabricCollection.cs
Outdated
Show resolved
Hide resolved
joshelton1
commented
Jul 17, 2025
...na/Azure.ResourceManager.Grafana/src/Generated/GrafanaPrivateEndpointConnectionCollection.cs
Outdated
Show resolved
Hide resolved
joshelton1
commented
Jul 17, 2025
sdk/grafana/Azure.ResourceManager.Grafana/src/Generated/ArmGrafanaModelFactory.cs
Outdated
Show resolved
Hide resolved
joshelton1
commented
Jul 17, 2025
sdk/grafana/Azure.ResourceManager.Grafana/src/Generated/Extensions/GrafanaExtensions.cs
Outdated
Show resolved
Hide resolved
joshelton1
changed the title
API Change CheckAPIView identified API level changes in this PR and created the following API reviews |
.../Azure.ResourceManager.Grafana/src/Generated/RestOperations/ManagedGrafanasRestOperations.cs
Show resolved
Hide resolved
joshelton1
changed the title
joshelton1
commented
Jul 21, 2025
sdk/grafana/Azure.ResourceManager.Grafana/api/Azure.ResourceManager.Grafana.net8.0.cs
Outdated
Show resolved
Hide resolved
joshelton1
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Azure ResourceManager Grafana SDK by regenerating code from a newer commit in the azure-rest-api-specs repository. The primary change involves adding missing Long Running Operation (LRO) header support for the Grafana Update operation, which converts the Update method from a synchronous operation to an asynchronous LRO pattern.
- Updates the tsp-location.yaml to reference a newer commit containing LRO header fixes
- Modifies the Update operation signature to follow the LRO pattern with ArmOperation return type
- Reorders parameters in the ManagedGrafanaData factory method
Reviewed Changes
Copilot reviewed 3 out of 10 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tsp-location.yaml | Updates commit hash to newer version with LRO header fixes |
| Azure.ResourceManager.Grafana.netstandard2.0.cs | Changes Update methods to LRO pattern and reorders ManagedGrafanaData parameters |
| Azure.ResourceManager.Grafana.net8.0.cs | Identical changes to netstandard2.0 version for .NET 8.0 target |
sdk/grafana/Azure.ResourceManager.Grafana/api/Azure.ResourceManager.Grafana.netstandard2.0.cs
Show resolved
Hide resolved
joshelton1
force-pushed
the
joshelton1/072025
branch
2 times, most recently
from
514c1de to
87a034b
Compare
qingquanzhao
reviewed
Aug 5, 2025
sdk/grafana/Azure.ResourceManager.Grafana/api/Azure.ResourceManager.Grafana.net8.0.cs
Show resolved
Hide resolved
sdk/grafana/Azure.ResourceManager.Grafana/src/Generated/ManagedGrafanaData.cs
Show resolved
Hide resolved
qingquanzhao
approved these changes
Aug 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit (18 July 2025):
Regenerated code with new commit, tests pass:
Related PRs:
Private Repo: Add missing long-running-operation header to Microsoft.Dashboard spec for current + future API versions
Public Repo: Add missing Grafana_Update LRO header to Microsoft.Dashboard 2024-11-01-preview and update TypeSpec spec