[Network] Fix for issue #51467 #51573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a deserialization issue in ManagedRuleSetRuleGroup where rule IDs could be represented as either strings or numbers in JSON, causing parsing failures with mixed-type arrays.
Key Changes
- Added custom deserialization logic to handle mixed string/number rule ID arrays
- Added comprehensive test coverage with test data file
- Updated changelog to document the bug fix
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/Customization/Models/ManagedRuleSetRuleGroup.cs |
Implements custom deserialization hook to convert both string and numeric rule IDs to strings |
tests/Tests/UnitTest.cs |
Adds regression test for mixed rule ID type deserialization |
tests/TestData/ManagedRuleSetRuleGroup.json |
Provides test data with mixed string/numeric rule IDs |
tests/Azure.ResourceManager.Network.Tests.csproj |
Configures test data file to be copied to output directory |
CHANGELOG.md |
Documents the bug fix in the changelog |
sdk/network/Azure.ResourceManager.Network/src/Customization/Models/ManagedRuleSetRuleGroup.cs
Show resolved
Hide resolved
ArthurMa1978
approved these changes
Aug 1, 2025
|
@microsoft-github-policy-service rerun |
|
/checkenforcer override |
|
/checkenforcer evaluate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the fix for issue #51467 .
Fixed the issue in
ManagedRuleSetRuleGroupdeserialization where rule IDs could be either strings or numbers in JSON, causingInvalidOperationExceptionwhen parsing mixed-type arrays.Contributing to the Azure SDK
Please see our CONTRIBUTING.md if you are not familiar with contributing to this repository or have questions.
For specific information about pull request etiquette and best practices, see this section.